Re: [PATCH v2 00/14] IB/srpt: Add RDMA/CM support

[Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1162 bytes --]

On Wed, 2018-01-17 at 18:14 -0500, Doug Ledford wrote:
> On Tue, 2018-01-16 at 16:14 -0800, Bart Van Assche wrote:
> > Hello Jason and Doug,
> > 
> > This patch series not only adds RDMA/CM support to the SRP target driver but
> > also fixes a number of race conditions in that driver.
> > 
> > The RDMA/CM listener port number has to be specified as an ib_srpt kernel
> > module parameter. The default value for that parameter is zero which means
> > that RDMA/CM support is disabled.
> 
> Since srpt is already configured via the lIO framework, wouldn't that be
> a better place for the listen port?  In fact, shouldn't it be part of a
> portal like you have for iSERt?

Wouldn't that be overkill to have one listen port per RDMA port? I think
it will be easier for users if they have to configure the RDMA/CM port once
instead of one time per RDMA port. How about using the following location in
configfs for the RDMA/CM port:

/sys/kernel/config/target/srpt/discovery_auth/rdma_cm_port

Thanks,

Bart.N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dʇڙë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš