All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Ross Burton <ross.burton@intel.com>, yocto@yoctoproject.org
Subject: Re: [PATCH][meta-mingw] gcc-crosssdk: use oe.utils.str_filter_out
Date: Tue, 30 Jan 2018 11:46:19 +0000	[thread overview]
Message-ID: <1517312779.3090.32.camel@linuxfoundation.org> (raw)
In-Reply-To: <20180130112531.11781-1-ross.burton@intel.com>

On Tue, 2018-01-30 at 11:25 +0000, Ross Burton wrote:
> oe_filter_out has been removed from oe-core so use the replacement
> function.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  recipes-devtools/gcc/gcc-crosssdk_%.bbappend | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-devtools/gcc/gcc-crosssdk_%.bbappend b/recipes-
> devtools/gcc/gcc-crosssdk_%.bbappend
> index b3b843a..d52a16b 100644
> --- a/recipes-devtools/gcc/gcc-crosssdk_%.bbappend
> +++ b/recipes-devtools/gcc/gcc-crosssdk_%.bbappend
> @@ -1,4 +1,4 @@
> -EXTRA_OECONF_mingw32 := "${@oe_filter_out('--with-linker-hash-
> style=${LINKER_HASH_STYLE}', '${EXTRA_OECONF}', d)}"
> +EXTRA_OECONF_mingw32 := "${@oe.utils.str_filter_out('--with-linker-
> hash-style=${LINKER_HASH_STYLE}', '${EXTRA_OECONF}', d)}"

Why aren't we using 
EXTRA_OECONF_remove_mingw32 = "--with-linker-hash-style=${LINKER_HASH_STYLE}"
out of interest?

I thought (hoped) the filter-out stuff was dead now?

Cheers,

Richard




  reply	other threads:[~2018-01-30 11:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 11:25 [PATCH][meta-mingw] gcc-crosssdk: use oe.utils.str_filter_out Ross Burton
2018-01-30 11:46 ` Richard Purdie [this message]
2018-01-30 12:04   ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517312779.3090.32.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=ross.burton@intel.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.