Re: [PATCH] waf.bbclass: check that waf exists before trying to execute it

[Joshua Watt <jpewhacker@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 3911 bytes --]

On Tue, 2018-01-30 at 13:26 +0100, Martin Jansa wrote:
> +Andreas who added waf inherit in jack in:commit
> 0f8f1973e229a0799098bc2334416fec8c608b50
> Author: Andreas Müller <schnitzeltony@googlemail.com>
> Date:   Sat Oct 8 12:03:32 2016 +0200
> 
>     jack: swap to jack2
> 
> +Bian who added waf samba in:
> commit 962e346df99696a10657a2ea7b2166dfaf290289
> Author: Bian Naimeng <biannm@cn.fujitsu.com>
> Date:   Tue Jun 16 14:18:25 2015 +0900
> 
>     waf-samba: add new class
>     
>     waf-samba is a build system used by samba related software
waf-samba looks very special purpose and not how I would expect a
normal waf workflow to work at all.... maybe it shouldn't inherit from
waf.bbclass, especially since all it is actually using is
get_waf_parallel_make() ?
> +Joe and Joe and who maintains samba and related recipes + meta-
> networking
> 
> 
> On Tue, Jan 30, 2018 at 1:03 PM, Burton, Ross <ross.burton@intel.com>
> wrote:
> > Why would they do that?  Shouldn't it be a fatal bug if waf isn't
> > found?
> > On 30 January 2018 at 08:30, Martin Jansa <martin.jansa@gmail.com>
> > wrote:
> > > * there are some recipes like jack and other which inherit waf-
> > > samba
> > > 
> > > which inherits waf, but they don't use waf for configure, strange
> > > isn't
> > > 
> > > it?
> > > 
> > > 
> > > 
> > > * fixes:
> > > 
> > > WARNING: libldb-1.1.29-r0 do_configure: Unable to execute waf --
> > > version, exit code 127. Assuming waf version without
> > > bindir/libdir support.
> > > 
> > > WARNING: samba-4.6.7-r0 do_configure: Unable to execute waf --
> > > version, exit code 127. Assuming waf version without
> > > bindir/libdir support.
> > > 
> > > WARNING: libtalloc-2.1.9-r0 do_configure: Unable to execute waf
> > > --version, exit code 127. Assuming waf version without
> > > bindir/libdir
> > > 
> > > support.
> > > 
> > > WARNING: jack-1.9.10+gitAUTOINC+2d1d323505-r0 do_configure:
> > > Unable to execute waf --version, exit code 1. Assuming waf
> > > version without bindir/libdir support.
> > > 
> > > WARNING: libtevent-0.9.31-r0 do_configure: Unable to execute waf
> > > --version, exit code 127. Assuming waf version without
> > > bindir/libdir support.
> > > 
> > > WARNING: libtdb-1.3.14-r0 do_configure: Unable to execute waf --
> > > version, exit code 127. Assuming waf version without
> > > bindir/libdir support.
> > > 
> > > 
> > > 
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > 
> > > ---
> > > 
> > >  meta/classes/waf.bbclass | 3 +++
> > > 
> > >  1 file changed, 3 insertions(+)
> > > 
> > > 
> > > 
> > > diff --git a/meta/classes/waf.bbclass b/meta/classes/waf.bbclass
> > > 
> > > index c3e744e5de..eec4d9496d 100644
> > > 
> > > --- a/meta/classes/waf.bbclass
> > > 
> > > +++ b/meta/classes/waf.bbclass
> > > 
> > > @@ -29,6 +29,9 @@ python waf_preconfigure() {
> > > 
> > >      from distutils.version import StrictVersion
> > > 
> > >      srcsubdir = d.getVar('S')
> > > 
> > >      wafbin = os.path.join(srcsubdir, 'waf')
> > > 
> > > +    if not os.path.isfile(wafbin):
> > > 
> > > +        bb.note("%s doesn't exist, cannot check whether it
> > > supports --bindir/--libdir" % wafbin)
> > > 
> > > +        return
> > > 
> > >      status, result = oe.utils.getstatusoutput(wafbin + " --
> > > version")
> > > 
> > >      if status != 0:
> > > 
> > >          bb.warn("Unable to execute waf --version, exit code %d.
> > > Assuming waf version without bindir/libdir support." % status)
> > > 
> > > 
> > > --
> > > 
> > > 2.15.1
> > > 
> > > 
> > > 
> > > --
> > > 
> > > _______________________________________________
> > > 
> > > Openembedded-core mailing list
> > > 
> > > Openembedded-core@lists.openembedded.org
> > > 
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > > 

[-- Attachment #2: Type: text/html, Size: 5248 bytes --]