From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH v2 2/5] drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD Date: Tue, 30 Jan 2018 17:45:45 -0500 Message-ID: <1517352345.4938.1.camel@redhat.com> References: <20180117192149.17760-1-ville.syrjala@linux.intel.com> <20180117192149.17760-2-ville.syrjala@linux.intel.com> Reply-To: lyude@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id E657A6EAC7 for ; Tue, 30 Jan 2018 22:45:47 +0000 (UTC) Received: by mail-qt0-f193.google.com with SMTP id f4so19438372qtj.6 for ; Tue, 30 Jan 2018 14:45:47 -0800 (PST) In-Reply-To: <20180117192149.17760-2-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTAxLTE3IGF0IDIxOjIxICswMjAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+ IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g Cj4gVGhlIExHIDRrIFRWIEkgaGF2ZSBkb2Vzbid0IGRlYXNzZXJ0IEhQRCB3aGVuIEkgdHVybiB0 aGUgVFYgb2ZmLCBidXQKPiB3aGVuIEkgdHVybiBpdCBiYWNrIG9uIGl0IHdpbGwgcHVsc2UgdGhl IEhQRCBsaW5lLiBCeSB0aGF0IHRpbWUgaXQgaGFzCj4gZm9yZ290dGVuIGV2ZXJ5dGhpbmcgd2Ug dG9sZCBpdCBhYm91dCBzY3JhbWJsaW5nIGFuZCB0aGUgY2xvY2sgcmF0aW8uCj4gSGVuY2UgaWYg d2Ugd2FudCB0byBnZXQgYSBwaWN0dXJlIG91dCBpZiBpdCBhZ2FpbiB3ZSBoYXZlIHRvIHRlbGwg aXQKPiB3aGV0aGVyIHdlJ3JlIGN1cnJlbnRseSBzZW5kaW5nIHNjcmFtYmxlZCBkYXRhIG9yIG5v dC4gSW1wbGVtZW50Cj4gdGhhdCB2aWEgdGhlIGVuY29kZXItPmhvdHBsdWcoKSBob29rLgo+IAo+ IHYyOiBGb3JjZSBhIGZ1bGwgbW9kZXNldCB0byBub3QgZm9sbG93IHRoZSBIRE1JIDIuMCBzcGVj IG1vcmUKPiAgICAgY2xvc2VseSAoU2hhc2hhbmspCj4gCj4gQ2M6IFNoYXNoYW5rIFNoYXJtYSA8 c2hhc2hhbmsuc2hhcm1hQGludGVsLmNvbT4KPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0 ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJq w6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYyB8IDE0Ngo+ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTQ1IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRp LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXggMWFlYWUzZTk3 MDEzLi4yNTc5M2JkYzY5MmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IEBAIC0y NSw2ICsyNSw3IEBACj4gICAqCj4gICAqLwo+ICAKPiArI2luY2x1ZGUgPGRybS9kcm1fc2NkY19o ZWxwZXIuaD4KPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gICNpbmNsdWRlICJpbnRlbF9kcnYu aCIKPiAgCj4gQEAgLTI3NTYsNiArMjc1NywxNDYgQEAgaW50ZWxfZGRpX2luaXRfZHBfY29ubmVj dG9yKHN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQKPiAqaW50ZWxfZGlnX3BvcnQpCj4gIAlyZXR1 cm4gY29ubmVjdG9yOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IG1vZGVzZXRfcGlwZShzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsCj4gKwkJCXN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqY3R4 KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gKwlzdHJ1Y3QgZHJt X2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXN0YXRlID0gZHJt X2F0b21pY19zdGF0ZV9hbGxvYyhjcnRjLT5kZXYpOwo+ICsJaWYgKCFzdGF0ZSkKPiArCQlyZXR1 cm4gLUVOT01FTTsKPiArCj4gKwlzdGF0ZS0+YWNxdWlyZV9jdHggPSBjdHg7Cj4gKwo+ICsJY3J0 Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ICsJaWYg KElTX0VSUihjcnRjX3N0YXRlKSkgewo+ICsJCXJldCA9IFBUUl9FUlIoY3J0Y19zdGF0ZSk7Cj4g KwkJZ290byBvdXQ7Cj4gKwl9Cj4gKwo+ICsJY3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1 ZTsKPiArCj4gKwlyZXQgPSBkcm1fYXRvbWljX2FkZF9hZmZlY3RlZF9jb25uZWN0b3JzKHN0YXRl LCBjcnRjKTsKPiArCWlmIChyZXQpCj4gKwkJZ290byBvdXQ7Cj4gKwo+ICsJcmV0ID0gZHJtX2F0 b21pY19hZGRfYWZmZWN0ZWRfcGxhbmVzKHN0YXRlLCBjcnRjKTsKPiArCWlmIChyZXQpCj4gKwkJ Z290byBvdXQ7Cj4gKwo+ICsJcmV0ID0gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+ICsJaWYg KHJldCkKPiArCQlnb3RvIG91dDsKPiArCj4gKwlyZXR1cm4gMDsKPiArCj4gKyBvdXQ6Cj4gKwlk cm1fYXRvbWljX3N0YXRlX3B1dChzdGF0ZSk7Cj4gKwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsK PiArc3RhdGljIGludCBpbnRlbF9oZG1pX3Jlc2V0X2xpbmsoc3RydWN0IGludGVsX2VuY29kZXIg KmVuY29kZXIsCj4gKwkJCQkgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4ICpjdHgpCj4g K3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rl ci0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVsX2hkbWkgKmhkbWkgPSBlbmNfdG9faW50ZWxf aGRtaSgmZW5jb2Rlci0+YmFzZSk7Cj4gKwlzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpjb25uZWN0 b3IgPSBoZG1pLT5hdHRhY2hlZF9jb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmFk YXB0ZXIgPQo+ICsJCWludGVsX2dtYnVzX2dldF9hZGFwdGVyKGRldl9wcml2LCBoZG1pLT5kZGNf YnVzKTsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uX3N0YXRlOwo+ICsJc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YzsKPiArCXU4IGNvbmZpZzsKPiArCWludCByZXQ7Cj4gKwo+ICsJaWYgKCFjb25uZWN0b3Ig fHwgY29ubmVjdG9yLT5iYXNlLnN0YXR1cyAhPQo+IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVk KQo+ICsJCXJldHVybiAwOwo+ICsKPiArCXJldCA9IGRybV9tb2Rlc2V0X2xvY2soJmRldl9wcml2 LT5kcm0ubW9kZV9jb25maWcuY29ubmVjdGlvbl9tdXRleCwKPiBjdHgpOwo+ICsJaWYgKHJldCkK PiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCWNvbm5fc3RhdGUgPSBjb25uZWN0b3ItPmJhc2Uuc3Rh dGU7Cj4gKwo+ICsJY3J0YyA9IHRvX2ludGVsX2NydGMoY29ubl9zdGF0ZS0+Y3J0Yyk7Cj4gKwlp ZiAoIWNydGMpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJcmV0ID0gZHJtX21vZGVzZXRfbG9jaygm Y3J0Yy0+YmFzZS5tdXRleCwgY3R4KTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiAr Cj4gKwljcnRjX3N0YXRlID0gdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5iYXNlLnN0YXRlKTsK PiArCj4gKwlXQVJOX09OKCFpbnRlbF9jcnRjX2hhc190eXBlKGNydGNfc3RhdGUsIElOVEVMX09V VFBVVF9IRE1JKSk7Cj4gKwo+ICsJaWYgKCFjcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkKPiArCQly ZXR1cm4gMDsKPiArCj4gKwlpZiAoIWNydGNfc3RhdGUtPmhkbWlfaGlnaF90bWRzX2Nsb2NrX3Jh dGlvICYmCj4gKwkgICAgIWNydGNfc3RhdGUtPmhkbWlfc2NyYW1ibGluZykKPiArCQlyZXR1cm4g MDsKPiArCj4gKwlpZiAoY29ubl9zdGF0ZS0+Y29tbWl0ICYmCj4gKwkgICAgIXRyeV93YWl0X2Zv cl9jb21wbGV0aW9uKCZjb25uX3N0YXRlLT5jb21taXQtPmh3X2RvbmUpKQo+ICsJCXJldHVybiAw OwpQcm9iYWJseSBzaG91bGQgbWFrZSBhIGhlbHBlciBmdW5jdGlvbiBmb3IgdGhpcyBzaW5jZSB3 ZSB1c2UgdGhpcyBpbiBib3RoIERQIGFuZApIRE1JIGNvZGVwYXRocwoKPiArCj4gKwlyZXQgPSBk cm1fc2NkY19yZWFkYihhZGFwdGVyLCBTQ0RDX1RNRFNfQ09ORklHLCAmY29uZmlnKTsKPiArCWlm IChyZXQgPCAwKSB7Cj4gKwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcmVhZCBUTURTIGNvbmZpZzog JWRcbiIsIHJldCk7Cj4gKwkJcmV0dXJuIDA7Cj4gKwl9Cj4gKwo+ICsJaWYgKCEhKGNvbmZpZyAm IFNDRENfVE1EU19CSVRfQ0xPQ0tfUkFUSU9fQllfNDApID09Cj4gKwkgICAgY3J0Y19zdGF0ZS0+ aGRtaV9oaWdoX3RtZHNfY2xvY2tfcmF0aW8gJiYKPiArCSAgICAhIShjb25maWcgJiBTQ0RDX1ND UkFNQkxJTkdfRU5BQkxFKSA9PQo+ICsJICAgIGNydGNfc3RhdGUtPmhkbWlfc2NyYW1ibGluZykK PiArCQlyZXR1cm4gMDsKPiArCj4gKwkvKgo+ICsJICogSERNSSAyLjAgc2F5cyB0aGF0IG9uZSBz aG91bGQgbm90IHNlbmQgc2NyYW1ibGVkIGRhdGEKPiArCSAqIHByaW9yIHRvIGNvbmZpZ3VyaW5n IHRoZSBzaW5rIHNjcmFtYmxpbmcsIGFuZCB0aGF0Cj4gKwkgKiBUTURTIGNsb2NrL2RhdGEgdHJh bnNtaXNzaW9uIHNob3VsZCBiZSBzdXNwZW5kZWQgd2hlbgo+ICsJICogY2hhbmdpbmcgdGhlIFRN RFMgY2xvY2sgcmF0ZSBpbiB0aGUgc2luay4gU28gbGV0J3MKPiArCSAqIGp1c3QgZG8gYSBmdWxs IG1vZGVzZXQgaGVyZSwgZXZlbiB0aG91Z2ggc29tZSBzaW5rcwo+ICsJICogd291bGQgYmUgcGVy ZmVjdGx5IGhhcHB5IGlmIHdlcmUgdG8ganVzdCByZWNvbmZpZ3VyZQo+ICsJICogdGhlIFNDREMg c2V0dGluZ3Mgb24gdGhlIGZseS4KPiArCSAqLwo+ICsJcmV0dXJuIG1vZGVzZXRfcGlwZSgmY3J0 Yy0+YmFzZSwgY3R4KTsKPiArfQo+ICsKPiArc3RhdGljIGJvb2wgaW50ZWxfZGRpX2hvdHBsdWco c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gKwkJCSAgICAgIHN0cnVjdCBpbnRlbF9j b25uZWN0b3IgKmNvbm5lY3RvcikKPiArewo+ICsJc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVf Y3R4IGN0eDsKPiArCWJvb2wgY2hhbmdlZDsKPiArCWludCByZXQ7Cj4gKwo+ICsJY2hhbmdlZCA9 IGludGVsX2VuY29kZXJfaG90cGx1ZyhlbmNvZGVyLCBjb25uZWN0b3IpOwo+ICsKPiArCWRybV9t b2Rlc2V0X2FjcXVpcmVfaW5pdCgmY3R4LCAwKTsKPiArCj4gKwlmb3IgKDs7KSB7Cj4gKwkJcmV0 ID0gaW50ZWxfaGRtaV9yZXNldF9saW5rKGVuY29kZXIsICZjdHgpOwo+ICsKPiArCQlpZiAocmV0 ID09IC1FREVBRExLKSB7Cj4gKwkJCWRybV9tb2Rlc2V0X2JhY2tvZmYoJmN0eCk7Cj4gKwkJCWNv bnRpbnVlOwo+ICsJCX0KPiArCj4gKwkJYnJlYWs7Cj4gKwl9Cj4gKwo+ICsJZHJtX21vZGVzZXRf ZHJvcF9sb2NrcygmY3R4KTsKPiArCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiAr CVdBUk4ocmV0LCAiQWNxdWlyaW5nIG1vZGVzZXQgbG9ja3MgZmFpbGVkIHdpdGggJWlcbiIsIHJl dCk7Cj4gKwo+ICsJcmV0dXJuIGNoYW5nZWQ7Cj4gK30KPiArCj4gIHN0YXRpYyBzdHJ1Y3QgaW50 ZWxfY29ubmVjdG9yICoKPiAgaW50ZWxfZGRpX2luaXRfaGRtaV9jb25uZWN0b3Ioc3RydWN0IGlu dGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQpCj4gIHsKPiBAQCAtMjg2Niw3ICszMDA3 LDEwIEBAIHZvaWQgaW50ZWxfZGRpX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+IGVudW0gcG9ydCBwb3J0KQo+ICAJZHJtX2VuY29kZXJfaW5pdCgmZGV2X3ByaXYtPmRy bSwgZW5jb2RlciwgJmludGVsX2RkaV9mdW5jcywKPiAgCQkJIERSTV9NT0RFX0VOQ09ERVJfVE1E UywgIkRESSAlYyIsIHBvcnRfbmFtZShwb3J0KSk7Cj4gIAo+IC0JaW50ZWxfZW5jb2Rlci0+aG90 cGx1ZyA9IGludGVsX2VuY29kZXJfaG90cGx1ZzsKPiArCWlmIChpbml0X2hkbWkpCj4gKwkJaW50 ZWxfZW5jb2Rlci0+aG90cGx1ZyA9IGludGVsX2RkaV9ob3RwbHVnOwo+ICsJZWxzZQo+ICsJCWlu dGVsX2VuY29kZXItPmhvdHBsdWcgPSBpbnRlbF9lbmNvZGVyX2hvdHBsdWc7Cj4gIAlpbnRlbF9l bmNvZGVyLT5jb21wdXRlX291dHB1dF90eXBlID0gaW50ZWxfZGRpX2NvbXB1dGVfb3V0cHV0X3R5 cGU7Cj4gIAlpbnRlbF9lbmNvZGVyLT5jb21wdXRlX2NvbmZpZyA9IGludGVsX2RkaV9jb21wdXRl X2NvbmZpZzsKPiAgCWludGVsX2VuY29kZXItPmVuYWJsZSA9IGludGVsX2VuYWJsZV9kZGk7Cl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=