From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>, davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com
Subject: Re: [net-next 2/7] fm10k: cleanup unnecessary parenthesis in fm10k_iov.c
Date: Wed, 31 Jan 2018 03:34:53 -0800 [thread overview]
Message-ID: <1517398493.765.55.camel@perches.com> (raw)
In-Reply-To: <20180124224546.21185-3-jeffrey.t.kirsher@intel.com>
On Wed, 2018-01-24 at 14:45 -0800, Jeff Kirsher wrote:
> This fixes a few warnings found by checkpatch.pl --strict
[]
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c
[]
> @@ -353,7 +353,7 @@ int fm10k_iov_resume(struct pci_dev *pdev)
> struct fm10k_vf_info *vf_info = &iov_data->vf_info[i];
>
> /* allocate all but the last GLORT to the VFs */
> - if (i == ((~hw->mac.dglort_map) >> FM10K_DGLORTMAP_MASK_SHIFT))
> + if (i == (~hw->mac.dglort_map >> FM10K_DGLORTMAP_MASK_SHIFT))
Strictly, only the if needs parentheses here, but I
think it reads better before this change.
> @@ -511,7 +511,7 @@ int fm10k_iov_configure(struct pci_dev *pdev, int num_vfs)
> return err;
>
> /* allocate VFs if not already allocated */
> - if (num_vfs && (num_vfs != current_vfs)) {
> + if (num_vfs && num_vfs != current_vfs) {
next prev parent reply other threads:[~2018-01-31 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 22:45 [net-next 0/7][pull request] 100GbE Intel Wired LAN Driver Updates 2018-01-24 Jeff Kirsher
2018-01-24 22:45 ` [net-next 1/7] fm10k: Fix configuration for macvlan offload Jeff Kirsher
2018-01-24 22:45 ` [net-next 2/7] fm10k: cleanup unnecessary parenthesis in fm10k_iov.c Jeff Kirsher
2018-01-31 11:34 ` Joe Perches [this message]
2018-01-31 22:40 ` Keller, Jacob E
2018-01-24 22:45 ` [net-next 3/7] fm10k: fix "failed to kill vid" message for VF Jeff Kirsher
2018-01-24 22:45 ` [net-next 4/7] fm10k: stop adding VLAN 0 to the VLAN table Jeff Kirsher
2018-01-24 22:45 ` [net-next 5/7] fm10k: don't assume VLAN 1 is enabled Jeff Kirsher
2018-01-24 22:45 ` [net-next 6/7] fm10k: correct typo in fm10k_pf.c Jeff Kirsher
2018-01-24 22:45 ` [net-next 7/7] fm10k: clarify action when updating the VLAN table Jeff Kirsher
2018-01-24 23:02 ` [net-next 0/7][pull request] 100GbE Intel Wired LAN Driver Updates 2018-01-24 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517398493.765.55.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.