From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/4] ACPI / bus: Remove checks in acpi_get_match_data() From: Andy Shevchenko Message-Id: <1517487893.7000.1372.camel@linux.intel.com> Date: Thu, 01 Feb 2018 14:24:53 +0200 To: "Rafael J. Wysocki" , Sinan Kaya Cc: dmaengine , "Rafael J. Wysocki" , ACPI Devel Maling List , Sakari Ailus , Vinod Koul List-ID: T24gVGh1LCAyMDE4LTAyLTAxIGF0IDA4OjI3ICswMTAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToKPiBPbiBXZWQsIEphbiAzMSwgMjAxOCBhdCAxMToxNyBQTSwgU2luYW4gS2F5YSA8b2theWFA Y29kZWF1cm9yYS5vcmc+Cj4gd3JvdGU6Cj4gPiBPbiAxLzMxLzIwMTggNDoyOSBQTSwgQW5keSBT aGV2Y2hlbmtvIHdyb3RlOgo+ID4gPiBBcyB3ZWxsIGFzIGl0cyBzaWJsaW5nIG9mX2RldmljZV9n ZXRfbWF0Y2hfZGF0YSgpIGhhcyBubyBzdWNoCj4gPiA+IGNoZWNrcywKPiA+ID4gbm8gbmVlZCB0 byBkbyBpdCBpbiBhY3BpX2dldF9tYXRjaF9kYXRhKCkuCj4gPiA+IAo+ID4gPiBGaXJzdCBvZiBh bGwsIHdlIGFyZSBub3Qgc3VwcG9zZWQgdG8gY2FsbCBmd25vZGUgQVBJIGxpa2UgdGhpcwo+ID4g PiB3aXRob3V0Cj4gPiA+IGRyaXZlciBhdHRhY2hlZC4KPiA+ID4gCj4gPiA+IFNlY29uZCwgaWYg cHVyZSBPRiBkcml2ZXIgY2FsbHMgdGhpcyBmdW5jdGlvbiwgaXQncyB3ZWlyZCB0byBoYXZlCj4g PiA+IEFDUEkKPiA+ID4gY29tcGFuaW9uIHdpdGhvdXQgQUNQSSBJRCBpbiB0aGlzIGNhc2UuCj4g PiAKPiA+IFdlIHRhbGtlZCBhYm91dCB0aGlzIGR1cmluZyByZXZpZXcuCj4gPiAKPiA+IG9mX21h dGNoX2RldmljZSgpIGRvZXMgYWxsIHRoZSBjaGVja2luZyBmb3IgdGhlIE9GIHBhcnQuIEFDUEkK PiA+IGRvZXNuJ3QgaGF2ZQo+ID4gYW55IGNoZWNrcy4KPiAKPiBZZWFoLCB0aGlzIHBhdGNoIGlz IGp1c3QgcGxhaW4gaW5jb3JyZWN0IEFGQUlDUy4KCkkgZG9uJ3Qgc2VlIGhvdyBjaGVjayBkZXYt PmRyaXZlciBpcyBpbXBsZW1lbnRlZCBvbiBPRiBzaWRlIHRoZW4KCgpvZl9kZXZpY2VfZ2V0X21h dGNoX2RhdGEoKSB3aGljaCBpcyBjYWxsZWQgYnkKb2ZfZndub2RlX2RldmljZV9nZXRfbWF0Y2hf ZGF0YSgpIGhhcyBkZXJlZmVyZW5jZWQgZGV2LT5kcml2ZXIgdy9vIGFueQpjaGVjay4KCkkgY2Fu J3QgYWdyZWUgdGhhdCB0aGUgcGF0Y2ggaXMgcGxhaW4gaW5jb3JyZWN0LCBpZiBJIGRpZG4ndCBt aXNzCmFueXRoaW5nLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 1/4] ACPI / bus: Remove checks in acpi_get_match_data() Date: Thu, 01 Feb 2018 14:24:53 +0200 Message-ID: <1517487893.7000.1372.camel@linux.intel.com> References: <20180131212959.68766-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com ([192.55.52.115]:54619 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038AbeBAMY4 (ORCPT ); Thu, 1 Feb 2018 07:24:56 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" , Sinan Kaya Cc: dmaengine , "Rafael J. Wysocki" , ACPI Devel Maling List , Sakari Ailus , Vinod Koul On Thu, 2018-02-01 at 08:27 +0100, Rafael J. Wysocki wrote: > On Wed, Jan 31, 2018 at 11:17 PM, Sinan Kaya > wrote: > > On 1/31/2018 4:29 PM, Andy Shevchenko wrote: > > > As well as its sibling of_device_get_match_data() has no such > > > checks, > > > no need to do it in acpi_get_match_data(). > > > > > > First of all, we are not supposed to call fwnode API like this > > > without > > > driver attached. > > > > > > Second, if pure OF driver calls this function, it's weird to have > > > ACPI > > > companion without ACPI ID in this case. > > > > We talked about this during review. > > > > of_match_device() does all the checking for the OF part. ACPI > > doesn't have > > any checks. > > Yeah, this patch is just plain incorrect AFAICS. I don't see how check dev->driver is implemented on OF side then of_device_get_match_data() which is called by of_fwnode_device_get_match_data() has dereferenced dev->driver w/o any check. I can't agree that the patch is plain incorrect, if I didn't miss anything. -- Andy Shevchenko Intel Finland Oy