From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Nathan Rossi <nathan@nathanrossi.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] fetch2: Handle missing donestamp file when content is valid
Date: Thu, 01 Feb 2018 13:12:38 +0000 [thread overview]
Message-ID: <1517490758.3090.44.camel@linuxfoundation.org> (raw)
In-Reply-To: <20180131150728.20962-1-nathan@nathanrossi.com>
On Thu, 2018-02-01 at 01:07 +1000, Nathan Rossi wrote:
> In order to allow users to manually populate the download directory
> with
> valid content change the assumption that missing the donestamp file
> means unfetched content.
>
> This allows users to populate the download dir without needing to
> create
> dummy .done files such that a user does not need a PREMIRROR when
> using
> BB_NO_NETWORK to provide valid content files in the download
> directory.
>
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> lib/bb/fetch2/__init__.py | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
Could I persuade you into adding a test of this in
lib/bb/tests/fetch.py?
The advantage is that then we hopefully don't break this again!
Cheers,
Richard
next prev parent reply other threads:[~2018-02-01 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 15:07 [PATCH] fetch2: Handle missing donestamp file when content is valid Nathan Rossi
2018-02-01 13:12 ` Richard Purdie [this message]
2018-02-01 13:29 ` Nathan Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517490758.3090.44.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=nathan@nathanrossi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.