From: Jeff Layton <jlayton@redhat.com>
To: gregkh@linuxfoundation.org, alexander.levin@verizon.com, jack@suse.cz
Cc: stable@vger.kernel.org, stable-commits@vger.kernel.org
Subject: Re: Patch "reiserfs: remove unneeded i_version bump" has been added to the 4.14-stable tree
Date: Thu, 01 Feb 2018 08:18:43 -0500 [thread overview]
Message-ID: <1517491123.3543.7.camel@redhat.com> (raw)
In-Reply-To: <1517490833577@kroah.com>
On Thu, 2018-02-01 at 14:13 +0100, gregkh@linuxfoundation.org wrote:
> This is a note to let you know that I've just added the patch titled
>
> reiserfs: remove unneeded i_version bump
>
> to the 4.14-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> reiserfs-remove-unneeded-i_version-bump.patch
> and it can be found in the queue-4.14 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
>
>
> From foo@baz Thu Feb 1 13:45:42 CET 2018
> From: Jeff Layton <jlayton@redhat.com>
> Date: Mon, 30 Oct 2017 11:20:15 -0400
> Subject: reiserfs: remove unneeded i_version bump
>
> From: Jeff Layton <jlayton@redhat.com>
>
>
> [ Upstream commit 9f97df50c52c2887432debb6238f4e43567386a5 ]
>
> The i_version field in reiserfs is not initialized and is only ever
> updated here. Nothing ever views it, so just remove it.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> fs/reiserfs/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -2591,7 +2591,6 @@ out:
> return err;
> if (inode->i_size < off + len - towrite)
> i_size_write(inode, off + len - towrite);
> - inode->i_version++;
> inode->i_mtime = inode->i_ctime = current_time(inode);
> mark_inode_dirty(inode);
> return len - towrite;
>
>
> Patches currently in stable-queue which might be from jlayton@redhat.com are
>
> queue-4.14/lockd-fix-list_add-double-add-caused-by-legacy-signal-interface.patch
> queue-4.14/reiserfs-remove-unneeded-i_version-bump.patch
Is this needed to ease merging of another patch? I've no real objection
to including this as it should be harmless but it doesn't really fix a
bug per-se. I'm not sure we really need that in stable kernels.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2018-02-01 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 13:13 Patch "reiserfs: remove unneeded i_version bump" has been added to the 4.14-stable tree gregkh
2018-02-01 13:18 ` Jeff Layton [this message]
2018-02-01 13:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517491123.3543.7.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=alexander.levin@verizon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.