From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/6] ACPI / bus: Do not traverse through non-existed device table From: Andy Shevchenko Message-Id: <1517517646.7000.1446.camel@linux.intel.com> Date: Thu, 01 Feb 2018 22:40:46 +0200 To: Sinan Kaya , dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sakari Ailus , Vinod Koul List-ID: T24gVGh1LCAyMDE4LTAyLTAxIGF0IDE1OjMyIC0wNTAwLCBTaW5hbiBLYXlhIHdyb3RlOgo+IE9u IDIvMS8yMDE4IDM6MjAgUE0sIEFuZHkgU2hldmNoZW5rbyB3cm90ZToKPiA+IFdoZW4gX19hY3Bp X21hdGNoX2RldmljZSgpIGlzIGNhbGxlZCBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byBoYXZlCj4g PiBBQ1BJIElEIHRhYmxlIGEgTVVMTCBwb2ludGVyLiBUbyBhdm9pZCBwb3RlbnRpYWwgZGVyZWZl cmVuY2UsCj4gCj4gTlVMTAoKVGhhbmtzLCB3aWxsIGZpeCBsYXRlci4KCj4gV2h5IG5vdCBiYWls IG91dCBoZXJlIGltbWVkaWF0ZWx5IGlmIGlkcyBpcyBudWxsPwoKQmVjYXVzZSBvZiB0aGUgY29k ZSB3aGljaCB3YXNuJ3QgaW4gY29udGV4dCBvZiB0aGlzIHBhdGNoLgoKU2VlIGFsc28gcGF0Y2gg MSBpbiB0aGUgc2VyaWVzLgoKSXQncyBhYm91dCBob3cgYWNwaV9kcml2ZXJfbWF0Y2hfZGV2aWNl KCkgdXNlcyBpdC4K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table Date: Thu, 01 Feb 2018 22:40:46 +0200 Message-ID: <1517517646.7000.1446.camel@linux.intel.com> References: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> <20180201202012.36524-2-andriy.shevchenko@linux.intel.com> <68fea449-6478-3d6d-addf-79925ca62931@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:44064 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754958AbeBAUkt (ORCPT ); Thu, 1 Feb 2018 15:40:49 -0500 In-Reply-To: <68fea449-6478-3d6d-addf-79925ca62931@codeaurora.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Sinan Kaya , dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sakari Ailus , Vinod Koul On Thu, 2018-02-01 at 15:32 -0500, Sinan Kaya wrote: > On 2/1/2018 3:20 PM, Andy Shevchenko wrote: > > When __acpi_match_device() is called it would be possible to have > > ACPI ID table a MULL pointer. To avoid potential dereference, > > NULL Thanks, will fix later. > Why not bail out here immediately if ids is null? Because of the code which wasn't in context of this patch. See also patch 1 in the series. It's about how acpi_driver_match_device() uses it. -- Andy Shevchenko Intel Finland Oy