From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/6] ACPI / bus: Do not traverse through non-existed device table From: Andy Shevchenko Message-Id: <1517517921.7000.1447.camel@linux.intel.com> Date: Thu, 01 Feb 2018 22:45:21 +0200 To: Sinan Kaya , dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sakari Ailus , Vinod Koul List-ID: T24gVGh1LCAyMDE4LTAyLTAxIGF0IDIyOjQwICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 Cj4gT24gVGh1LCAyMDE4LTAyLTAxIGF0IDE1OjMyIC0wNTAwLCBTaW5hbiBLYXlhIHdyb3RlOgo+ ID4gT24gMi8xLzIwMTggMzoyMCBQTSwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgo+ID4gPiBXaGVu IF9fYWNwaV9tYXRjaF9kZXZpY2UoKSBpcyBjYWxsZWQgaXQgd291bGQgYmUgcG9zc2libGUgdG8g aGF2ZQo+ID4gPiBBQ1BJIElEIHRhYmxlIGEgTVVMTCBwb2ludGVyLiBUbyBhdm9pZCBwb3RlbnRp YWwgZGVyZWZlcmVuY2UsCj4gPiAKPiA+IE5VTEwKPiAKPiBUaGFua3MsIHdpbGwgZml4IGxhdGVy Lgo+IAo+ID4gV2h5IG5vdCBiYWlsIG91dCBoZXJlIGltbWVkaWF0ZWx5IGlmIGlkcyBpcyBudWxs Pwo+IAo+IEJlY2F1c2Ugb2YgdGhlIGNvZGUgd2hpY2ggd2Fzbid0IGluIGNvbnRleHQgb2YgdGhp cyBwYXRjaC4KPiAKPiBTZWUgYWxzbyBwYXRjaCAxIGluIHRoZSBzZXJpZXMuCj4gCj4gSXQncyBh Ym91dCBob3cgYWNwaV9kcml2ZXJfbWF0Y2hfZGV2aWNlKCkgdXNlcyBpdC4KCkJ0dywgaXQgbWFr ZXMgZGV2aWNlX2dldF9tYXRjaF9kYXRhKCkgdG8gd29yayBwcm9wZXJseSBvbiBQUlAwMDAxIGtp bmQKb2YgZGV2aWNlcy4K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table Date: Thu, 01 Feb 2018 22:45:21 +0200 Message-ID: <1517517921.7000.1447.camel@linux.intel.com> References: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> <20180201202012.36524-2-andriy.shevchenko@linux.intel.com> <68fea449-6478-3d6d-addf-79925ca62931@codeaurora.org> <1517517646.7000.1446.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com ([134.134.136.20]:63731 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbeBAUpY (ORCPT ); Thu, 1 Feb 2018 15:45:24 -0500 In-Reply-To: <1517517646.7000.1446.camel@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Sinan Kaya , dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sakari Ailus , Vinod Koul On Thu, 2018-02-01 at 22:40 +0200, Andy Shevchenko wrote: > On Thu, 2018-02-01 at 15:32 -0500, Sinan Kaya wrote: > > On 2/1/2018 3:20 PM, Andy Shevchenko wrote: > > > When __acpi_match_device() is called it would be possible to have > > > ACPI ID table a MULL pointer. To avoid potential dereference, > > > > NULL > > Thanks, will fix later. > > > Why not bail out here immediately if ids is null? > > Because of the code which wasn't in context of this patch. > > See also patch 1 in the series. > > It's about how acpi_driver_match_device() uses it. Btw, it makes device_get_match_data() to work properly on PRP0001 kind of devices. -- Andy Shevchenko Intel Finland Oy