From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,3/6] ACPI / bus: Remove checks in acpi_get_match_data() From: Andy Shevchenko Message-Id: <1517517998.7000.1448.camel@linux.intel.com> Date: Thu, 01 Feb 2018 22:46:38 +0200 To: dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sinan Kaya , Sakari Ailus , Vinod Koul List-ID: T24gVGh1LCAyMDE4LTAyLTAxIGF0IDIyOjIwICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 Cj4gQXMgd2VsbCBhcyBpdHMgc2libGluZyBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSBoYXMg bm8gc3VjaCBjaGVja3MsCj4gbm8gbmVlZCB0byBkbyBpdCBpbiBhY3BpX2dldF9tYXRjaF9kYXRh KCkuCj4gCj4gRmlyc3Qgb2YgYWxsLCB3ZSBhcmUgbm90IHN1cHBvc2VkIHRvIGNhbGwgZndub2Rl IEFQSSBsaWtlIHRoaXMgd2l0aG91dAo+IGRyaXZlciBhdHRhY2hlZC4KPiAKPiBTZWNvbmQsIHNp bmNlIF9fYWNwaV9tYXRjaF9kZXZpY2UoKSBkb2VzIGNoZWNrIGlucHV0IHBhcmFtZXRlciB0aGVy ZQo+IGlzCj4gbm8gbmVlZCB0byBkdXBsaWNhdGUgaXQgb3V0c2lkZS4KPiAKPiBGaXhlczogODAy MTJhMTYyMzI5ICgiQUNQSSAvIGJ1czogSW50cm9kdWNlIGFjcGlfZ2V0X21hdGNoX2RhdGEoKQo+ IGZ1bmN0aW9uIikKPiBDYzogU2luYW4gS2F5YSA8b2theWFAY29kZWF1cm9yYS5vcmc+Cj4gQ2M6 IFNha2FyaSBBaWx1cyA8c2FrYXJpLmFpbHVzQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVmlub2Qg S291bCA8dmlub2Qua291bEBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQW5keSBTaGV2Y2hl bmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gdjI6IHJlYmFz ZSBvbiB0b3Agb2YgbmV3IHBhdGNoZXMsIHJlcGhyYXNlIGNvbW1pdCBtZXNzYWdlCj4gIGRyaXZl cnMvYWNwaS9idXMuYyB8IDYgLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2FjcGkvYnVzLmMgYi9kcml2ZXJzL2FjcGkvYnVz LmMKPiBpbmRleCBmM2E3YzI5ZTkxOTAuLjQxM2U0YjFjYjFiZSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2FjcGkvYnVzLmMKPiArKysgYi9kcml2ZXJzL2FjcGkvYnVzLmMKPiBAQCAtNzkxLDEyICs3 OTEsNiBAQCB2b2lkICphY3BpX2dldF9tYXRjaF9kYXRhKGNvbnN0IHN0cnVjdCBkZXZpY2UKPiAq ZGV2KQo+ICB7Cj4gIAljb25zdCBzdHJ1Y3QgYWNwaV9kZXZpY2VfaWQgKm1hdGNoOwo+ICAKPiAt CWlmICghZGV2LT5kcml2ZXIpCj4gLQkJcmV0dXJuIE5VTEw7Cj4gLQoKPiAtCWlmICghZGV2LT5k cml2ZXItPmFjcGlfbWF0Y2hfdGFibGUpCj4gLQkJcmV0dXJuIE5VTEw7Cj4gLQoKUGVyaGFwcyBJ IGhhdmUgdG8gYWRkIHRoYXQgdGhpcyBjb25kaXRpb25hbCBwcmV2ZW50cwpkZXZpY2VfZ2V0X21h dGNoX2RhdGEoKSB0byB3b3JrIG9uIFBSUDAwMDEgZGV2aWNlcyBBRkFJVS4KCj4gIAltYXRjaCA9 IGFjcGlfbWF0Y2hfZGV2aWNlKGRldi0+ZHJpdmVyLT5hY3BpX21hdGNoX3RhYmxlLAo+IGRldik7 Cj4gIAlpZiAoIW1hdGNoKQo+ICAJCXJldHVybiBOVUxMOwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 3/6] ACPI / bus: Remove checks in acpi_get_match_data() Date: Thu, 01 Feb 2018 22:46:38 +0200 Message-ID: <1517517998.7000.1448.camel@linux.intel.com> References: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> <20180201202012.36524-3-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga17.intel.com ([192.55.52.151]:26556 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbeBAUql (ORCPT ); Thu, 1 Feb 2018 15:46:41 -0500 In-Reply-To: <20180201202012.36524-3-andriy.shevchenko@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sinan Kaya , Sakari Ailus , Vinod Koul On Thu, 2018-02-01 at 22:20 +0200, Andy Shevchenko wrote: > As well as its sibling of_device_get_match_data() has no such checks, > no need to do it in acpi_get_match_data(). > > First of all, we are not supposed to call fwnode API like this without > driver attached. > > Second, since __acpi_match_device() does check input parameter there > is > no need to duplicate it outside. > > Fixes: 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data() > function") > Cc: Sinan Kaya > Cc: Sakari Ailus > Cc: Vinod Koul > Signed-off-by: Andy Shevchenko > --- > v2: rebase on top of new patches, rephrase commit message > drivers/acpi/bus.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > index f3a7c29e9190..413e4b1cb1be 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -791,12 +791,6 @@ void *acpi_get_match_data(const struct device > *dev) > { > const struct acpi_device_id *match; > > - if (!dev->driver) > - return NULL; > - > - if (!dev->driver->acpi_match_table) > - return NULL; > - Perhaps I have to add that this conditional prevents device_get_match_data() to work on PRP0001 devices AFAIU. > match = acpi_match_device(dev->driver->acpi_match_table, > dev); > if (!match) > return NULL; -- Andy Shevchenko Intel Finland Oy