From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: lockdep warning in mac80211/tx.c, 4.13.16+ kernel, ath9k related
Date: Thu, 01 Feb 2018 23:23:37 +0100 [thread overview]
Message-ID: <1517523817.28814.10.camel@sipsolutions.net> (raw)
In-Reply-To: <d4632910-7dd9-b066-0c10-b21dd7cbfc61@candelatech.com> (sfid-20180201_015312_997297_FC3C85E1)
On Wed, 2018-01-31 at 16:53 -0800, Ben Greear wrote:
>
> Any idea why this might be complaining?
> 30917 Jan 31 15:21:01 2u-6n kernel: =============================
> 30918 Jan 31 15:21:01 2u-6n kernel: WARNING: suspicious RCU usage
well, that's why? :-)
> 30933 stack backtrace:
> 30934 Jan 31 15:21:01 2u-6n kernel: CPU: 1 PID: 19628 Comm: ip Tainted: G W O 4.13.16+ #2
> 30935 Jan 31 15:21:01 2u-6n kernel: Hardware name: Iron_Systems,Inc CS-CAD-2U-A02/X10SRL-F, BIOS 2.0b 05/02/2017
> 30936 Jan 31 15:21:01 2u-6n kernel: Call Trace:
> 30937 Jan 31 15:21:01 2u-6n kernel: dump_stack+0x85/0xc7
> 30938 Jan 31 15:21:01 2u-6n kernel: lockdep_rcu_suspicious+0xc5/0x100
> 30939 Jan 31 15:21:01 2u-6n kernel: ieee80211_tx_h_select_key+0x1c9/0x4e0 [mac80211]
> 30940 Jan 31 15:21:01 2u-6n kernel: ieee80211_tx_dequeue+0x376/0xca0 [mac80211]
> 30941 Jan 31 15:21:01 2u-6n kernel: ath_tid_dequeue+0x9c/0x110 [ath9k]
> 30942 Jan 31 15:21:01 2u-6n kernel: ath_tx_node_cleanup+0xa4/0x160 [ath9k]
> 30943 Jan 31 15:21:01 2u-6n kernel: ath9k_sta_state+0x6b/0x1e0 [ath9k]
> 30944 Jan 31 15:21:01 2u-6n kernel: drv_sta_state+0xad/0xa80 [mac80211]
I'd argue your hacks are at fault - somewhere in your modifications
around this call stack you lost the necessary rcu_read_lock()
protection.
joahnnes
next prev parent reply other threads:[~2018-02-01 22:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 0:53 lockdep warning in mac80211/tx.c, 4.13.16+ kernel, ath9k related Ben Greear
2018-02-01 22:23 ` Johannes Berg [this message]
2018-02-01 22:33 ` Ben Greear
2018-02-01 22:40 ` Johannes Berg
2018-02-01 22:47 ` Johannes Berg
2018-02-01 23:21 ` Ben Greear
2018-02-02 10:19 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517523817.28814.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.