Re: [PATCH 7/8] bitbake: cooker: fix event notifications

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2018-02-01 at 23:15 +0800, Robert Yang wrote:
> There are two kinds of events:
> * directory
>   We always need handle the event since we don't know what inside the
>   directory, for example:
>   $ bitbake --server-only -T -1
>   $ bitbake -p
>   $ mkdir ${TOPDIR}/classes
>   $ cp /path/to/base.bbclass classes
> 
>   The "${TOPDIR}/classes" is a new directory, the event only reports
> that the
>   directory is created, we don't know there is a base.bbclass unless
> the parser
>   runs.
> 
> * file:
>   Use bb.parse.supports() to check whether bitbake supports it or
> not.
> 
> And now the bbwatchedfiles is not needed anymore.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  bitbake/lib/bb/cooker.py | 34 ++++++++++++++++++----------------
>  1 file changed, 18 insertions(+), 16 deletions(-)

I'm not sure you can do this. For example, bitbake itself doesn't
know/care about *.patch files, however if one is referenced in a
SRC_URI and ends up on the watch list, would this change break a patch
file changing causing task checksums to change?

Its looking like we need better tests for some of this code too :/.

Cheers,

Richard