From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,5/6] dmaengine: hidma: Constify returned by device_get_match_data() value From: Andy Shevchenko Message-Id: <1517753215.7000.1505.camel@linux.intel.com> Date: Sun, 04 Feb 2018 16:06:55 +0200 To: dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sinan Kaya , Sakari Ailus , Vinod Koul List-ID: T24gVGh1LCAyMDE4LTAyLTAxIGF0IDIyOjIwICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 Cj4gVGhlIHZhbHVlIHVuZGVyIHRoZSBob29kIGlzIGNvbnN0YW50IGluIGFueSBjYXNlLgo+IEl0 IG1ha2VzIHNlbnNlIHRvIHNob3cgdGhpcyBleHBsaWNpdGx5Lgo+IAoKVGhpcyBwYXRjaCBpcyB3 cm9uZywgc29ycnkuCgo+IEZpeGVzOiA5NWZiZmI3YWEyOGQgKCJkbWFlbmdpbmU6IHFjb21faGlk bWE6IEFkZCBzdXBwb3J0IGZvciB0aGUgbmV3Cj4gcmV2aXNpb24iKQo+IENjOiBTaW5hbiBLYXlh IDxva2F5YUBjb2RlYXVyb3JhLm9yZz4KPiBDYzogU2FrYXJpIEFpbHVzIDxzYWthcmkuYWlsdXNA bGludXguaW50ZWwuY29tPgo+IENjOiBWaW5vZCBLb3VsIDx2aW5vZC5rb3VsQGludGVsLmNvbT4K PiBTaWduZWQtb2ZmLWJ5OiBBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4 LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9kbWEvcWNvbS9oaWRtYS5jIHwgNCArKy0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZG1hL3Fjb20vaGlkbWEuYyBiL2RyaXZlcnMvZG1hL3Fjb20vaGlk bWEuYwo+IGluZGV4IDk2M2NjNTIyOGQwNS4uMjRlMTYzY2VmYjdjIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZG1hL3Fjb20vaGlkbWEuYwo+ICsrKyBiL2RyaXZlcnMvZG1hL3Fjb20vaGlkbWEuYwo+ IEBAIC03NDMsOSArNzQzLDkgQEAgc3RhdGljIGludCBoaWRtYV9yZXF1ZXN0X21zaShzdHJ1Y3Qg aGlkbWFfZGV2Cj4gKmRtYWRldiwKPiAgCj4gIHN0YXRpYyBib29sIGhpZG1hX3Rlc3RfY2FwYWJp bGl0eShzdHJ1Y3QgZGV2aWNlICpkZXYsIGVudW0gaGlkbWFfY2FwCj4gdGVzdF9jYXApCj4gIHsK PiAtCWVudW0gaGlkbWFfY2FwIGNhcDsKPiArCWNvbnN0IGVudW0gaGlkbWFfY2FwIGNhcDsKPiAg Cj4gLQljYXAgPSAoZW51bSBoaWRtYV9jYXApIGRldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYpOwo+ ICsJY2FwID0gKGNvbnN0IGVudW0gaGlkbWFfY2FwKSBkZXZpY2VfZ2V0X21hdGNoX2RhdGEoZGV2 KTsKPiAgCXJldHVybiBjYXAgPyAoKGNhcCAmIHRlc3RfY2FwKSA+IDApIDogMDsKPiAgfQo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 5/6] dmaengine: hidma: Constify returned by device_get_match_data() value Date: Sun, 04 Feb 2018 16:06:55 +0200 Message-ID: <1517753215.7000.1505.camel@linux.intel.com> References: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> <20180201202012.36524-5-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com ([134.134.136.65]:42786 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbeBDOG6 (ORCPT ); Sun, 4 Feb 2018 09:06:58 -0500 In-Reply-To: <20180201202012.36524-5-andriy.shevchenko@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: dmaengine , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org Cc: Sinan Kaya , Sakari Ailus , Vinod Koul On Thu, 2018-02-01 at 22:20 +0200, Andy Shevchenko wrote: > The value under the hood is constant in any case. > It makes sense to show this explicitly. > This patch is wrong, sorry. > Fixes: 95fbfb7aa28d ("dmaengine: qcom_hidma: Add support for the new > revision") > Cc: Sinan Kaya > Cc: Sakari Ailus > Cc: Vinod Koul > Signed-off-by: Andy Shevchenko > --- > drivers/dma/qcom/hidma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c > index 963cc5228d05..24e163cefb7c 100644 > --- a/drivers/dma/qcom/hidma.c > +++ b/drivers/dma/qcom/hidma.c > @@ -743,9 +743,9 @@ static int hidma_request_msi(struct hidma_dev > *dmadev, > > static bool hidma_test_capability(struct device *dev, enum hidma_cap > test_cap) > { > - enum hidma_cap cap; > + const enum hidma_cap cap; > > - cap = (enum hidma_cap) device_get_match_data(dev); > + cap = (const enum hidma_cap) device_get_match_data(dev); > return cap ? ((cap & test_cap) > 0) : 0; > } > -- Andy Shevchenko Intel Finland Oy