From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/6] ACPI / bus: Do not traverse through non-existed device table From: Andy Shevchenko Message-Id: <1517846207.22495.28.camel@linux.intel.com> Date: Mon, 05 Feb 2018 17:56:47 +0200 To: "Rafael J. Wysocki" Cc: Sinan Kaya , dmaengine , "Rafael J . Wysocki" , ACPI Devel Maling List , Sakari Ailus , Vinod Koul List-ID: T24gU3VuLCAyMDE4LTAyLTA0IGF0IDA4OjE4ICswMTAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToKPiBPbiBUaHUsIEZlYiAxLCAyMDE4IGF0IDk6NDUgUE0sIEFuZHkgU2hldmNoZW5rbwo+IDxh bmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24gVGh1LCAyMDE4 LTAyLTAxIGF0IDIyOjQwICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4gPiA+IE9uIFRo dSwgMjAxOC0wMi0wMSBhdCAxNTozMiAtMDUwMCwgU2luYW4gS2F5YSB3cm90ZToKPiA+ID4gPiBP biAyLzEvMjAxOCAzOjIwIFBNLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4gPiA+ID4gPiBXaGVu IF9fYWNwaV9tYXRjaF9kZXZpY2UoKSBpcyBjYWxsZWQgaXQgd291bGQgYmUgcG9zc2libGUgdG8K PiA+ID4gPiA+IGhhdmUKPiA+ID4gPiA+IEFDUEkgSUQgdGFibGUgYSBNVUxMIHBvaW50ZXIuIFRv IGF2b2lkIHBvdGVudGlhbCBkZXJlZmVyZW5jZSwKPiA+ID4gPiAKPiA+ID4gPiBOVUxMCj4gPiA+ IAo+ID4gPiBUaGFua3MsIHdpbGwgZml4IGxhdGVyLgo+ID4gPiAKPiA+ID4gPiBXaHkgbm90IGJh aWwgb3V0IGhlcmUgaW1tZWRpYXRlbHkgaWYgaWRzIGlzIG51bGw/Cj4gPiA+IAo+ID4gPiBCZWNh dXNlIG9mIHRoZSBjb2RlIHdoaWNoIHdhc24ndCBpbiBjb250ZXh0IG9mIHRoaXMgcGF0Y2guCj4g PiA+IAo+ID4gPiBTZWUgYWxzbyBwYXRjaCAxIGluIHRoZSBzZXJpZXMuCj4gPiA+IAo+ID4gPiBJ dCdzIGFib3V0IGhvdyBhY3BpX2RyaXZlcl9tYXRjaF9kZXZpY2UoKSB1c2VzIGl0Lgo+ID4gCj4g PiBCdHcsIGl0IG1ha2VzIGRldmljZV9nZXRfbWF0Y2hfZGF0YSgpIHRvIHdvcmsgcHJvcGVybHkg b24gUFJQMDAwMQo+ID4ga2luZAo+ID4gb2YgZGV2aWNlcy4KPiAKPiBNYXliZSBjb21iaW5lIHRo aXMgb25lIHdpdGggdGhlIFsxLzZdIHRoZW4sIGl0IHdvdWxkIG1ha2UgaXQgc29tZXdoYXQKPiBl YXNpZXIgdG8gZm9sbG93IHdoYXQncyBnb2luZyBvbi4KClN1cmUsIEkgd2lsbCBmb2xkIGluLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table Date: Mon, 05 Feb 2018 17:56:47 +0200 Message-ID: <1517846207.22495.28.camel@linux.intel.com> References: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> <20180201202012.36524-2-andriy.shevchenko@linux.intel.com> <68fea449-6478-3d6d-addf-79925ca62931@codeaurora.org> <1517517646.7000.1446.camel@linux.intel.com> <1517517921.7000.1447.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:20944 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752767AbeBEP4v (ORCPT ); Mon, 5 Feb 2018 10:56:51 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: Sinan Kaya , dmaengine , "Rafael J . Wysocki" , ACPI Devel Maling List , Sakari Ailus , Vinod Koul On Sun, 2018-02-04 at 08:18 +0100, Rafael J. Wysocki wrote: > On Thu, Feb 1, 2018 at 9:45 PM, Andy Shevchenko > wrote: > > On Thu, 2018-02-01 at 22:40 +0200, Andy Shevchenko wrote: > > > On Thu, 2018-02-01 at 15:32 -0500, Sinan Kaya wrote: > > > > On 2/1/2018 3:20 PM, Andy Shevchenko wrote: > > > > > When __acpi_match_device() is called it would be possible to > > > > > have > > > > > ACPI ID table a MULL pointer. To avoid potential dereference, > > > > > > > > NULL > > > > > > Thanks, will fix later. > > > > > > > Why not bail out here immediately if ids is null? > > > > > > Because of the code which wasn't in context of this patch. > > > > > > See also patch 1 in the series. > > > > > > It's about how acpi_driver_match_device() uses it. > > > > Btw, it makes device_get_match_data() to work properly on PRP0001 > > kind > > of devices. > > Maybe combine this one with the [1/6] then, it would make it somewhat > easier to follow what's going on. Sure, I will fold in. -- Andy Shevchenko Intel Finland Oy