From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,3/6] ACPI / bus: Remove checks in acpi_get_match_data() From: Andy Shevchenko Message-Id: <1517846662.22495.34.camel@linux.intel.com> Date: Mon, 05 Feb 2018 18:04:22 +0200 To: "Rafael J. Wysocki" Cc: dmaengine , "Rafael J . Wysocki" , ACPI Devel Maling List , Sinan Kaya , Sakari Ailus , Vinod Koul List-ID: T24gU3VuLCAyMDE4LTAyLTA0IGF0IDA4OjIxICswMTAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToKPiBPbiBUaHUsIEZlYiAxLCAyMDE4IGF0IDk6NDYgUE0sIEFuZHkgU2hldmNoZW5rbwo+IDxh bmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24gVGh1LCAyMDE4 LTAyLTAxIGF0IDIyOjIwICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6Cj4gPiA+IEFzIHdl bGwgYXMgaXRzIHNpYmxpbmcgb2ZfZGV2aWNlX2dldF9tYXRjaF9kYXRhKCkgaGFzIG5vIHN1Y2gK PiA+ID4gY2hlY2tzLAo+ID4gPiBubyBuZWVkIHRvIGRvIGl0IGluIGFjcGlfZ2V0X21hdGNoX2Rh dGEoKS4KPiA+ID4gCj4gPiA+IEZpcnN0IG9mIGFsbCwgd2UgYXJlIG5vdCBzdXBwb3NlZCB0byBj YWxsIGZ3bm9kZSBBUEkgbGlrZSB0aGlzCj4gPiA+IHdpdGhvdXQKPiA+ID4gZHJpdmVyIGF0dGFj aGVkLgo+ID4gPiAKPiA+ID4gU2Vjb25kLCBzaW5jZSBfX2FjcGlfbWF0Y2hfZGV2aWNlKCkgZG9l cyBjaGVjayBpbnB1dCBwYXJhbWV0ZXIKPiA+ID4gdGhlcmUKPiA+ID4gaXMKPiA+ID4gbm8gbmVl ZCB0byBkdXBsaWNhdGUgaXQgb3V0c2lkZS4KPiA+ID4gCj4gPiA+IEZpeGVzOiA4MDIxMmExNjIz MjkgKCJBQ1BJIC8gYnVzOiBJbnRyb2R1Y2UgYWNwaV9nZXRfbWF0Y2hfZGF0YSgpCj4gPiA+IGZ1 bmN0aW9uIikKPiA+ID4gQ2M6IFNpbmFuIEtheWEgPG9rYXlhQGNvZGVhdXJvcmEub3JnPgo+ID4g PiBDYzogU2FrYXJpIEFpbHVzIDxzYWthcmkuYWlsdXNAbGludXguaW50ZWwuY29tPgo+ID4gPiBD YzogVmlub2QgS291bCA8dmlub2Qua291bEBpbnRlbC5jb20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6 IEFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgo+ID4g PiAKCj4gPiByaGFwcyBJIGhhdmUgdG8gYWRkIHRoYXQgdGhpcyBjb25kaXRpb25hbCBwcmV2ZW50 cwo+ID4gZGV2aWNlX2dldF9tYXRjaF9kYXRhKCkgdG8gd29yayBvbiBQUlAwMDAxIGRldmljZXMg QUZBSVUuCj4gCj4gWWVzLCBwbGVhc2UuCgpPSy4KCj4gSSdtIGFsc28gbm90IHN1cmUgaWYgdGhl IEZpeGVzOiB0YWcgaXMgcmVhbGx5IGFwcGxpY2FibGUgdG8gdGhpcy4KCldlIGNhbiBvZiBjb3Vy c2UgZHJvcCBpdCwgSSBwdXQgaXQgaGVyZSBpbiBhIGhvcGUgdGhhdCB0aGlzIHNlcmllcyB3b3Vs ZApiZSBtYXRlcmlhbCB0byB2NC4xNi1yYzIgdG8gZml4IGFuIGludHJvZHVjZWQgQVBJLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 3/6] ACPI / bus: Remove checks in acpi_get_match_data() Date: Mon, 05 Feb 2018 18:04:22 +0200 Message-ID: <1517846662.22495.34.camel@linux.intel.com> References: <20180201202012.36524-1-andriy.shevchenko@linux.intel.com> <20180201202012.36524-3-andriy.shevchenko@linux.intel.com> <1517517998.7000.1448.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:28096 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752925AbeBEQE0 (ORCPT ); Mon, 5 Feb 2018 11:04:26 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: dmaengine , "Rafael J . Wysocki" , ACPI Devel Maling List , Sinan Kaya , Sakari Ailus , Vinod Koul On Sun, 2018-02-04 at 08:21 +0100, Rafael J. Wysocki wrote: > On Thu, Feb 1, 2018 at 9:46 PM, Andy Shevchenko > wrote: > > On Thu, 2018-02-01 at 22:20 +0200, Andy Shevchenko wrote: > > > As well as its sibling of_device_get_match_data() has no such > > > checks, > > > no need to do it in acpi_get_match_data(). > > > > > > First of all, we are not supposed to call fwnode API like this > > > without > > > driver attached. > > > > > > Second, since __acpi_match_device() does check input parameter > > > there > > > is > > > no need to duplicate it outside. > > > > > > Fixes: 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data() > > > function") > > > Cc: Sinan Kaya > > > Cc: Sakari Ailus > > > Cc: Vinod Koul > > > Signed-off-by: Andy Shevchenko > > > > > rhaps I have to add that this conditional prevents > > device_get_match_data() to work on PRP0001 devices AFAIU. > > Yes, please. OK. > I'm also not sure if the Fixes: tag is really applicable to this. We can of course drop it, I put it here in a hope that this series would be material to v4.16-rc2 to fix an introduced API. -- Andy Shevchenko Intel Finland Oy