From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Tue, 6 Feb 2018 12:25:24 +0000 Subject: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb In-Reply-To: <20180206110810.9093-1-brgl@bgdev.pl> References: <20180206110810.9093-1-brgl@bgdev.pl> List-ID: Message-ID: <1517919923.6726.13.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Bartosz, On Tue, 2018-02-06@12:08 +0100, Bartosz Golaszewski wrote: > Using compatible strings without the part for at24 is > deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently > document the compatible property"). Use a correct 'atmel,' > value. > > Signed-off-by: Bartosz Golaszewski So my further input might be a bit unexpected :) I took a look at the real board and understood that we specified in .dts wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some external device) and instead I2C EEPROM we really have connected (but not yet obviously used in the Linux kernel) is NXP's PCF8594C-2. That said we may accept your change because it doesn't break anything and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes. Or we may drop your change at all since I'm going to replace corresponding nodes. -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb Date: Tue, 6 Feb 2018 12:25:24 +0000 Message-ID: <1517919923.6726.13.camel@synopsys.com> References: <20180206110810.9093-1-brgl@bgdev.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180206110810.9093-1-brgl-ARrdPY/1zhM@public.gmane.org> Content-Language: en-US Content-ID: <0D75A9A8573C4F439A3A1CD77216747A-z7JfP6tgrtVBCHUSTMH8dZqQE7yCjDx5@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "brgl-ARrdPY/1zhM@public.gmane.org" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org SGkgQmFydG9zeiwNCg0KT24gVHVlLCAyMDE4LTAyLTA2IGF0IDEyOjA4ICswMTAwLCBCYXJ0b3N6 IEdvbGFzemV3c2tpIHdyb3RlOg0KPiBVc2luZyBjb21wYXRpYmxlIHN0cmluZ3Mgd2l0aG91dCB0 aGUgPG1hbnVmYWN0dXJlcj4gcGFydCBmb3IgYXQyNCBpcw0KPiBkZXByZWNhdGVkIHNpbmNlIGNv bW1pdCA2ZGEyOGFjZjc0NWYgKCJkdC1iaW5kaW5nczogYXQyNDogY29uc2lzdGVudGx5DQo+IGRv Y3VtZW50IHRoZSBjb21wYXRpYmxlIHByb3BlcnR5IikuIFVzZSBhIGNvcnJlY3QgJ2F0bWVsLDxt b2RlbD4nDQo+IHZhbHVlLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQmFydG9zeiBHb2xhc3pld3Nr aSA8YnJnbEBiZ2Rldi5wbD4NCg0KU28gbXkgZnVydGhlciBpbnB1dCBtaWdodCBiZSBhIGJpdCB1 bmV4cGVjdGVkIDopDQoNCkkgdG9vayBhIGxvb2sgYXQgdGhlIHJlYWwgYm9hcmQgYW5kIHVuZGVy c3Rvb2QgdGhhdCB3ZSBzcGVjaWZpZWQgaW4gLmR0cw0Kd3JvbmcgSUNzLiBUaG9zZSBBdG1lbCBw YXJ0cyBhcmUgbm90IGNvbm5lY3RlZCB0byB0aGUgQ1BVIGF0IGFsbCAodXNlZCBieSBzb21lDQpl eHRlcm5hbCBkZXZpY2UpIGFuZCBpbnN0ZWFkIEkyQyBFRVBST00gd2UgcmVhbGx5IGhhdmUgY29u bmVjdGVkIChidXQgbm90IHlldA0Kb2J2aW91c2x5IHVzZWQgaW4gdGhlIExpbnV4IGtlcm5lbCkg aXMgTlhQJ3MgUENGODU5NEMtMi4NCg0KVGhhdCBzYWlkIHdlIG1heSBhY2NlcHQgeW91ciBjaGFu Z2UgYmVjYXVzZSBpdCBkb2Vzbid0IGJyZWFrIGFueXRoaW5nDQphbmQgdGhlbiBJJ2xsIHNlbmQg YW4gdXBkYXRlIHRvIGF4czEweF9tYi5kdHMgd2l0aCByZXBsYWNlbWVudCBvZiBFRVBST00gbm9k ZXMuDQpPciB3ZSBtYXkgZHJvcCB5b3VyIGNoYW5nZSBhdCBhbGwgc2luY2UgSSdtIGdvaW5nIHRv IHJlcGxhY2UgY29ycmVzcG9uZGluZyBub2Rlcy4NCg0KLUFsZXhleQ== -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbeBFMZn (ORCPT ); Tue, 6 Feb 2018 07:25:43 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:55972 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbeBFMZa (ORCPT ); Tue, 6 Feb 2018 07:25:30 -0500 From: Alexey Brodkin To: "brgl@bgdev.pl" CC: "linux-kernel@vger.kernel.org" , "mark.rutland@arm.com" , "Vineet.Gupta1@synopsys.com" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb Thread-Topic: [PATCH v2] arc: dts: use 'atmel' as manufacturer for at24 in axs10x_mb Thread-Index: AQHTnzrLWIKvJYNdJkiaoqAuzzZm0KOXO+WA Date: Tue, 6 Feb 2018 12:25:24 +0000 Message-ID: <1517919923.6726.13.camel@synopsys.com> References: <20180206110810.9093-1-brgl@bgdev.pl> In-Reply-To: <20180206110810.9093-1-brgl@bgdev.pl> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.100.21.20] Content-Type: text/plain; charset="utf-8" Content-ID: <0D75A9A8573C4F439A3A1CD77216747A@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w16CPnO3017092 Hi Bartosz, On Tue, 2018-02-06 at 12:08 +0100, Bartosz Golaszewski wrote: > Using compatible strings without the part for at24 is > deprecated since commit 6da28acf745f ("dt-bindings: at24: consistently > document the compatible property"). Use a correct 'atmel,' > value. > > Signed-off-by: Bartosz Golaszewski So my further input might be a bit unexpected :) I took a look at the real board and understood that we specified in .dts wrong ICs. Those Atmel parts are not connected to the CPU at all (used by some external device) and instead I2C EEPROM we really have connected (but not yet obviously used in the Linux kernel) is NXP's PCF8594C-2. That said we may accept your change because it doesn't break anything and then I'll send an update to axs10x_mb.dts with replacement of EEPROM nodes. Or we may drop your change at all since I'm going to replace corresponding nodes. -Alexey