From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>,
greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k: break out of irq handler after 5 jiffies
Date: Wed, 07 Feb 2018 11:55:56 +0100 [thread overview]
Message-ID: <1518000956.3124.7.camel@sipsolutions.net> (raw)
In-Reply-To: <2129dcdd-5963-c4da-600e-83f8c394d05c@nbd.name> (sfid-20180207_101620_619144_72639A58)
On Wed, 2018-02-07 at 10:16 +0100, Felix Fietkau wrote:
> On 2018-02-07 00:05, greearb@candelatech.com wrote:
> > From: Ben Greear <greearb@candelatech.com>
> >
> > In case where the system is sluggish, we should probably break out
> > early. Maybe this will fix issues where the OS thinks the IRQ handler
> > is not responding and disables the IRQ because 'nobody cared'
> >
> > Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> 5 jiffies as a hardcoded value is a bad idea, since it produces
> different behavior based on CONFIG_HZ.
Also, err, NAPI? Or is something else is going on here?
johannes
next prev parent reply other threads:[~2018-02-07 10:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 23:05 [PATCH] ath9k: break out of irq handler after 5 jiffies greearb
2018-02-07 9:16 ` Felix Fietkau
2018-02-07 10:55 ` Johannes Berg [this message]
2018-02-07 15:39 ` Ben Greear
2018-02-26 21:39 ` Ben Greear
2018-02-26 22:08 ` Arend van Spriel
2018-02-26 22:40 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518000956.3124.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.