From: Eric Leblond <eric@regit.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: victor@inliniac.net, netdev@vger.kernel.org, yhs@fb.com,
Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [suricata PATCH 0/3] Suricata cleanup makefile
Date: Wed, 07 Feb 2018 23:38:12 +0100 [thread overview]
Message-ID: <1518043092.18958.5.camel@regit.org> (raw)
In-Reply-To: <151804202589.30000.6117096373101222054.stgit@firesoul>
Hello Jesper,
On Wed, 2018-02-07 at 23:21 +0100, Jesper Dangaard Brouer wrote:
> Hi Eric,
>
> I've improved the Suricata ebpf makefile, in-order to avoid
> generating
> the .eh_frame sections. This required changing the code a bit, to
> allow using clang -target bpf.
>
> The makefile have also been improved to stop on clang compile errors,
> instead of generating an almost empty BPF ELF file.
>
> Could I ask you to get these changes into Suricata, through correct
> process for this Open Source project?
Sure, I'm reviewing the code, testing it and I will do a Pull Request
on github.
Thanks a lot for that, that's a really valuable help!
BR,
--
Eric Leblond <eric@regit.org>
prev parent reply other threads:[~2018-02-07 22:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 14:54 [bpf-next V2 PATCH 0/5] tools/libbpf improvements and selftests Jesper Dangaard Brouer
2018-02-06 14:54 ` [bpf-next V2 PATCH 1/5] bpf: Sync kernel ABI header with tooling header for bpf_common.h Jesper Dangaard Brouer
2018-02-06 14:54 ` [bpf-next V2 PATCH 2/5] tools/libbpf: improve the pr_debug statements to contain section numbers Jesper Dangaard Brouer
2018-02-06 14:54 ` [bpf-next V2 PATCH 3/5] selftests/bpf: add test program for loading BPF ELF files Jesper Dangaard Brouer
2018-02-06 14:54 ` [bpf-next V2 PATCH 4/5] selftests/bpf: add selftest that use test_libbpf_open Jesper Dangaard Brouer
2018-02-06 14:54 ` [bpf-next V2 PATCH 5/5] tools/libbpf: handle issues with bpf ELF objects containing .eh_frames Jesper Dangaard Brouer
2018-02-06 16:00 ` Alexei Starovoitov
2018-02-06 17:03 ` Jesper Dangaard Brouer
2018-02-06 19:05 ` Daniel Borkmann
2018-02-07 12:40 ` Jesper Dangaard Brouer
2018-02-07 13:19 ` Daniel Borkmann
2018-02-07 14:58 ` Jesper Dangaard Brouer
2018-02-07 16:18 ` Daniel Borkmann
2018-02-07 22:21 ` [suricata PATCH 0/3] Suricata cleanup makefile Jesper Dangaard Brouer
2018-02-07 22:21 ` [suricata PATCH 1/3] suricata/ebpf: take clang -target bpf include issue of stdint.h into account Jesper Dangaard Brouer
2018-02-07 23:52 ` Eric Leblond
2018-02-08 8:42 ` Jesper Dangaard Brouer
2018-02-07 22:21 ` [suricata PATCH 2/3] suricata/ebpf: compile with clang -target bpf Jesper Dangaard Brouer
2018-02-07 22:21 ` [suricata PATCH 3/3] suricata/ebpf: improving the ebpf makefile Jesper Dangaard Brouer
2018-02-07 22:38 ` Eric Leblond [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518043092.18958.5.camel@regit.org \
--to=eric@regit.org \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=brouer@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=victor@inliniac.net \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.