From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
Felix Fietkau <nbd@nbd.name>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: round IEEE80211_TX_STATUS_HEADROOM up to multiple of 4
Date: Fri, 09 Feb 2018 20:41:32 +0100 [thread overview]
Message-ID: <1518205292.4047.0.camel@sipsolutions.net> (raw)
In-Reply-To: <5A7DF237.9020803@broadcom.com> (sfid-20180209_201049_187355_A2F49113)
On Fri, 2018-02-09 at 20:10 +0100, Arend van Spriel wrote:
>
> > @@ -4149,7 +4149,7 @@ void ieee80211_sta_uapsd_trigger(struct ieee80211_sta *sta, u8 tid);
> > * The TX headroom reserved by mac80211 for its own tx_status functions.
> > * This is enough for the radiotap header.
>
> Hi Felix,
>
> Maybe useful to mention the alignment requirement in this comment block.
>
> > */
> > -#define IEEE80211_TX_STATUS_HEADROOM 14
> > +#define IEEE80211_TX_STATUS_HEADROOM 16
>
Or better yet, just define it as ALIGN(14, 4) ?
johannes
prev parent reply other threads:[~2018-02-09 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 18:51 [PATCH] mac80211: round IEEE80211_TX_STATUS_HEADROOM up to multiple of 4 Felix Fietkau
2018-02-09 19:10 ` Arend van Spriel
2018-02-09 19:41 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518205292.4047.0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.