All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lubomir Rintel <lkundrak@v3.sk>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] drm/edid: drop the dcc probe before drm_do_get_edid
Date: Sun, 11 Feb 2018 11:56:47 +0100	[thread overview]
Message-ID: <1518346607.8520.1.camel@v3.sk> (raw)
In-Reply-To: <20180210180355.2284-1-lkundrak@v3.sk>

On Sat, 2018-02-10 at 19:03 +0100, Lubomir Rintel wrote:
> Now that drm_do_get_edid() handles override and firmware EDIDs it makes
> no sense to conditionalize it with a DCC probe. On the contrary -- the
> overrides are useful specifically when DCC is not functioning.
> 
> drm_do_get_edid() already bails out when DCC fails, there's no need for
> an extra check. It seems entirely safe to just drop this.
> 
> Working around the issue by forcing the connector on is not a good
> solution because that way the desktop shell can't tell when a monitor is
> plugged in or removed.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Fixes: 53fd40a ("drm: handle override and firmware EDID at drm_do_get_edid() level")

Please disregard this, should have given it more thought. Sorry.

It removes a symbol other modules use, and typoes DDC/DCC in the commit
message. Moreover it doesn't actually seem to solve my problem -- will
try to follow up with a better fix.

Lubo

  reply	other threads:[~2018-02-11 10:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10 18:03 [PATCH] drm/edid: drop the dcc probe before drm_do_get_edid Lubomir Rintel
2018-02-11 10:56 ` Lubomir Rintel [this message]
2018-02-12  9:39   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518346607.8520.1.camel@v3.sk \
    --to=lkundrak@v3.sk \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.