diff for duplicates of <1518460085.3725.3.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index 1d61473..9eb6b2d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,59 +1,85 @@ -T24gTW9uLCAyMDE4LTAyLTEyIGF0IDExOjU0IC0wNTAwLCBiZmllbGRzQGZpZWxkc2VzLm9yZyB3 -cm90ZToNCj4gT24gU2F0LCBGZWIgMTAsIDIwMTggYXQgMDE6NDE6NTVBTSArMDAwMCwgVHJvbmQg -TXlrbGVidXN0IHdyb3RlOg0KPiA+IE9uIEZyaSwgMjAxOC0wMi0wOSBhdCAyMzowNiAtMDIwMCwg -VGhpYWdvIFJhZmFlbCBCZWNrZXIgd3JvdGU6DQo+ID4gPiBXaGVuIGludmVzdGlnYXRpbmcgcmVh -c29ucyBmb3IgbmZzIGZhaWx1cmVzLCBwYWNrZXQgZHVtcHMgYXJlaQ0KPiA+ID4gZXZlbnR1YWxs -eSB1c2VkLg0KPiA+ID4gRmluZGluZyB0aGUgcnBjIHRoYXQgZ2VuZXJhdGVkIHRoZSBmYWlsdXJl -IGlzIGRvbmUgYnkgY29tcGFyaW5nDQo+ID4gPiBhbGwNCj4gPiA+IHNlbnQNCj4gPiA+IHJwYyBj -YWxscyBhbmQgYWxsIHJlY2VpdmVkIHJwYyByZXBsaWVzIGZvciB0aG9zZSB3aGljaCBhcmUNCj4g -PiA+IHVuYW5zd2VyZWQsDQo+ID4gPiB3aGljaCBpcyBwcm9uZSB0byBlcnJvcnMgbGlrZQ0KPiA+ -ID4gLSBTbG93IHNlcnZlciByZXNwb25zZXMNCj4gPiA+IC0gSW5jb21wbGV0ZSBhbmQgdW5jYXB0 -dXJlZCBwYWNrZXRzIGluIHRoZSBwYWNrZXQgZHVtcA0KPiA+ID4gLSBUaGUgaGV1cmlzdGljcyB1 -c2VkIHRvIGluc3BlY3QgcGFja2V0cyBmYWlsaW5nIHRvIGludGVycHJldCBvbmUNCj4gPiA+IA0K -PiA+ID4gVGhpcyBwYXRjaCBhZGRzIHRoZSB4aWQgb2YgcnBjX3Rhc2tzIHRvIHRoZSAnbm90IHJl -c3BvbmRpbmcnDQo+ID4gPiBtZXNzYWdlcw0KPiA+ID4gaW4gY2FsbF90aW1lb3V0IHRvIG1ha2Ug -dGhlc2UgYW5hbHlzaXMgbW9yZSBwcmVjaXNlLg0KPiA+ID4gDQo+ID4gPiBTaWduZWQtb2ZmLWJ5 -OiBUaGlhZ28gUmFmYWVsIEJlY2tlciA8dGhpYWdvLmJlY2tlckBnbWFpbC5jb20+DQo+ID4gPiAt -LS0NCj4gPiA+ICBuZXQvc3VucnBjL2NsbnQuYyB8IDEwICsrKysrKy0tLS0NCj4gPiA+ICAxIGZp -bGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQ0KPiA+ID4gDQo+ID4g -PiBkaWZmIC0tZ2l0IGEvbmV0L3N1bnJwYy9jbG50LmMgYi9uZXQvc3VucnBjL2NsbnQuYw0KPiA+ -ID4gaW5kZXggZTJhNDE4NGYzYzVkLi44M2M4YWNhOTUxZjQgMTAwNjQ0DQo+ID4gPiAtLS0gYS9u -ZXQvc3VucnBjL2NsbnQuYw0KPiA+ID4gKysrIGIvbmV0L3N1bnJwYy9jbG50LmMNCj4gPiA+IEBA -IC0yMjE0LDkgKzIyMTQsMTAgQEAgY2FsbF90aW1lb3V0KHN0cnVjdCBycGNfdGFzayAqdGFzaykN -Cj4gPiA+ICAJfQ0KPiA+ID4gIAlpZiAoUlBDX0lTX1NPRlQodGFzaykpIHsNCj4gPiA+ICAJCWlm -IChjbG50LT5jbF9jaGF0dHkpIHsNCj4gPiA+IC0JCQlwcmludGsoS0VSTl9OT1RJQ0UgIiVzOiBz -ZXJ2ZXIgJXMgbm90DQo+ID4gPiByZXNwb25kaW5nLCB0aW1lZCBvdXRcbiIsDQo+ID4gPiArCQkJ -cHJpbnRrKEtFUk5fTk9USUNFICIlczogc2VydmVyICVzIG5vdA0KPiA+ID4gcmVzcG9uZGluZywg -dGltZWQgb3V0ICh4aWQ6ICV4KVxuIiwNCj4gPiA+ICAJCQkJY2xudC0+Y2xfcHJvZ3JhbS0+bmFt -ZSwNCj4gPiA+IC0JCQkJdGFzay0+dGtfeHBydC0+c2VydmVybmFtZSk7DQo+ID4gPiArCQkJCXRh -c2stPnRrX3hwcnQtPnNlcnZlcm5hbWUsDQo+ID4gPiArCQkJCWJlMzJfdG9fY3B1KHRhc2stPnRr -X3Jxc3RwLQ0KPiA+ID4gPiBycV94aWQpKTsNCj4gPiA+IA0KPiA+ID4gIAkJfQ0KPiA+ID4gIAkJ -aWYgKHRhc2stPnRrX2ZsYWdzICYgUlBDX1RBU0tfVElNRU9VVCkNCj4gPiA+ICAJCQlycGNfZXhp -dCh0YXNrLCAtRVRJTUVET1VUKTsNCj4gPiA+IEBAIC0yMjI4LDkgKzIyMjksMTAgQEAgY2FsbF90 -aW1lb3V0KHN0cnVjdCBycGNfdGFzayAqdGFzaykNCj4gPiA+ICAJaWYgKCEodGFzay0+dGtfZmxh -Z3MgJiBSUENfQ0FMTF9NQUpPUlNFRU4pKSB7DQo+ID4gPiAgCQl0YXNrLT50a19mbGFncyB8PSBS -UENfQ0FMTF9NQUpPUlNFRU47DQo+ID4gPiAgCQlpZiAoY2xudC0+Y2xfY2hhdHR5KSB7DQo+ID4g -PiAtCQkJcHJpbnRrKEtFUk5fTk9USUNFICIlczogc2VydmVyICVzIG5vdA0KPiA+ID4gcmVzcG9u -ZGluZywgc3RpbGwgdHJ5aW5nXG4iLA0KPiA+ID4gKwkJCXByaW50ayhLRVJOX05PVElDRSAiJXM6 -IHNlcnZlciAlcyBub3QNCj4gPiA+IHJlc3BvbmRpbmcsIHN0aWxsIHRyeWluZyAoeGlkOiAleClc -biIsDQo+ID4gPiAgCQkJY2xudC0+Y2xfcHJvZ3JhbS0+bmFtZSwNCj4gPiA+IC0JCQl0YXNrLT50 -a194cHJ0LT5zZXJ2ZXJuYW1lKTsNCj4gPiA+ICsJCQl0YXNrLT50a194cHJ0LT5zZXJ2ZXJuYW1l -LA0KPiA+ID4gKwkJCWJlMzJfdG9fY3B1KHRhc2stPnRrX3Jxc3RwLT5ycV94aWQpKTsNCj4gPiA+ -ICAJCX0NCj4gPiA+ICAJfQ0KPiA+ID4gIAlycGNfZm9yY2VfcmViaW5kKGNsbnQpOw0KPiA+IA0K -PiA+IE5BQ0suIFdlIHNob3VsZCBub3QgYmUgbG9nZ2luZyBpbnRlcm5hbCBpbmZvcm1hdGlvbiBz -dWNoIGFzIFhJRHMgYXMNCj4gPiBLRVJOX05PVElDRSBtZXNzYWdlcy4NCj4gDQo+IEkgZGlkbid0 -IG5vdyB0aGF0IHdhcyBhIGdlbmVyYWwgcnVsZS4gIElzIGl0IHRoYXQgS0VSTl9OT1RJQ0UgKGFu -ZA0KPiBoaWdoZXI/KSBtZXNzYWdlcyBhcmUgZXhwZWN0ZWQgdG8gYmUgbGVha2VkIHRvIHVzZXJz -IHdlIGRvbid0IHRydXN0Pw0KPiANCj4gSSBhbHNvIHdvdWxkbid0IGhhdmUgZXhwZWN0ZWQgWElE -cyB0byBiZSB0ZXJyaWJseSB1c2VmdWwgdG8gYW4NCj4gYXR0YWNrZXIuDQo+IEJ1dCBtYXliZSBp -dCBjb3VsZCBoZWxwIGluamVjdCBhIG1hbGljaW91cyByZXBseS4NCj4gDQoNCkFzIEkgc2FpZCwg -dGhlIGluZm9ybWF0aW9uIGlzIGFscmVhZHkgYXZhaWxhYmxlIHRvIHByaXZpbGVnZWQgdXNlcnMu -DQpUaGV5IGNhbiB0dXJuIG9uIGRwcmludGtzLCB0cmFjZXBvaW50cywgb3IgdGhleSBjYW4gbG9v -ayBpbg0KL3N5cy9rZXJuZWwvZGVidWcuIFRoZSBPTkxZIHJlYXNvbiBmb3IgcHV0dGluZyB0aGlz -IGluZm9ybWF0aW9uIGludG8NCnRoZSBhYm92ZSBub3RpY2Ugd291bGQgYmUgdG8gYWxsb3cgdW5w -cml2aWxlZ2VkIHVzZXJzIHRvIGdldCB0aGUgc2FtZQ0KaW5mbyBkaXNwbGF5aW5nIG9uIHRoZWly -IHR0eSBjb25zb2xlcy4NCg0KV2hhdCBhcmUgc2FpZCB1bnByaXZpbGVnZWQgdXNlcnMgZ29pbmcg -dG8gZG8gd2l0aCB0aGlzIGluZm9ybWF0aW9uPw0KV2hhdCBkb2VzIGl0IGFsbG93IHRoZW0gdG8g -ZG8gdGhhdCB0aGV5IGNvdWxkIG5vdCBkbyBiZWZvcmU/DQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0 -DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1 -c3RAcHJpbWFyeWRhdGEuY29tDQo= +On Mon, 2018-02-12 at 11:54 -0500, bfields@fieldses.org wrote: +> On Sat, Feb 10, 2018 at 01:41:55AM +0000, Trond Myklebust wrote: +> > On Fri, 2018-02-09 at 23:06 -0200, Thiago Rafael Becker wrote: +> > > When investigating reasons for nfs failures, packet dumps arei +> > > eventually used. +> > > Finding the rpc that generated the failure is done by comparing +> > > all +> > > sent +> > > rpc calls and all received rpc replies for those which are +> > > unanswered, +> > > which is prone to errors like +> > > - Slow server responses +> > > - Incomplete and uncaptured packets in the packet dump +> > > - The heuristics used to inspect packets failing to interpret one +> > > +> > > This patch adds the xid of rpc_tasks to the 'not responding' +> > > messages +> > > in call_timeout to make these analysis more precise. +> > > +> > > Signed-off-by: Thiago Rafael Becker <thiago.becker@gmail.com> +> > > --- +> > > net/sunrpc/clnt.c | 10 ++++++---- +> > > 1 file changed, 6 insertions(+), 4 deletions(-) +> > > +> > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c +> > > index e2a4184f3c5d..83c8aca951f4 100644 +> > > --- a/net/sunrpc/clnt.c +> > > +++ b/net/sunrpc/clnt.c +> > > @@ -2214,9 +2214,10 @@ call_timeout(struct rpc_task *task) +> > > } +> > > if (RPC_IS_SOFT(task)) { +> > > if (clnt->cl_chatty) { +> > > - printk(KERN_NOTICE "%s: server %s not +> > > responding, timed out\n", +> > > + printk(KERN_NOTICE "%s: server %s not +> > > responding, timed out (xid: %x)\n", +> > > clnt->cl_program->name, +> > > - task->tk_xprt->servername); +> > > + task->tk_xprt->servername, +> > > + be32_to_cpu(task->tk_rqstp- +> > > > rq_xid)); +> > > +> > > } +> > > if (task->tk_flags & RPC_TASK_TIMEOUT) +> > > rpc_exit(task, -ETIMEDOUT); +> > > @@ -2228,9 +2229,10 @@ call_timeout(struct rpc_task *task) +> > > if (!(task->tk_flags & RPC_CALL_MAJORSEEN)) { +> > > task->tk_flags |= RPC_CALL_MAJORSEEN; +> > > if (clnt->cl_chatty) { +> > > - printk(KERN_NOTICE "%s: server %s not +> > > responding, still trying\n", +> > > + printk(KERN_NOTICE "%s: server %s not +> > > responding, still trying (xid: %x)\n", +> > > clnt->cl_program->name, +> > > - task->tk_xprt->servername); +> > > + task->tk_xprt->servername, +> > > + be32_to_cpu(task->tk_rqstp->rq_xid)); +> > > } +> > > } +> > > rpc_force_rebind(clnt); +> > +> > NACK. We should not be logging internal information such as XIDs as +> > KERN_NOTICE messages. +> +> I didn't now that was a general rule. Is it that KERN_NOTICE (and +> higher?) messages are expected to be leaked to users we don't trust? +> +> I also wouldn't have expected XIDs to be terribly useful to an +> attacker. +> But maybe it could help inject a malicious reply. +> + +As I said, the information is already available to privileged users. +They can turn on dprintks, tracepoints, or they can look in +/sys/kernel/debug. The ONLY reason for putting this information into +the above notice would be to allow unprivileged users to get the same +info displaying on their tty consoles. + +What are said unprivileged users going to do with this information? +What does it allow them to do that they could not do before? + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust@primarydata.com diff --git a/a/content_digest b/N1/content_digest index 6ddc2ab..fc13305 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,64 +13,90 @@ " anna.schumaker@netapp.com <anna.schumaker@netapp.com>\0" "\00:1\0" "b\0" - "T24gTW9uLCAyMDE4LTAyLTEyIGF0IDExOjU0IC0wNTAwLCBiZmllbGRzQGZpZWxkc2VzLm9yZyB3\n" - "cm90ZToNCj4gT24gU2F0LCBGZWIgMTAsIDIwMTggYXQgMDE6NDE6NTVBTSArMDAwMCwgVHJvbmQg\n" - "TXlrbGVidXN0IHdyb3RlOg0KPiA+IE9uIEZyaSwgMjAxOC0wMi0wOSBhdCAyMzowNiAtMDIwMCwg\n" - "VGhpYWdvIFJhZmFlbCBCZWNrZXIgd3JvdGU6DQo+ID4gPiBXaGVuIGludmVzdGlnYXRpbmcgcmVh\n" - "c29ucyBmb3IgbmZzIGZhaWx1cmVzLCBwYWNrZXQgZHVtcHMgYXJlaQ0KPiA+ID4gZXZlbnR1YWxs\n" - "eSB1c2VkLg0KPiA+ID4gRmluZGluZyB0aGUgcnBjIHRoYXQgZ2VuZXJhdGVkIHRoZSBmYWlsdXJl\n" - "IGlzIGRvbmUgYnkgY29tcGFyaW5nDQo+ID4gPiBhbGwNCj4gPiA+IHNlbnQNCj4gPiA+IHJwYyBj\n" - "YWxscyBhbmQgYWxsIHJlY2VpdmVkIHJwYyByZXBsaWVzIGZvciB0aG9zZSB3aGljaCBhcmUNCj4g\n" - "PiA+IHVuYW5zd2VyZWQsDQo+ID4gPiB3aGljaCBpcyBwcm9uZSB0byBlcnJvcnMgbGlrZQ0KPiA+\n" - "ID4gLSBTbG93IHNlcnZlciByZXNwb25zZXMNCj4gPiA+IC0gSW5jb21wbGV0ZSBhbmQgdW5jYXB0\n" - "dXJlZCBwYWNrZXRzIGluIHRoZSBwYWNrZXQgZHVtcA0KPiA+ID4gLSBUaGUgaGV1cmlzdGljcyB1\n" - "c2VkIHRvIGluc3BlY3QgcGFja2V0cyBmYWlsaW5nIHRvIGludGVycHJldCBvbmUNCj4gPiA+IA0K\n" - "PiA+ID4gVGhpcyBwYXRjaCBhZGRzIHRoZSB4aWQgb2YgcnBjX3Rhc2tzIHRvIHRoZSAnbm90IHJl\n" - "c3BvbmRpbmcnDQo+ID4gPiBtZXNzYWdlcw0KPiA+ID4gaW4gY2FsbF90aW1lb3V0IHRvIG1ha2Ug\n" - "dGhlc2UgYW5hbHlzaXMgbW9yZSBwcmVjaXNlLg0KPiA+ID4gDQo+ID4gPiBTaWduZWQtb2ZmLWJ5\n" - "OiBUaGlhZ28gUmFmYWVsIEJlY2tlciA8dGhpYWdvLmJlY2tlckBnbWFpbC5jb20+DQo+ID4gPiAt\n" - "LS0NCj4gPiA+ICBuZXQvc3VucnBjL2NsbnQuYyB8IDEwICsrKysrKy0tLS0NCj4gPiA+ICAxIGZp\n" - "bGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQ0KPiA+ID4gDQo+ID4g\n" - "PiBkaWZmIC0tZ2l0IGEvbmV0L3N1bnJwYy9jbG50LmMgYi9uZXQvc3VucnBjL2NsbnQuYw0KPiA+\n" - "ID4gaW5kZXggZTJhNDE4NGYzYzVkLi44M2M4YWNhOTUxZjQgMTAwNjQ0DQo+ID4gPiAtLS0gYS9u\n" - "ZXQvc3VucnBjL2NsbnQuYw0KPiA+ID4gKysrIGIvbmV0L3N1bnJwYy9jbG50LmMNCj4gPiA+IEBA\n" - "IC0yMjE0LDkgKzIyMTQsMTAgQEAgY2FsbF90aW1lb3V0KHN0cnVjdCBycGNfdGFzayAqdGFzaykN\n" - "Cj4gPiA+ICAJfQ0KPiA+ID4gIAlpZiAoUlBDX0lTX1NPRlQodGFzaykpIHsNCj4gPiA+ICAJCWlm\n" - "IChjbG50LT5jbF9jaGF0dHkpIHsNCj4gPiA+IC0JCQlwcmludGsoS0VSTl9OT1RJQ0UgIiVzOiBz\n" - "ZXJ2ZXIgJXMgbm90DQo+ID4gPiByZXNwb25kaW5nLCB0aW1lZCBvdXRcbiIsDQo+ID4gPiArCQkJ\n" - "cHJpbnRrKEtFUk5fTk9USUNFICIlczogc2VydmVyICVzIG5vdA0KPiA+ID4gcmVzcG9uZGluZywg\n" - "dGltZWQgb3V0ICh4aWQ6ICV4KVxuIiwNCj4gPiA+ICAJCQkJY2xudC0+Y2xfcHJvZ3JhbS0+bmFt\n" - "ZSwNCj4gPiA+IC0JCQkJdGFzay0+dGtfeHBydC0+c2VydmVybmFtZSk7DQo+ID4gPiArCQkJCXRh\n" - "c2stPnRrX3hwcnQtPnNlcnZlcm5hbWUsDQo+ID4gPiArCQkJCWJlMzJfdG9fY3B1KHRhc2stPnRr\n" - "X3Jxc3RwLQ0KPiA+ID4gPiBycV94aWQpKTsNCj4gPiA+IA0KPiA+ID4gIAkJfQ0KPiA+ID4gIAkJ\n" - "aWYgKHRhc2stPnRrX2ZsYWdzICYgUlBDX1RBU0tfVElNRU9VVCkNCj4gPiA+ICAJCQlycGNfZXhp\n" - "dCh0YXNrLCAtRVRJTUVET1VUKTsNCj4gPiA+IEBAIC0yMjI4LDkgKzIyMjksMTAgQEAgY2FsbF90\n" - "aW1lb3V0KHN0cnVjdCBycGNfdGFzayAqdGFzaykNCj4gPiA+ICAJaWYgKCEodGFzay0+dGtfZmxh\n" - "Z3MgJiBSUENfQ0FMTF9NQUpPUlNFRU4pKSB7DQo+ID4gPiAgCQl0YXNrLT50a19mbGFncyB8PSBS\n" - "UENfQ0FMTF9NQUpPUlNFRU47DQo+ID4gPiAgCQlpZiAoY2xudC0+Y2xfY2hhdHR5KSB7DQo+ID4g\n" - "PiAtCQkJcHJpbnRrKEtFUk5fTk9USUNFICIlczogc2VydmVyICVzIG5vdA0KPiA+ID4gcmVzcG9u\n" - "ZGluZywgc3RpbGwgdHJ5aW5nXG4iLA0KPiA+ID4gKwkJCXByaW50ayhLRVJOX05PVElDRSAiJXM6\n" - "IHNlcnZlciAlcyBub3QNCj4gPiA+IHJlc3BvbmRpbmcsIHN0aWxsIHRyeWluZyAoeGlkOiAleClc\n" - "biIsDQo+ID4gPiAgCQkJY2xudC0+Y2xfcHJvZ3JhbS0+bmFtZSwNCj4gPiA+IC0JCQl0YXNrLT50\n" - "a194cHJ0LT5zZXJ2ZXJuYW1lKTsNCj4gPiA+ICsJCQl0YXNrLT50a194cHJ0LT5zZXJ2ZXJuYW1l\n" - "LA0KPiA+ID4gKwkJCWJlMzJfdG9fY3B1KHRhc2stPnRrX3Jxc3RwLT5ycV94aWQpKTsNCj4gPiA+\n" - "ICAJCX0NCj4gPiA+ICAJfQ0KPiA+ID4gIAlycGNfZm9yY2VfcmViaW5kKGNsbnQpOw0KPiA+IA0K\n" - "PiA+IE5BQ0suIFdlIHNob3VsZCBub3QgYmUgbG9nZ2luZyBpbnRlcm5hbCBpbmZvcm1hdGlvbiBz\n" - "dWNoIGFzIFhJRHMgYXMNCj4gPiBLRVJOX05PVElDRSBtZXNzYWdlcy4NCj4gDQo+IEkgZGlkbid0\n" - "IG5vdyB0aGF0IHdhcyBhIGdlbmVyYWwgcnVsZS4gIElzIGl0IHRoYXQgS0VSTl9OT1RJQ0UgKGFu\n" - "ZA0KPiBoaWdoZXI/KSBtZXNzYWdlcyBhcmUgZXhwZWN0ZWQgdG8gYmUgbGVha2VkIHRvIHVzZXJz\n" - "IHdlIGRvbid0IHRydXN0Pw0KPiANCj4gSSBhbHNvIHdvdWxkbid0IGhhdmUgZXhwZWN0ZWQgWElE\n" - "cyB0byBiZSB0ZXJyaWJseSB1c2VmdWwgdG8gYW4NCj4gYXR0YWNrZXIuDQo+IEJ1dCBtYXliZSBp\n" - "dCBjb3VsZCBoZWxwIGluamVjdCBhIG1hbGljaW91cyByZXBseS4NCj4gDQoNCkFzIEkgc2FpZCwg\n" - "dGhlIGluZm9ybWF0aW9uIGlzIGFscmVhZHkgYXZhaWxhYmxlIHRvIHByaXZpbGVnZWQgdXNlcnMu\n" - "DQpUaGV5IGNhbiB0dXJuIG9uIGRwcmludGtzLCB0cmFjZXBvaW50cywgb3IgdGhleSBjYW4gbG9v\n" - "ayBpbg0KL3N5cy9rZXJuZWwvZGVidWcuIFRoZSBPTkxZIHJlYXNvbiBmb3IgcHV0dGluZyB0aGlz\n" - "IGluZm9ybWF0aW9uIGludG8NCnRoZSBhYm92ZSBub3RpY2Ugd291bGQgYmUgdG8gYWxsb3cgdW5w\n" - "cml2aWxlZ2VkIHVzZXJzIHRvIGdldCB0aGUgc2FtZQ0KaW5mbyBkaXNwbGF5aW5nIG9uIHRoZWly\n" - "IHR0eSBjb25zb2xlcy4NCg0KV2hhdCBhcmUgc2FpZCB1bnByaXZpbGVnZWQgdXNlcnMgZ29pbmcg\n" - "dG8gZG8gd2l0aCB0aGlzIGluZm9ybWF0aW9uPw0KV2hhdCBkb2VzIGl0IGFsbG93IHRoZW0gdG8g\n" - "ZG8gdGhhdCB0aGV5IGNvdWxkIG5vdCBkbyBiZWZvcmU/DQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0\n" - "DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9uZC5teWtsZWJ1\n" - c3RAcHJpbWFyeWRhdGEuY29tDQo= + "On Mon, 2018-02-12 at 11:54 -0500, bfields@fieldses.org wrote:\n" + "> On Sat, Feb 10, 2018 at 01:41:55AM +0000, Trond Myklebust wrote:\n" + "> > On Fri, 2018-02-09 at 23:06 -0200, Thiago Rafael Becker wrote:\n" + "> > > When investigating reasons for nfs failures, packet dumps arei\n" + "> > > eventually used.\n" + "> > > Finding the rpc that generated the failure is done by comparing\n" + "> > > all\n" + "> > > sent\n" + "> > > rpc calls and all received rpc replies for those which are\n" + "> > > unanswered,\n" + "> > > which is prone to errors like\n" + "> > > - Slow server responses\n" + "> > > - Incomplete and uncaptured packets in the packet dump\n" + "> > > - The heuristics used to inspect packets failing to interpret one\n" + "> > > \n" + "> > > This patch adds the xid of rpc_tasks to the 'not responding'\n" + "> > > messages\n" + "> > > in call_timeout to make these analysis more precise.\n" + "> > > \n" + "> > > Signed-off-by: Thiago Rafael Becker <thiago.becker@gmail.com>\n" + "> > > ---\n" + "> > > net/sunrpc/clnt.c | 10 ++++++----\n" + "> > > 1 file changed, 6 insertions(+), 4 deletions(-)\n" + "> > > \n" + "> > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c\n" + "> > > index e2a4184f3c5d..83c8aca951f4 100644\n" + "> > > --- a/net/sunrpc/clnt.c\n" + "> > > +++ b/net/sunrpc/clnt.c\n" + "> > > @@ -2214,9 +2214,10 @@ call_timeout(struct rpc_task *task)\n" + "> > > \t}\n" + "> > > \tif (RPC_IS_SOFT(task)) {\n" + "> > > \t\tif (clnt->cl_chatty) {\n" + "> > > -\t\t\tprintk(KERN_NOTICE \"%s: server %s not\n" + "> > > responding, timed out\\n\",\n" + "> > > +\t\t\tprintk(KERN_NOTICE \"%s: server %s not\n" + "> > > responding, timed out (xid: %x)\\n\",\n" + "> > > \t\t\t\tclnt->cl_program->name,\n" + "> > > -\t\t\t\ttask->tk_xprt->servername);\n" + "> > > +\t\t\t\ttask->tk_xprt->servername,\n" + "> > > +\t\t\t\tbe32_to_cpu(task->tk_rqstp-\n" + "> > > > rq_xid));\n" + "> > > \n" + "> > > \t\t}\n" + "> > > \t\tif (task->tk_flags & RPC_TASK_TIMEOUT)\n" + "> > > \t\t\trpc_exit(task, -ETIMEDOUT);\n" + "> > > @@ -2228,9 +2229,10 @@ call_timeout(struct rpc_task *task)\n" + "> > > \tif (!(task->tk_flags & RPC_CALL_MAJORSEEN)) {\n" + "> > > \t\ttask->tk_flags |= RPC_CALL_MAJORSEEN;\n" + "> > > \t\tif (clnt->cl_chatty) {\n" + "> > > -\t\t\tprintk(KERN_NOTICE \"%s: server %s not\n" + "> > > responding, still trying\\n\",\n" + "> > > +\t\t\tprintk(KERN_NOTICE \"%s: server %s not\n" + "> > > responding, still trying (xid: %x)\\n\",\n" + "> > > \t\t\tclnt->cl_program->name,\n" + "> > > -\t\t\ttask->tk_xprt->servername);\n" + "> > > +\t\t\ttask->tk_xprt->servername,\n" + "> > > +\t\t\tbe32_to_cpu(task->tk_rqstp->rq_xid));\n" + "> > > \t\t}\n" + "> > > \t}\n" + "> > > \trpc_force_rebind(clnt);\n" + "> > \n" + "> > NACK. We should not be logging internal information such as XIDs as\n" + "> > KERN_NOTICE messages.\n" + "> \n" + "> I didn't now that was a general rule. Is it that KERN_NOTICE (and\n" + "> higher?) messages are expected to be leaked to users we don't trust?\n" + "> \n" + "> I also wouldn't have expected XIDs to be terribly useful to an\n" + "> attacker.\n" + "> But maybe it could help inject a malicious reply.\n" + "> \n" + "\n" + "As I said, the information is already available to privileged users.\n" + "They can turn on dprintks, tracepoints, or they can look in\n" + "/sys/kernel/debug. The ONLY reason for putting this information into\n" + "the above notice would be to allow unprivileged users to get the same\n" + "info displaying on their tty consoles.\n" + "\n" + "What are said unprivileged users going to do with this information?\n" + "What does it allow them to do that they could not do before?\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust@primarydata.com -e8ce1d43908536f87f90cf22c62fc90967251fb7e49af5b4406e1bb6af55011d +97dedd260678768405ab70ee11e25e4f0f1d1a8d698bb66c9e31271790daa972
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.