From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH v2 3/7] multipathd: remove coalesce_paths from ev_add_map Date: Mon, 12 Feb 2018 21:30:07 +0100 Message-ID: <1518467407.2761.68.camel@suse.com> References: <1518134167-15938-1-git-send-email-bmarzins@redhat.com> <1518134167-15938-4-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1518134167-15938-4-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Benjamin Marzinski , device-mapper development List-Id: dm-devel.ids T24gVGh1LCAyMDE4LTAyLTA4IGF0IDE3OjU2IC0wNjAwLCBCZW5qYW1pbiBNYXJ6aW5za2kgd3Jv dGU6Cj4gSWYgZXZfYWRkX21hcCBpcyBjYWxsZWQgZm9yIGEgbXVsdGlwYXRoIGRldmljZSB0aGF0 IGRvZXNuJ3QgZXhpc3QgaW4KPiBkZXZpY2UtbWFwcGVyLCBpdCB3aWxsIGNhbGwgY29hbGVzY2Vf cGF0aHMgdG8gYWRkIGl0LiAgVGhpcyBkb2Vzbid0Cj4gd29yawo+IGFuZCBoYXNuJ3QgZm9yIHll YXJzLiBJdCBkb2Vzbid0IGFkZCB0aGUgbWFwIHRvIHRoZSBtcHZlYywgb3Igc3RhcnQKPiB1cAo+ IHdhaXRlcnMsIG9yIGRvIGFueSBvZiB0aGUgbmVjZXNzYXJ5IHRoaW5ncyB0aGF0IGRvIGdldCBk b25lIHdoZW4geW91Cj4gY2FsbCBldl9hZGRfbWFwIGZvciBhIG1hcCB0aGF0IGRvZXMgZXhpc3Qg aW4gZGV2aWNlIG1hcHBlci4KPiAKPiBGb3J0dW5hdGVseSwgdGhlcmUgYXJlIG9ubHkgdHdvIHRo aW5ncyB0aGF0IGNhbGwgZXZfYWRkX21hcC4KPiB1ZXZfYWRkX21hcAo+IG1ha2VzIHN1cmUgdGhh dCB0aGUgZGV2aWNlIGRvZXMgZXhpc3QgaW4gZGV2aWNlLW1hcHBlciBiZWZvcmUgY2FsbGluZwo+ IGV2X2FkZF9tYXAsIGFuZCBjbGlfYWRkX21hcCBjcmVhdGVzIHRoZSBkZXZpY2UgZmlyc3QgYW5k IHRoZW4gY2FsbHMKPiBldl9hZGRfbWFwLCBpZiB0aGUgZGV2aWNlIGRvZXNuJ3QgZXhpc3QuCj4g Cj4gU28sIHRoZXJlIGlzIG5vIHJlYXNvbiBmb3IgY29hbGVzY2VfcGF0aHMgdG8gYmUgaW4gZXZf YWRkX21hcC4gVGhpcwo+IHJlbW92ZXMgaXQuCj4gCj4gQ2M6IE1hcnRpbiBXaWxjayA8bXdpbGNr QHN1c2UuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEJlbmphbWluIE1hcnppbnNraSA8Ym1hcnppbnNA cmVkaGF0LmNvbT4KCgpSZXZpZXdlZC1ieTogTWFydGluIFdpbGNrIDxtd2lsY2tAc3VzZS5jb20+ CgoKPiAtLS0KPiAgbXVsdGlwYXRoZC9tYWluLmMgfCA0NiArKysrKysrKysrKysrKy0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAtCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRp b25zKCspLCAzMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvbXVsdGlwYXRoZC9tYWlu LmMgYi9tdWx0aXBhdGhkL21haW4uYwo+IGluZGV4IDI3Y2YyMzQuLmRiZjk4OTAgMTAwNjQ0Cj4g LS0tIGEvbXVsdGlwYXRoZC9tYWluLmMKPiArKysgYi9tdWx0aXBhdGhkL21haW4uYwo+IEBAIC00 MTIsMTggKzQxMiwxOSBAQCB1ZXZfYWRkX21hcCAoc3RydWN0IHVldmVudCAqIHVldiwgc3RydWN0 Cj4gdmVjdG9ycyAqIHZlY3MpCj4gIAlyZXR1cm4gcmM7Cj4gIH0KPiAgCj4gKy8qCj4gKyAqIGV2 X2FkZF9tYXAgZXhwZWN0cyB0aGF0IHRoZSBtdWx0aXBhdGggZGV2aWNlIGFscmVhZHkgZXhpc3Rz IGluCj4ga2VybmVsCj4gKyAqIGJlZm9yZSBpdCBpcyBjYWxsZWQuIEl0IGp1c3QgYWRkcyBhIGRl dmljZSB0byBtdWx0aXBhdGhkIG9yCj4gdXBkYXRlcyBhbgo+ICsgKiBleGlzdGluZyBkZXZpY2Uu Cj4gKyAqLwo+ICBpbnQKPiAgZXZfYWRkX21hcCAoY2hhciAqIGRldiwgY2hhciAqIGFsaWFzLCBz dHJ1Y3QgdmVjdG9ycyAqIHZlY3MpCj4gIHsKPiAtCWNoYXIgKiByZWZ3d2lkOwo+ICAJc3RydWN0 IG11bHRpcGF0aCAqIG1wcDsKPiAtCWludCBtYXBfcHJlc2VudDsKPiAtCWludCByID0gMSwgZGVs YXllZF9yZWNvbmZpZywgcmVhc3NpZ25fbWFwczsKPiArCWludCBkZWxheWVkX3JlY29uZmlnLCBy ZWFzc2lnbl9tYXBzOwo+ICAJc3RydWN0IGNvbmZpZyAqY29uZjsKPiAgCj4gLQltYXBfcHJlc2Vu dCA9IGRtX21hcF9wcmVzZW50KGFsaWFzKTsKPiAtCj4gLQlpZiAobWFwX3ByZXNlbnQgJiYgIWRt X2lzX21wYXRoKGFsaWFzKSkgewo+ICsJaWYgKCFkbV9pc19tcGF0aChhbGlhcykpIHsKPiAgCQlj b25kbG9nKDQsICIlczogbm90IGEgbXVsdGlwYXRoIG1hcCIsIGFsaWFzKTsKPiAgCQlyZXR1cm4g MDsKPiAgCX0KPiBAQCAtNDY4LDMzICs0NjksMTQgQEAgZXZfYWRkX21hcCAoY2hhciAqIGRldiwg Y2hhciAqIGFsaWFzLCBzdHJ1Y3QKPiB2ZWN0b3JzICogdmVjcykKPiAgCS8qCj4gIAkgKiBub3cg d2UgY2FuIHJlZ2lzdGVyIHRoZSBtYXAKPiAgCSAqLwo+IC0JaWYgKG1hcF9wcmVzZW50KSB7Cj4g LQkJaWYgKChtcHAgPSBhZGRfbWFwX3dpdGhvdXRfcGF0aCh2ZWNzLCBhbGlhcykpKSB7Cj4gLQkJ CXN5bmNfbWFwX3N0YXRlKG1wcCk7Cj4gLQkJCWNvbmRsb2coMiwgIiVzOiBkZXZtYXAgJXMgcmVn aXN0ZXJlZCIsCj4gYWxpYXMsIGRldik7Cj4gLQkJCXJldHVybiAwOwo+IC0JCX0gZWxzZSB7Cj4g LQkJCWNvbmRsb2coMiwgIiVzOiB1ZXZfYWRkX21hcCBmYWlsZWQiLCBkZXYpOwo+IC0JCQlyZXR1 cm4gMTsKPiAtCQl9Cj4gLQl9Cj4gLQlyID0gZ2V0X3JlZnd3aWQoQ01EX05PTkUsIGRldiwgREVW X0RFVk1BUCwgdmVjcy0+cGF0aHZlYywKPiAmcmVmd3dpZCk7Cj4gLQo+IC0JaWYgKHJlZnd3aWQp IHsKPiAtCQlyID0gY29hbGVzY2VfcGF0aHModmVjcywgTlVMTCwgcmVmd3dpZCwKPiBGT1JDRV9S RUxPQURfTk9ORSwKPiAtCQkJCSAgIENNRF9OT05FKTsKPiAtCQlkbV9saWJfcmVsZWFzZSgpOwo+ ICsJaWYgKChtcHAgPSBhZGRfbWFwX3dpdGhvdXRfcGF0aCh2ZWNzLCBhbGlhcykpKSB7Cj4gKwkJ c3luY19tYXBfc3RhdGUobXBwKTsKPiArCQljb25kbG9nKDIsICIlczogZGV2bWFwICVzIHJlZ2lz dGVyZWQiLCBhbGlhcywgZGV2KTsKPiArCQlyZXR1cm4gMDsKPiArCX0gZWxzZSB7Cj4gKwkJY29u ZGxvZygyLCAiJXM6IGV2X2FkZF9tYXAgZmFpbGVkIiwgZGV2KTsKPiArCQlyZXR1cm4gMTsKPiAg CX0KPiAtCj4gLQlpZiAoIXIpCj4gLQkJY29uZGxvZygyLCAiJXM6IGRldm1hcCAlcyBhZGRlZCIs IGFsaWFzLCBkZXYpOwo+IC0JZWxzZSBpZiAociA9PSAyKQo+IC0JCWNvbmRsb2coMiwgIiVzOiB1 ZXZfYWRkX21hcCAlcyBibGFja2xpc3RlZCIsIGFsaWFzLAo+IGRldik7Cj4gLQllbHNlCj4gLQkJ Y29uZGxvZygwLCAiJXM6IHVldl9hZGRfbWFwICVzIGZhaWxlZCIsIGFsaWFzLCBkZXYpOwo+IC0K PiAtCUZSRUUocmVmd3dpZCk7Cj4gLQlyZXR1cm4gcjsKPiAgfQo+ICAKPiAgc3RhdGljIGludAoK LS0gCkRyLiBNYXJ0aW4gV2lsY2sgPG13aWxja0BzdXNlLmNvbT4sIFRlbC4gKzQ5ICgwKTkxMSA3 NDA1MyAyMTA3ClNVU0UgTGludXggR21iSCwgR0Y6IEZlbGl4IEltZW5kw7ZyZmZlciwgSmFuZSBT bWl0aGFyZCwgR3JhaGFtIE5vcnRvbgpIUkIgMjEyODQgKEFHIE7DvHJuYmVyZykKCi0tCmRtLWRl dmVsIG1haWxpbmcgbGlzdApkbS1kZXZlbEByZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5j b20vbWFpbG1hbi9saXN0aW5mby9kbS1kZXZlbA==