From: Mike Galbraith <efault@gmx.de>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Oleksandr Natalenko <oleksandr@natalenko.name>,
Jens Axboe <axboe@kernel.dk>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook
Date: Tue, 13 Feb 2018 15:30:36 +0100 [thread overview]
Message-ID: <1518532236.15792.25.camel@gmx.de> (raw)
In-Reply-To: <E25879D9-0AF9-4924-A5AF-91FB69DD324C@linaro.org>
On Tue, 2018-02-13 at 09:15 +0100, Paolo Valente wrote:
>
>
> No bfq in the trace, so probably yet another problem stemming from the
> interaction between bfq and blk-mq. Hung tasks seem to wait
> indefinitely for a tag, and the only bfq patch that affects tag
> distribution is:
> a52a69ea89dc block, bfq: limit tags for writes and async I/O
>
> So, for the next step (and as you already decided to do), please retry
> after adding the above commit to your initial pair:
> patches/block-bfq:-fix-occurrences-of-request-finish-method-s-old-name.patch
> patches/block-bfq:-add-requeue-request-hook.patch
I did it a bit differently, revert that commit in master, and skip it
in 4.15.3 with the otherwise full set first, and saw no hangs testing
either. ï¿œI then added it to the 2 patch series, and was rewarded
with... no bloody hang. ï¿œSo it's not as deterministic as it had
appeared to be, there's a phase-of-moon factor. ï¿œOh. Joy.
-Mike
next prev parent reply other threads:[~2018-02-13 14:30 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 21:19 [PATCH BUGFIX V3] block, bfq: add requeue-request hook Paolo Valente
2018-02-07 22:18 ` Jens Axboe
2018-02-08 7:16 ` Paolo Valente
2018-02-08 7:16 ` Paolo Valente
2018-02-09 13:21 ` Oleksandr Natalenko
2018-02-09 17:17 ` Jens Axboe
2018-02-09 17:29 ` Mike Galbraith
2018-02-10 8:29 ` Oleksandr Natalenko
2018-02-10 8:29 ` Oleksandr Natalenko
2018-02-12 7:24 ` Paolo Valente
2018-02-12 7:24 ` Paolo Valente
2018-02-12 11:22 ` Mike Galbraith
2018-02-12 12:48 ` Oleksandr Natalenko
2018-02-13 5:02 ` Mike Galbraith
2018-02-13 5:46 ` Paolo Valente
2018-02-13 6:42 ` Mike Galbraith
2018-02-13 6:50 ` Mike Galbraith
2018-02-13 8:15 ` Paolo Valente
2018-02-13 14:30 ` Mike Galbraith [this message]
2018-02-14 5:58 ` Mike Galbraith
2018-02-14 7:04 ` Mike Galbraith
2018-02-14 7:15 ` Mike Galbraith
2018-02-14 8:56 ` Paolo Valente
2018-02-14 9:55 ` Oleksandr Natalenko
2018-02-14 13:25 ` Mike Galbraith
2018-02-14 15:19 ` Jens Axboe
2018-02-14 15:39 ` Paolo Valente
2018-02-14 15:44 ` Jens Axboe
2018-02-15 18:13 ` Paolo Valente
2018-02-16 5:39 ` Mike Galbraith
2018-02-16 7:16 ` Paolo Valente
2018-02-16 7:20 ` Paolo Valente
2018-02-17 5:30 ` Mike Galbraith
2018-02-17 5:33 ` Mike Galbraith
2018-02-19 5:34 ` Mike Galbraith
2018-02-19 6:05 ` Oleksandr Natalenko
2018-02-19 7:09 ` Mike Galbraith
2018-02-19 7:58 ` Mike Galbraith
2018-02-19 9:37 ` Paolo Valente
2018-02-19 13:18 ` Mike Galbraith
2018-02-17 5:39 ` Mike Galbraith
2018-02-26 19:48 ` Greg KH
2018-02-26 20:10 ` Oleksandr Natalenko
2018-02-26 20:18 ` Jens Axboe
2018-02-23 15:07 ` Ming Lei
2018-02-23 15:41 ` Paolo Valente
2018-02-23 15:41 ` Paolo Valente
2018-02-23 16:17 ` Ming Lei
2018-02-24 7:54 ` Paolo Valente
2018-02-24 7:54 ` Paolo Valente
2018-02-24 12:05 ` Ming Lei
2018-02-24 16:15 ` Paolo Valente
2018-02-24 16:15 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518532236.15792.25.camel@gmx.de \
--to=efault@gmx.de \
--cc=axboe@kernel.dk \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.