From: Paolo Abeni <pabeni@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH net] netfilter: nat: cope with negative port range
Date: Tue, 13 Feb 2018 18:22:35 +0100 [thread overview]
Message-ID: <1518542555.2376.6.camel@redhat.com> (raw)
In-Reply-To: <20180213170217.GA2810@breakpoint.cc>
On Tue, 2018-02-13 at 18:02 +0100, Florian Westphal wrote:
> Paolo Abeni <pabeni@redhat.com> wrote:
> > Fixes: c7232c9979cb ("netfilter: add protocol independent NAT core")
>
> are you sure?
> When I looked this was a day 0 bug, the code was just moved from ipv4.
You are right, the named commit just move around the bugged code, the
bug is apparently there since:
commit 5b1158e909ecbe1a052203e0d8df15633f829930
Author: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Date: Sat Dec 2 22:07:13 2006 -0800
[NETFILTER]: Add NAT support for nf_conntrack
I'll send a v2 with an updated commit message, thanks!
Paolo
prev parent reply other threads:[~2018-02-13 17:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 16:58 [PATCH net] netfilter: nat: cope with negative port range Paolo Abeni
2018-02-13 17:02 ` Florian Westphal
2018-02-13 17:22 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518542555.2376.6.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.