From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Tao, Zhe" <zhe.tao@intel.com>
Cc: dev@dpdk.org, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v4] i40e: fix TSO issue for tx function
Date: Wed, 06 Apr 2016 15:43:23 +0200 [thread overview]
Message-ID: <1518554.AZ5xZbn1fs@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B2EAD0@irsmsx105.ger.corp.intel.com>
> > We will not get what we want, the ipv6 packets sent out from IXIA can be
> > received by i40e, but cannot forward to another port.
> > The root cause is when HW doing the TSO offload for packets, it does not only
> > depends on the context descriptor to define the MSS and TSO payload size, it
> > also need to know whether this packets is ipv4 or ipv6, we use
> > i40e_txd_enable_checksum to generate the related fields for data descriptor.
> > But PMD will not call i40e_txd_enable_checksum if only the TSO offload flag is
> > set. The reason why ipv4 works fine for TSO in testpmd csum mode is csum engine
> > will set the ip csum flag when the packet is ipv4 and TSO is enabled but
> > will not set the flag for ipv6 and this flag will cause the
> > i40e_txd_enable_checksum to be invoked. For both the cases the TSO flag will be
> > set, so we need to use TSO flag to trigger the i40e_txd_enable_checksum.
> > The right logic here is we enable csum offload for both ipv4 and ipv6 when TSO
> > flag is set.
> >
> > Fixes: e3f0151f (i40e: enable Tx checksum only for offloaded packets)
> >
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2016-04-06 13:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 13:13 [PATCH] i40e: fix ipv6 TSO issue for tx function Zhe Tao
2016-03-22 13:38 ` Ananyev, Konstantin
2016-03-22 18:41 ` Zhe Tao
2016-03-23 3:27 ` [PATCH v2] " Zhe Tao
2016-03-23 12:46 ` Ananyev, Konstantin
2016-03-24 14:58 ` Bruce Richardson
2016-03-24 15:00 ` Bruce Richardson
2016-03-31 3:58 ` Zhe Tao
2016-03-31 12:15 ` [PATCH v3] i40e: fix " Zhe Tao
2016-03-31 12:18 ` Bruce Richardson
2016-04-06 8:16 ` [PATCH v4] " Zhe Tao
2016-04-06 11:23 ` Ananyev, Konstantin
2016-04-06 13:43 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518554.AZ5xZbn1fs@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=zhe.tao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.