From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: 4.16-rc1: UBSAN warning in nouveau/nvkm/subdev/therm/base.c + oops in nvkm_therm_clkgate_fini Date: Wed, 14 Feb 2018 14:11:04 -0500 Message-ID: <1518635464.3674.2.camel@redhat.com> References: <20180214174125.b5bdowaadck3vf5n@pmoreau.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180214174125.b5bdowaadck3vf5n-WLoDKDh+7sdAfugRpC6u6w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Pierre Moreau , Ilia Mirkin Cc: nouveau , Meelis Roos , Ben Skeggs , dri-devel , Linux Kernel list List-Id: nouveau.vger.kernel.org QWN0dWFsbHkgdGhpcyB3YXMgYnJvdWdodCB1cCB0byBtZSBhbHJlYWR5LCB0aGVyZSdzIGEgZml4 IG9uIHRoZSBtYWlsaW5nIGxpc3QKZm9yIHRoaXMgSSByZXZpZXdlZCBhIGxpdHRsZSB3aGlsZSBh Z28gZnJvbSBudmlkaWEgdGhhdCB3ZSBzaG91bGQgcHVsbCBpbjoKCmh0dHBzOi8vcGF0Y2h3b3Jr LmZyZWVkZXNrdG9wLm9yZy9wYXRjaC8yMDMyMDUvCgpXb3VsZCB5b3UgZ3V5cyBtaW5kIGNvbmZp cm1pbmcgdGhhdCB0aGlzIHBhdGNoIGZpeGVzIHlvdXIgaXNzdWVzPwoKT24gV2VkLCAyMDE4LTAy LTE0IGF0IDE4OjQxICswMTAwLCBQaWVycmUgTW9yZWF1IHdyb3RlOgo+IE9uIDIwMTgtMDItMTQg 4oCUIDA5OjM2LCBJbGlhIE1pcmtpbiB3cm90ZToKPiA+IE9uIFdlZCwgRmViIDE0LCAyMDE4IGF0 IDk6MzUgQU0sIElsaWEgTWlya2luIDxpbWlya2luQGFsdW0ubWl0LmVkdT4gd3JvdGU6Cj4gPiA+ IE9uIFdlZCwgRmViIDE0LCAyMDE4IGF0IDk6MjkgQU0sIE1lZWxpcyBSb29zIDxtcm9vc0BsaW51 eC5lZT4gd3JvdGU6Cj4gPiA+ID4gPiBUaGlzIGlzIDQuMTYtcmMxK3RvZGF5cyBnaXQgb24gYSBs b3dseSBQNCB3aXRoIE5WNSwgd29ya2VkIGZpbmUgaW4KPiA+ID4gPiA+IDQuMTU6Cj4gPiA+ID4g Cj4gPiA+ID4gTlY1IGluIGFub3RoZXIgUEMgKHNlY29uZGFyeSBjYXJkIGluIHg4Ni02NCkgbWFk ZSB0aGUgc3lzdHJlbSBjcmFzaCBvbgo+ID4gPiA+IGJvb3QsIGluIG52a21fdGhlcm1fY2xrZ2F0 ZV9maW5pLgo+ID4gPiAKPiA+ID4gTWluZCBib290aW5nIHdpdGggbm91dmVhdS5kZWJ1Zz10cmFj ZT8gVGhhdCBzaG91bGQgaG9wZWZ1bGx5IHRlbGwgdXMKPiA+ID4gbW9yZSBleGFjdGx5IHdoaWNo IHRoaW5nIGlzIGR5aW5nLiBJZiB5b3UgaGF2ZSBhIGNyb3NzLWNvbXBpbGUvZGlzdGNjCj4gPiA+ IHNldHVwIGhhbmR5LCBhIGJpc2VjdCBtYXkgYmUgZXZlbiBtb3JlIHVzZWZ1bC4KPiA+IAo+ID4g RXJtLCBzb3JyeSwgbmV2ZXJtaW5kLiBZb3UgZXZlbiBzYWlkIGl0IC0tIG52a21fdGhlcm1fY2xr Z2F0ZV9maW5pIGlzCj4gPiBzb21laG93IG1pcy1ob29rZWQgdXAgZm9yIE5WNSBub3cuIEEgYmlz ZWN0IHJlc3VsdCB3b3VsZCBzdGlsbCBtYWtlCj4gPiB0aGUgY3VscHJpdCBhIGxvdCBtb3JlIG9i dmlvdXMuCj4gCj4gQ0PigJlpbmcgTHl1ZGUgUGF1bCBhcyBzaGUgaG9va2VkIHVwIHRoZSBjbG9j a2dhdGluZyBzdXBwb3J0Lgo+IAo+IExvb2tpbmcgYXQgdGhlIGNvZGUsIG9ubHkgTlY0MCsgZG8g aGF2ZSBhIHRoZXJtIGVuZ2luZS4gVGhlcmVmb3JlLCBzaG91bGRu4oCZdAo+IG52a21fdGhlcm1f Y2xrZ2F0ZV9lbmFibGUoKSwgbnZrbV90aGVybV9jbGtnYXRlX2ZpbmkoKSBhbmQKPiBudmttX3Ro ZXJtX2Nsa2dhdGVfb25laW5pdCgpIGFsbCBjaGVjayBmb3IgdGhlcm0gYmVpbmcgbm90IE5VTEws IG9uIHRvcCBvZgo+IHRoZWlyIGNoZWNrIGZvciB0aGUgY2xrZ2F0ZV8qIGhvb2tzIGJlaW5nIHRo ZXJlPyBPciBpbnN0ZWFkLCBtYXliZSBoYXZlIHRoZQo+IGNoZWNrIGluIG52a21fZGV2aWNlX2lu aXQoKSBudmttX2RldmljZV9pbml0KCk/Cj4gCj4gUGllcnJlCi0tIApDaGVlcnMsCglMeXVkZSBQ YXVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5vdXZl YXUgbWFpbGluZyBsaXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162741AbeBNTLI (ORCPT ); Wed, 14 Feb 2018 14:11:08 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:35568 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162681AbeBNTLG (ORCPT ); Wed, 14 Feb 2018 14:11:06 -0500 X-Google-Smtp-Source: AH8x226ErFMwaUBbQFn5P3Ejlu+oKe5CxLYZ2sWP7TxeaBOJak/aH5nucjx78mWI1rXkC576ltZywA== Message-ID: <1518635464.3674.2.camel@redhat.com> Subject: Re: [Nouveau] 4.16-rc1: UBSAN warning in nouveau/nvkm/subdev/therm/base.c + oops in nvkm_therm_clkgate_fini From: Lyude Paul To: Pierre Moreau , Ilia Mirkin Cc: Meelis Roos , nouveau , Ben Skeggs , dri-devel , Linux Kernel list Date: Wed, 14 Feb 2018 14:11:04 -0500 In-Reply-To: <20180214174125.b5bdowaadck3vf5n@pmoreau.org> References: <20180214174125.b5bdowaadck3vf5n@pmoreau.org> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.4 (3.26.4-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Actually this was brought up to me already, there's a fix on the mailing list for this I reviewed a little while ago from nvidia that we should pull in: https://patchwork.freedesktop.org/patch/203205/ Would you guys mind confirming that this patch fixes your issues? On Wed, 2018-02-14 at 18:41 +0100, Pierre Moreau wrote: > On 2018-02-14 — 09:36, Ilia Mirkin wrote: > > On Wed, Feb 14, 2018 at 9:35 AM, Ilia Mirkin wrote: > > > On Wed, Feb 14, 2018 at 9:29 AM, Meelis Roos wrote: > > > > > This is 4.16-rc1+todays git on a lowly P4 with NV5, worked fine in > > > > > 4.15: > > > > > > > > NV5 in another PC (secondary card in x86-64) made the systrem crash on > > > > boot, in nvkm_therm_clkgate_fini. > > > > > > Mind booting with nouveau.debug=trace? That should hopefully tell us > > > more exactly which thing is dying. If you have a cross-compile/distcc > > > setup handy, a bisect may be even more useful. > > > > Erm, sorry, nevermind. You even said it -- nvkm_therm_clkgate_fini is > > somehow mis-hooked up for NV5 now. A bisect result would still make > > the culprit a lot more obvious. > > CC’ing Lyude Paul as she hooked up the clockgating support. > > Looking at the code, only NV40+ do have a therm engine. Therefore, shouldn’t > nvkm_therm_clkgate_enable(), nvkm_therm_clkgate_fini() and > nvkm_therm_clkgate_oneinit() all check for therm being not NULL, on top of > their check for the clkgate_* hooks being there? Or instead, maybe have the > check in nvkm_device_init() nvkm_device_init()? > > Pierre -- Cheers, Lyude Paul