From: Jeff Layton <jlayton@samba.org>
To: David Disseldorp <ddiss@suse.de>,
Samba Technical <samba-technical@lists.samba.org>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH v2] Samba RADOS service registration
Date: Thu, 15 Feb 2018 13:09:45 -0500 [thread overview]
Message-ID: <1518718185.4086.45.camel@samba.org> (raw)
In-Reply-To: <20180213202727.77175e21@suse.de>
On Tue, 2018-02-13 at 20:27 +0100, David Disseldorp wrote:
>
> + instance_guid = rados_get_instance_id(state->cluster);
> +
> + ret = ceph_service_instance_gen(instance_buf, sizeof(instance_buf),
> + daemon, instance_guid);
> + if (ret < 0) {
> + goto out_mem_free;
> + }
> +
> + DBG_DEBUG("registering as %s with %s Ceph cluster\n", instance_buf,
> + (cluster_name != NULL ? cluster_name : "default"));
> +
> + ret = rados_service_register(state->cluster, "samba", instance_buf, "");
IIUC, if the program (samba in this case) dies, and then is restarted
(maybe host reboots?), it'll get a new instance_guid, right? Or am I
misunderstanding what rados_get_instance_id will return here?
--
Jeff Layton <jlayton@samba.org>
next prev parent reply other threads:[~2018-02-15 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 1:25 [RFC PATCH] Samba RADOS service registration David Disseldorp
2018-02-13 1:46 ` Jason Dillaman
2018-02-13 2:30 ` Sage Weil
2018-02-13 11:07 ` John Spray
2018-02-13 12:29 ` David Disseldorp
2018-02-13 12:48 ` Volker Lendecke
2018-02-13 13:43 ` Samba Ceph dbwrap backend David Disseldorp
2018-02-13 19:27 ` [PATCH v2] Samba RADOS service registration David Disseldorp
2018-02-15 18:09 ` Jeff Layton [this message]
2018-02-15 18:52 ` David Disseldorp
2018-02-15 19:05 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518718185.4086.45.camel@samba.org \
--to=jlayton@samba.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ddiss@suse.de \
--cc=samba-technical@lists.samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.