From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 11 Mar 2015 10:50 +0100 Subject: [PATCH v2 1/2] drm/bridge: dw-hdmi: support optional supply regulators In-Reply-To: <1426066109.3101.46.camel@pengutronix.de> References: <2265807.RXHBN9kUi4@phil> <1426066109.3101.46.camel@pengutronix.de> Message-ID: <1518869.l1vLcA6CaR@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Philipp, Am Mittwoch, 11. M?rz 2015, 10:28:29 schrieb Philipp Zabel: > Am Dienstag, den 10.03.2015, 22:45 +0100 schrieb Heiko Stuebner: > > At least the Rockchip variant of the dw_hdmi can have controllable power > > supplies providing 1.0 and 1.8V. Therefore add the possibility for the > > generic bridge driver to enable supplies provided by the hw-specific > > drivers. > > > > Signed-off-by: Heiko Stuebner > > --- > > changes since v1: > > - follow suggestion from Russell King to keep regulator handling local > > > > to the rockchip implementation for the time being and only generalize > > when a real second implementation needs regulator handling > > > > .../devicetree/bindings/drm/bridge/dw_hdmi.txt | 5 ++++ > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 32 > > +++++++++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > > b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt index > > a905c14..bb74640 100644 > > --- a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > > +++ b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > > @@ -22,6 +22,11 @@ Optional properties > > > > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > > - clocks, clock-names: phandle to the HDMI CEC clock, name should be > > "cec" > > > > +Optional supplies: > > +rockchip,rk3288-dw-hdmi handles two optional power supplies: > > +- avdd1v0-supply: 1.0V power supply > > +- avdd1v8-supply: 1.8V power supply > > Are these the names used in the Rockchip documentation? > > Since the older implementation on i.MX6 uses 1.1V (HDMI_VP) and 2.5V > (HDMI_VPH), I wonder whether each SoC should use their own name or > whether there should be common names that don't include the voltage. > I don't have the Synopsys HDMI TX docs, but I've seen avddhv and avddlv > used of other cores' analog supplies. The pins of the soc connected to the regulators are named: HDMI_AVDD_1V0 HDMI_AVDD_1V8 The datasheet only calls both "DC supply voltage for Analog part of HDMI" and never mentions them again. The databook of the IP block itself seems to really call this VPH and VP as phy supplies, but documentation is a bit sparse about them. I guess as we already use the databook clock-names I should also switch to the databook supply names (avdd1v0 -> vp and avdd1v8 -> vph). Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2 1/2] drm/bridge: dw-hdmi: support optional supply regulators Date: Wed, 11 Mar 2015 10:50 +0100 Message-ID: <1518869.l1vLcA6CaR@phil> References: <2265807.RXHBN9kUi4@phil> <1426066109.3101.46.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1426066109.3101.46.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philipp Zabel Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King - ARM Linux , Pawel Moll , Ian Campbell , Kumar Gala , dianders@chromium.org, linux-rockchip@lists.infradead.org, Rob Herring , dri-devel@lists.freedesktop.org, Yakir Yang , Andy Yan , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcCwKCkFtIE1pdHR3b2NoLCAxMS4gTcOkcnogMjAxNSwgMTA6Mjg6Mjkgc2Nocmll YiBQaGlsaXBwIFphYmVsOgo+IEFtIERpZW5zdGFnLCBkZW4gMTAuMDMuMjAxNSwgMjI6NDUgKzAx MDAgc2NocmllYiBIZWlrbyBTdHVlYm5lcjoKPiA+IEF0IGxlYXN0IHRoZSBSb2NrY2hpcCB2YXJp YW50IG9mIHRoZSBkd19oZG1pIGNhbiBoYXZlIGNvbnRyb2xsYWJsZSBwb3dlcgo+ID4gc3VwcGxp ZXMgcHJvdmlkaW5nIDEuMCBhbmQgMS44Vi4gVGhlcmVmb3JlIGFkZCB0aGUgcG9zc2liaWxpdHkg Zm9yIHRoZQo+ID4gZ2VuZXJpYyBicmlkZ2UgZHJpdmVyIHRvIGVuYWJsZSBzdXBwbGllcyBwcm92 aWRlZCBieSB0aGUgaHctc3BlY2lmaWMKPiA+IGRyaXZlcnMuCj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IEhlaWtvIFN0dWVibmVyIDxoZWlrb0BzbnRlY2guZGU+Cj4gPiAtLS0KPiA+IGNoYW5nZXMg c2luY2UgdjE6Cj4gPiAtIGZvbGxvdyBzdWdnZXN0aW9uIGZyb20gUnVzc2VsbCBLaW5nIHRvIGtl ZXAgcmVndWxhdG9yIGhhbmRsaW5nIGxvY2FsCj4gPiAKPiA+ICAgdG8gdGhlIHJvY2tjaGlwIGlt cGxlbWVudGF0aW9uIGZvciB0aGUgdGltZSBiZWluZyBhbmQgb25seSBnZW5lcmFsaXplCj4gPiAg IHdoZW4gYSByZWFsIHNlY29uZCBpbXBsZW1lbnRhdGlvbiBuZWVkcyByZWd1bGF0b3IgaGFuZGxp bmcKPiA+ICAKPiA+ICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hkbWku dHh0ICAgICB8ICA1ICsrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHdfaGRtaS1y b2NrY2hpcC5jICAgICAgICB8IDMyCj4gPiAgKysrKysrKysrKysrKysrKysrKysrLSAyIGZpbGVz IGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3X2hk bWkudHh0Cj4gPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdl L2R3X2hkbWkudHh0IGluZGV4Cj4gPiBhOTA1YzE0Li5iYjc0NjQwIDEwMDY0NAo+ID4gLS0tIGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RybS9icmlkZ2UvZHdfaGRtaS50eHQK PiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kcm0vYnJpZGdlL2R3 X2hkbWkudHh0Cj4gPiBAQCAtMjIsNiArMjIsMTEgQEAgT3B0aW9uYWwgcHJvcGVydGllcwo+ID4g Cj4gPiAgLSBkZGMtaTJjLWJ1czogcGhhbmRsZSBvZiBhbiBJMkMgY29udHJvbGxlciB1c2VkIGZv ciBEREMgRURJRCBwcm9iaW5nCj4gPiAgLSBjbG9ja3MsIGNsb2NrLW5hbWVzOiBwaGFuZGxlIHRv IHRoZSBIRE1JIENFQyBjbG9jaywgbmFtZSBzaG91bGQgYmUKPiA+ICAiY2VjIgo+ID4gCj4gPiAr T3B0aW9uYWwgc3VwcGxpZXM6Cj4gPiArcm9ja2NoaXAscmszMjg4LWR3LWhkbWkgaGFuZGxlcyB0 d28gb3B0aW9uYWwgcG93ZXIgc3VwcGxpZXM6Cj4gPiArLSBhdmRkMXYwLXN1cHBseTogMS4wViBw b3dlciBzdXBwbHkKPiA+ICstIGF2ZGQxdjgtc3VwcGx5OiAxLjhWIHBvd2VyIHN1cHBseQo+IAo+ IEFyZSB0aGVzZSB0aGUgbmFtZXMgdXNlZCBpbiB0aGUgUm9ja2NoaXAgZG9jdW1lbnRhdGlvbj8K PiAKPiBTaW5jZSB0aGUgb2xkZXIgaW1wbGVtZW50YXRpb24gb24gaS5NWDYgdXNlcyAxLjFWIChI RE1JX1ZQKSBhbmQgMi41Vgo+IChIRE1JX1ZQSCksIEkgd29uZGVyIHdoZXRoZXIgZWFjaCBTb0Mg c2hvdWxkIHVzZSB0aGVpciBvd24gbmFtZSBvcgo+IHdoZXRoZXIgdGhlcmUgc2hvdWxkIGJlIGNv bW1vbiBuYW1lcyB0aGF0IGRvbid0IGluY2x1ZGUgdGhlIHZvbHRhZ2UuCj4gSSBkb24ndCBoYXZl IHRoZSBTeW5vcHN5cyBIRE1JIFRYIGRvY3MsIGJ1dCBJJ3ZlIHNlZW4gYXZkZGh2IGFuZCBhdmRk bHYKPiB1c2VkIG9mIG90aGVyIGNvcmVzJyBhbmFsb2cgc3VwcGxpZXMuCgpUaGUgcGlucyBvZiB0 aGUgc29jIGNvbm5lY3RlZCB0byB0aGUgcmVndWxhdG9ycyBhcmUgbmFtZWQ6CglIRE1JX0FWRERf MVYwCglIRE1JX0FWRERfMVY4ClRoZSBkYXRhc2hlZXQgb25seSBjYWxscyBib3RoICJEQyBzdXBw bHkgdm9sdGFnZSBmb3IgQW5hbG9nIHBhcnQgb2YgSERNSSIgYW5kIApuZXZlciBtZW50aW9ucyB0 aGVtIGFnYWluLgoKVGhlIGRhdGFib29rIG9mIHRoZSBJUCBibG9jayBpdHNlbGYgc2VlbXMgdG8g cmVhbGx5IGNhbGwgdGhpcyBWUEggYW5kIFZQIGFzIApwaHkgc3VwcGxpZXMsIGJ1dCBkb2N1bWVu dGF0aW9uIGlzIGEgYml0IHNwYXJzZSBhYm91dCB0aGVtLgoKSSBndWVzcyBhcyB3ZSBhbHJlYWR5 IHVzZSB0aGUgZGF0YWJvb2sgY2xvY2stbmFtZXMgSSBzaG91bGQgYWxzbyBzd2l0Y2ggdG8gdGhl IApkYXRhYm9vayBzdXBwbHkgbmFtZXMgKGF2ZGQxdjAgLT4gdnAgYW5kIGF2ZGQxdjggLT4gdnBo KS4KCgpIZWlrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=