Re: [PATCH v1] mm: Re-use DEFINE_SHOW_ATTRIBUTE() macro

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Sat, 2018-02-17 at 21:53 +0800, kbuild test robot wrote:
> Hi Andy,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on mmotm/master]
> [also build test ERROR on v4.16-rc1 next-20180216]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Andy-Shevchenko/mm-Re
> -use-DEFINE_SHOW_ATTRIBUTE-macro/20180217-204603
> base:   git://git.cmpxchg.org/linux-mmotm.git master
> config: i386-randconfig-a1-201806 (attached as .config)
> compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All errors (new ones prefixed by >>):
> 
>    mm/backing-dev.c:104:1: warning: data definition has no type or
> storage class
>     DEFINE_SHOW_ATTRIBUTE(bdi_debug_stats);
>     ^
>    mm/backing-dev.c:104:1: error: type defaults to 'int' in
> declaration of 'DEFINE_SHOW_ATTRIBUTE' [-Werror=implicit-int]
>    mm/backing-dev.c:104:1: warning: parameter names (without types) in
> function declaration
>    mm/backing-dev.c: In function 'bdi_debug_register':
> > > mm/backing-dev.c:116:19: error: 'bdi_debug_stats_fops' undeclared
> > > (first use in this function)
> 
>                 bdi, &bdi_debug_stats_fops);
>                       ^
>    mm/backing-dev.c:116:19: note: each undeclared identifier is
> reported only once for each function it appears in

But how?! DEFINE_SHOW_ATTRIBUTE() defines ->open() callback along with
struct file_operations.

I have no compilation error with gcc (Debian 7.3.0-3).

>    mm/zsmalloc.c:645:1: warning: data definition has no type or
> storage class
>     DEFINE_SHOW_ATTRIBUTE(zs_stats_size);
>     ^
>    mm/zsmalloc.c:645:1: error: type defaults to 'int' in declaration
> of 'DEFINE_SHOW_ATTRIBUTE' [-Werror=implicit-int]
>    mm/zsmalloc.c:645:1: warning: parameter names (without types) in
> function declaration
>    mm/zsmalloc.c: In function 'zs_pool_stat_create':
> > > mm/zsmalloc.c:664:30: error: 'zs_stat_size_ops' undeclared (first
> > > use in this function)
> 
>        pool->stat_dentry, pool, &zs_st
> at_size_ops);                                 ^

This one valid. Thanks, missed compilation!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>