From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Sat, 17 Feb 2018 17:41:24 +0100 Subject: [net-next PATCH v1 3/3] net: stmmac: dwmac-meson8b: make the clock configurations private In-Reply-To: <20180217140820.30257-4-martin.blumenstingl@googlemail.com> References: <20180217140820.30257-1-martin.blumenstingl@googlemail.com> <20180217140820.30257-4-martin.blumenstingl@googlemail.com> Message-ID: <1518885684.2883.111.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Sat, 2018-02-17 at 15:08 +0100, Martin Blumenstingl wrote: > The common clock framework needs access to the "clock configuration" > structs during runtime. > However, only the common clock framework should access these. Ensure > this by moving the configuration structs out of struct meson8b_dwmac, > so only meson8b_init_rgmii_tx_clk() and the common clock framework know > about these configurations. > > Suggested-by: Jerome Brunet > Signed-off-by: Martin Blumenstingl Acked-by: Jerome Brunet > --- > .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 45 ++++++++++++---------- > 1 file changed, 24 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c > index 0dfce35c5583..2d5d4aea3bcb 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c > @@ -49,19 +49,17 @@ > > struct meson8b_dwmac { > struct device *dev; > - > void __iomem *regs; > - > phy_interface_t phy_mode; > + struct clk *rgmii_tx_clk; > + u32 tx_delay_ns; > +}; > > +struct meson8b_dwmac_clk_configs { Not too sure we needed a struct for this, but it does work and does not matter much > struct clk_mux m250_mux; > struct clk_divider m250_div; > struct clk_fixed_factor fixed_div2; > struct clk_gate rgmii_tx_en; > - > - struct clk *rgmii_tx_clk; > - > - u32 tx_delay_ns; > }; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [net-next PATCH v1 3/3] net: stmmac: dwmac-meson8b: make the clock configurations private Date: Sat, 17 Feb 2018 17:41:24 +0100 Message-ID: <1518885684.2883.111.camel@baylibre.com> References: <20180217140820.30257-1-martin.blumenstingl@googlemail.com> <20180217140820.30257-4-martin.blumenstingl@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: khilman@baylibre.com, carlo@caione.org, narmstrong@baylibre.com To: Martin Blumenstingl , linux-amlogic@lists.infradead.org, netdev@vger.kernel.org Return-path: Received: from mail-wr0-f193.google.com ([209.85.128.193]:44645 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbeBQQl1 (ORCPT ); Sat, 17 Feb 2018 11:41:27 -0500 Received: by mail-wr0-f193.google.com with SMTP id v65so5648458wrc.11 for ; Sat, 17 Feb 2018 08:41:27 -0800 (PST) In-Reply-To: <20180217140820.30257-4-martin.blumenstingl@googlemail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 2018-02-17 at 15:08 +0100, Martin Blumenstingl wrote: > The common clock framework needs access to the "clock configuration" > structs during runtime. > However, only the common clock framework should access these. Ensure > this by moving the configuration structs out of struct meson8b_dwmac, > so only meson8b_init_rgmii_tx_clk() and the common clock framework know > about these configurations. > > Suggested-by: Jerome Brunet > Signed-off-by: Martin Blumenstingl Acked-by: Jerome Brunet > --- > .../net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 45 ++++++++++++---------- > 1 file changed, 24 insertions(+), 21 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c > index 0dfce35c5583..2d5d4aea3bcb 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c > @@ -49,19 +49,17 @@ > > struct meson8b_dwmac { > struct device *dev; > - > void __iomem *regs; > - > phy_interface_t phy_mode; > + struct clk *rgmii_tx_clk; > + u32 tx_delay_ns; > +}; > > +struct meson8b_dwmac_clk_configs { Not too sure we needed a struct for this, but it does work and does not matter much > struct clk_mux m250_mux; > struct clk_divider m250_div; > struct clk_fixed_factor fixed_div2; > struct clk_gate rgmii_tx_en; > - > - struct clk *rgmii_tx_clk; > - > - u32 tx_delay_ns; > };