From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] fix double ;;s in code Date: Tue, 20 Feb 2018 08:41:10 -0800 Message-ID: <1519144870.4326.7.camel@perches.com> References: <20180217211955.GE9640@amd> <187435d4-5017-edb5-9b6a-b433a148bfcc@c-s.fr> <20180219154135.GV22199@phenom.ffwll.local> <87vaesrxn0.fsf@concordia.ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <87vaesrxn0.fsf@concordia.ellerman.id.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Michael Ellerman , Daniel Vetter , Christophe LEROY Cc: daniel.lezcano@linaro.org, heiko@sntech.de, narmstrong@baylibre.com, airlied@linux.ie, benh@kernel.crashing.org, linus.walleij@linaro.org, Alexey.Brodkin@synopsys.com, will.deacon@arm.com, fbarrat@linux.vnet.ibm.com, kernel list , paulus@ozlabs.org, yamada.masahiro@socionext.com, mhocko@suse.com, viresh.kumar@linaro.org, Pavel Machek , hpa@zytor.com, JinHuiEric.Huang@amd.com, Rex.Zhu@amd.com, elfring@users.sourceforge.net, scott.bauer@intel.com, David1.Zhou@amd.com, architt@codeaurora.org, linux-arm-kernel@lists.infradead.org, joro@8bytes.org, x86@kernel.org, Wenjing.Liu@amd.com, linux@armlinux.org.uk, amd-gfx@lists.freedesktop.org, Ding.Wang@amd.com, aik@ozlabs.ru, wens@csie.org, mingo@redhat.com, vbabka@suse.cz, catalin.marinas@arm.com, airlied@redhat.com, ruscur@russell.cc, shli@kernel.org, dan.carpenter@oracle.com, andresx7@ List-Id: amd-gfx.lists.freedesktop.org On Tue, 2018-02-20 at 17:19 +1100, Michael Ellerman wrote: > Daniel Vetter writes: > > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: > > > Le 17/02/2018 =E0 22:19, Pavel Machek a =E9crit : > > > > = > > > > Fix double ;;'s in code. > > > > = > > > > Signed-off-by: Pavel Machek > > > = > > > A summary of the files modified on top of the patch would help unders= tand > > > the impact. > > > = > > > A maybe there should be one patch by area, eg one for each arch speci= fic > > > modif and one for drivers/ and one for block/ ? > > = > > Yeah, pls split this into one patch per area, with a suitable patch > > subject prefix. Look at git log of each file to get a feeling for what's > > the standard in each area. > = > This part is actually pretty annoying. > = > I hacked up a script (below) which seems to do a reasonable job in most > cases. Here was another suggestion from awhile ago https://lkml.org/lkml/2010/11/16/245 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1519144870.4326.7.camel@perches.com> Subject: Re: [PATCH] fix double ;;s in code From: Joe Perches To: Michael Ellerman , Daniel Vetter , Christophe LEROY Cc: Pavel Machek , elfring@users.sourceforge.net, kernel list , vgupta@synopsys.com, linux@armlinux.org.uk, oleg@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, paulus@ozlabs.org, benh@kernel.crashing.org, ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, scott.bauer@intel.com, jonathan.derrick@intel.com, axboe@kernel.dk, daniel.lezcano@linaro.org, maxime.ripard@free-electrons.com, wens@csie.org, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie, robdclark@gmail.com, joro@8bytes.org, shli@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, akpm@linux-foundation.org, Alexey.Brodkin@synopsys.com, mhocko@suse.com, vbabka@suse.cz, Vladislav.Zakharov@synopsys.com, noamca@mellanox.com, yamada.masahiro@socionext.com, sboyd@codeaurora.org, viresh.kumar@linaro.org, linus.walleij@linaro.org, heiko@sntech.de, aik@ozlabs.ru, ruscur@russell.cc, david@gibson.dropbear.id.au, fbarrat@linux.vnet.ibm.com, alistair@popple.id.au, robh@kernel.org, harry.wentland@amd.com, tony.cheng@amd.com, Wenjing.Liu@amd.com, airlied@redhat.com, Ding.Wang@amd.com, sylvia.tsai@amd.com, hersenxs.wu@amd.com, Rex.Zhu@amd.com, JinHuiEric.Huang@amd.com, dan.carpenter@oracle.com, architt@codeaurora.org, daniel.vetter@ffwll.ch, narmstrong@baylibre.com, ville.syrjala@linux.intel.com, jcrouse@codeaurora.org, aishpant@gmail.com, noralf@tronnes.org, andresx7@gmail.com, Monk.Liu@amd.com, nicolai.haehnle@amd.com, Andrey.Grodzovsky@amd.com, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-efi@vger.kernel.org, linux-block@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-raid@vger.kernel.org Date: Tue, 20 Feb 2018 08:41:10 -0800 In-Reply-To: <87vaesrxn0.fsf@concordia.ellerman.id.au> References: <20180217211955.GE9640@amd> <187435d4-5017-edb5-9b6a-b433a148bfcc@c-s.fr> <20180219154135.GV22199@phenom.ffwll.local> <87vaesrxn0.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 List-ID: On Tue, 2018-02-20 at 17:19 +1100, Michael Ellerman wrote: > Daniel Vetter writes: > > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: > > > Le 17/02/2018 � 22:19, Pavel Machek a �crit : > > > > > > > > Fix double ;;'s in code. > > > > > > > > Signed-off-by: Pavel Machek > > > > > > A summary of the files modified on top of the patch would help understand > > > the impact. > > > > > > A maybe there should be one patch by area, eg one for each arch specific > > > modif and one for drivers/ and one for block/ ? > > > > Yeah, pls split this into one patch per area, with a suitable patch > > subject prefix. Look at git log of each file to get a feeling for what's > > the standard in each area. > > This part is actually pretty annoying. > > I hacked up a script (below) which seems to do a reasonable job in most > cases. Here was another suggestion from awhile ago https://lkml.org/lkml/2010/11/16/245 From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Tue, 20 Feb 2018 08:41:10 -0800 Subject: [PATCH] fix double ;;s in code In-Reply-To: <87vaesrxn0.fsf@concordia.ellerman.id.au> References: <20180217211955.GE9640@amd> <187435d4-5017-edb5-9b6a-b433a148bfcc@c-s.fr> <20180219154135.GV22199@phenom.ffwll.local> <87vaesrxn0.fsf@concordia.ellerman.id.au> List-ID: Message-ID: <1519144870.4326.7.camel@perches.com> To: linux-snps-arc@lists.infradead.org On Tue, 2018-02-20@17:19 +1100, Michael Ellerman wrote: > Daniel Vetter writes: > > On Sun, Feb 18, 2018@11:00:56AM +0100, Christophe LEROY wrote: > > > Le 17/02/2018 ? 22:19, Pavel Machek a ?crit : > > > > > > > > Fix double ;;'s in code. > > > > > > > > Signed-off-by: Pavel Machek > > > > > > A summary of the files modified on top of the patch would help understand > > > the impact. > > > > > > A maybe there should be one patch by area, eg one for each arch specific > > > modif and one for drivers/ and one for block/ ? > > > > Yeah, pls split this into one patch per area, with a suitable patch > > subject prefix. Look at git log of each file to get a feeling for what's > > the standard in each area. > > This part is actually pretty annoying. > > I hacked up a script (below) which seems to do a reasonable job in most > cases. Here was another suggestion from awhile ago https://lkml.org/lkml/2010/11/16/245 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3zmFDJ45DTzF1Br for ; Wed, 21 Feb 2018 09:10:22 +1100 (AEDT) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave06.hostedemail.com (Postfix) with ESMTP id 8949A800EECB for ; Tue, 20 Feb 2018 16:46:35 +0000 (UTC) Message-ID: <1519144870.4326.7.camel@perches.com> Subject: Re: [PATCH] fix double ;;s in code From: Joe Perches To: Michael Ellerman , Daniel Vetter , Christophe LEROY Cc: Pavel Machek , elfring@users.sourceforge.net, kernel list , vgupta@synopsys.com, linux@armlinux.org.uk, oleg@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, paulus@ozlabs.org, benh@kernel.crashing.org, ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, scott.bauer@intel.com, jonathan.derrick@intel.com, axboe@kernel.dk, daniel.lezcano@linaro.org, maxime.ripard@free-electrons.com, wens@csie.org, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie, robdclark@gmail.com, joro@8bytes.org, shli@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, akpm@linux-foundation.org, Alexey.Brodkin@synopsys.com, mhocko@suse.com, vbabka@suse.cz, Vladislav.Zakharov@synopsys.com, noamca@mellanox.com, yamada.masahiro@socionext.com, sboyd@codeaurora.org, viresh.kumar@linaro.org, linus.walleij@linaro.org, heiko@sntech.de, aik@ozlabs.ru, ruscur@russell.cc, david@gibson.dropbear.id.au, fbarrat@linux.vnet.ibm.com, alistair@popple.id.au, robh@kernel.org, harry.wentland@amd.com, tony.cheng@amd.com, Wenjing.Liu@amd.com, airlied@redhat.com, Ding.Wang@amd.com, sylvia.tsai@amd.com, hersenxs.wu@amd.com, Rex.Zhu@amd.com, JinHuiEric.Huang@amd.com, dan.carpenter@oracle.com, architt@codeaurora.org, daniel.vetter@ffwll.ch, narmstrong@baylibre.com, ville.syrjala@linux.intel.com, jcrouse@codeaurora.org, aishpant@gmail.com, noralf@tronnes.org, andresx7@gmail.com, Monk.Liu@amd.com, nicolai.haehnle@amd.com, Andrey.Grodzovsky@amd.com, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-efi@vger.kernel.org, linux-block@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-raid@vger.kernel.org Date: Tue, 20 Feb 2018 08:41:10 -0800 In-Reply-To: <87vaesrxn0.fsf@concordia.ellerman.id.au> References: <20180217211955.GE9640@amd> <187435d4-5017-edb5-9b6a-b433a148bfcc@c-s.fr> <20180219154135.GV22199@phenom.ffwll.local> <87vaesrxn0.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2018-02-20 at 17:19 +1100, Michael Ellerman wrote: > Daniel Vetter writes: > > On Sun, Feb 18, 2018 at 11:00:56AM +0100, Christophe LEROY wrote: > > > Le 17/02/2018 à 22:19, Pavel Machek a écrit : > > > > > > > > Fix double ;;'s in code. > > > > > > > > Signed-off-by: Pavel Machek > > > > > > A summary of the files modified on top of the patch would help understand > > > the impact. > > > > > > A maybe there should be one patch by area, eg one for each arch specific > > > modif and one for drivers/ and one for block/ ? > > > > Yeah, pls split this into one patch per area, with a suitable patch > > subject prefix. Look at git log of each file to get a feeling for what's > > the standard in each area. > > This part is actually pretty annoying. > > I hacked up a script (below) which seems to do a reasonable job in most > cases. Here was another suggestion from awhile ago https://lkml.org/lkml/2010/11/16/245