From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
davem@davemloft.net, johannes.berg@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netlink: put module reference if dump start fails
Date: Tue, 20 Feb 2018 21:47:28 -0800 [thread overview]
Message-ID: <1519192048.55655.35.camel@gmail.com> (raw)
In-Reply-To: <20180221034159.14685-1-Jason@zx2c4.com>
On Wed, 2018-02-21 at 04:41 +0100, Jason A. Donenfeld wrote:
> Before, if cb->start() failed, the module reference would never be put,
> because cb->cb_running is intentionally false at this point. Users are
> generally annoyed by this because they can no longer unload modules that
> leak references. Also, it may be possible to tediously wrap a reference
> counter back to zero, especially since module.c still uses atomic_inc
> instead of refcount_inc.
>
> This patch expands the error path to simply call module_put if
> cb->start() fails.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> This probably should be queued up for stable.
When was the bug added ? This would help a lot stable teams ...
Thanks.
next prev parent reply other threads:[~2018-02-21 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 3:41 [PATCH] netlink: put module reference if dump start fails Jason A. Donenfeld
2018-02-21 5:47 ` Eric Dumazet [this message]
2018-02-21 14:54 ` Jason A. Donenfeld
2018-02-21 15:11 ` Eric Dumazet
2018-02-21 15:41 ` Jason A. Donenfeld
2018-02-22 6:16 ` Bo YU
2018-02-22 19:04 ` David Miller
2018-02-22 22:28 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519192048.55655.35.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.