From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH] drm/i915: Check for I915_MODE_FLAG_INHERITED before drm_atomic_helper_check_modeset Date: Wed, 21 Feb 2018 18:12:51 -0500 Message-ID: <1519254771.3735.25.camel@redhat.com> References: <20180221092808.30060-1-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id E940F6E6FB for ; Wed, 21 Feb 2018 23:12:53 +0000 (UTC) Received: by mail-qt0-f196.google.com with SMTP id c7so4131795qtn.3 for ; Wed, 21 Feb 2018 15:12:53 -0800 (PST) In-Reply-To: <20180221092808.30060-1-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org TmljZSwgdGhpcyBpcyBhIG5vLWJyYWluZXIKClJldmlld2VkLWJ5OiBMeXVkZSBQYXVsIDxseXVk ZUByZWRoYXQuY29tPgoKT24gV2VkLCAyMDE4LTAyLTIxIGF0IDEwOjI4ICswMTAwLCBNYWFydGVu IExhbmtob3JzdCB3cm90ZToKPiBNb3ZpbmcgdGhlIGNoZWNrIHVwd2FyZHMgd2lsbCBtZWFuIHdl IHdlIG5vIGxvbmdlciBoYXZlIHRvIGFkZCBwbGFuZXMKPiBhbmQgY29ubmVjdG9ycyBtYW51YWxs eSwgYmVjYXVzZSBldmVyeXRoaW5nIGlzIGhhbmRsZWQgY29ycmVjdGx5IGJ5Cj4gZHJtX2F0b21p Y19oZWxwZXJfY2hlY2tfbW9kZXNldCgpIGFzIGludGVuZGVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4g Q2M6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyB8IDIwICsrKysrLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+IGluZGV4IDY1YmU3YWY3ZjY0Ny4uYzVjYzkwMjJkNTQ1IDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMTkyNyw2ICsxMTkyNywxMSBAQCBz dGF0aWMgaW50IGludGVsX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2RldmljZQo+ICpkZXYsCj4g IAlpbnQgcmV0LCBpOwo+ICAJYm9vbCBhbnlfbXMgPSBmYWxzZTsKPiAgCj4gKwkvKiBDYXRjaCBJ OTE1X01PREVfRkxBR19JTkhFUklURUQgKi8KPiArCWZvcl9lYWNoX29sZG5ld19jcnRjX2luX3N0 YXRlKHN0YXRlLCBjcnRjLCBvbGRfY3J0Y19zdGF0ZSwKPiBjcnRjX3N0YXRlLCBpKQo+ICsJCWlm IChjcnRjX3N0YXRlLT5tb2RlLnByaXZhdGVfZmxhZ3MgIT0gb2xkX2NydGNfc3RhdGUtCj4gPm1v ZGUucHJpdmF0ZV9mbGFncykKPiArCQkJY3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsK PiArCj4gIAlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9jaGVja19tb2Rlc2V0KGRldiwgc3RhdGUp Owo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+IEBAIC0xMTkzNSwxMCArMTE5NDAsNiBA QCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2RldmljZQo+ICpkZXYs Cj4gIAkJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnID0KPiAgCQkJdG9faW50 ZWxfY3J0Y19zdGF0ZShjcnRjX3N0YXRlKTsKPiAgCj4gLQkJLyogQ2F0Y2ggSTkxNV9NT0RFX0ZM QUdfSU5IRVJJVEVEICovCj4gLQkJaWYgKGNydGNfc3RhdGUtPm1vZGUucHJpdmF0ZV9mbGFncyAh PSBvbGRfY3J0Y19zdGF0ZS0KPiA+bW9kZS5wcml2YXRlX2ZsYWdzKQo+IC0JCQljcnRjX3N0YXRl LT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+IC0KPiAgCQlpZiAoIW5lZWRzX21vZGVzZXQoY3J0Y19z dGF0ZSkpCj4gIAkJCWNvbnRpbnVlOwo+ICAKPiBAQCAtMTE5NDcsMTMgKzExOTQ4LDYgQEAgc3Rh dGljIGludCBpbnRlbF9hdG9taWNfY2hlY2soc3RydWN0IGRybV9kZXZpY2UKPiAqZGV2LAo+ICAJ CQljb250aW51ZTsKPiAgCQl9Cj4gIAo+IC0JCS8qIEZJWE1FOiBGb3Igb25seSBhY3RpdmVfY2hh bmdlZCB3ZSBzaG91bGRuJ3QgbmVlZCB0byBkbwo+IGFueQo+IC0JCSAqIHN0YXRlIHJlY29tcHV0 YXRpb24gYXQgYWxsLiAqLwo+IC0KPiAtCQlyZXQgPSBkcm1fYXRvbWljX2FkZF9hZmZlY3RlZF9j b25uZWN0b3JzKHN0YXRlLCBjcnRjKTsKPiAtCQlpZiAocmV0KQo+IC0JCQlyZXR1cm4gcmV0Owo+ IC0KPiAgCQlyZXQgPSBpbnRlbF9tb2Rlc2V0X3BpcGVfY29uZmlnKGNydGMsIHBpcGVfY29uZmln KTsKPiAgCQlpZiAocmV0KSB7Cj4gIAkJCWludGVsX2R1bXBfcGlwZV9jb25maWcodG9faW50ZWxf Y3J0YyhjcnRjKSwKPiBAQCAtMTE5NzIsMTAgKzExOTY2LDYgQEAgc3RhdGljIGludCBpbnRlbF9h dG9taWNfY2hlY2soc3RydWN0IGRybV9kZXZpY2UKPiAqZGV2LAo+ICAJCWlmIChuZWVkc19tb2Rl c2V0KGNydGNfc3RhdGUpKQo+ICAJCQlhbnlfbXMgPSB0cnVlOwo+ICAKPiAtCQlyZXQgPSBkcm1f YXRvbWljX2FkZF9hZmZlY3RlZF9wbGFuZXMoc3RhdGUsIGNydGMpOwo+IC0JCWlmIChyZXQpCj4g LQkJCXJldHVybiByZXQ7Cj4gLQo+ICAJCWludGVsX2R1bXBfcGlwZV9jb25maWcodG9faW50ZWxf Y3J0YyhjcnRjKSwgcGlwZV9jb25maWcsCj4gIAkJCQkgICAgICAgbmVlZHNfbW9kZXNldChjcnRj X3N0YXRlKSA/Cj4gIAkJCQkgICAgICAgIlttb2Rlc2V0XSIgOiAiW2Zhc3RzZXRdIik7Ci0tIApD aGVlcnMsCglMeXVkZSBQYXVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=