From: Debopriyo Ghosh <debopriyosoftdev@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org,
Debopriyo <debopriyosoftdev@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement
Date: Fri, 23 Feb 2018 00:57:16 +0530 [thread overview]
Message-ID: <1519327636-18972-1-git-send-email-debopriyosoftdev@gmail.com> (raw)
From: Debopriyo <debopriyosoftdev@gmail.com>
This is a patch to the rtllib_crypt_tkip.c file that fixes 2 issues found
by the checkpatch.pl tool
1.Use of __func__ instead of function name
2.proper code identation for else statement
Signed-off-by: Debopriyo Ghosh <debopriyosoftdev@gmail.com>
---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
index ae103b0..e462c1e 100644
--- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
+++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c
@@ -314,7 +314,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv)
tkip_mixing_phase2(rc4key, tkey->key, tkey->tx_ttak,
tkey->tx_iv16);
} else
- tkey->tx_phase1_done = 1;
+ tkey->tx_phase1_done = 1;
len = skb->len - hdr_len;
@@ -512,7 +512,7 @@ static int michael_mic(struct crypto_ahash *tfm_michael, u8 *key, u8 *hdr,
int err;
if (tfm_michael == NULL) {
- pr_warn("michael_mic: tfm_michael == NULL\n");
+ pr_warn("%s: tfm_michael == NULL\n", __func__);
return -1;
}
sg_init_table(sg, 2);
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2018-02-22 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 19:27 Debopriyo Ghosh [this message]
2018-02-23 8:17 ` [PATCH] Staging: rtl8192e: rtllib_crypt_tkip.c: Use __func__ instead of function name and proper code ident for else statement Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519327636-18972-1-git-send-email-debopriyosoftdev@gmail.com \
--to=debopriyosoftdev@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.