From: Dario Faggioli <dfaggioli@suse.com>
To: xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 3/5] tools: libxl/xl: allow to get/set Credit1's vcpu_migration_delay
Date: Fri, 23 Feb 2018 15:26:42 +0100 [thread overview]
Message-ID: <1519396002.5547.121.camel@suse.com> (raw)
In-Reply-To: <151931851789.5408.6727951847305599062.stgit@Solace.fritz.box>
[-- Attachment #1.1: Type: text/plain, Size: 1048 bytes --]
On Thu, 2018-02-22 at 17:55 +0100, Dario Faggioli wrote:
> --- a/tools/libxl/libxl_sched.c
> +++ b/tools/libxl/libxl_sched.c
> @@ -505,6 +507,9 @@ int main_sched_credit(int argc, char **argv)
> ratelimit = strtol(optarg, NULL, 10);
> opt_r = true;
> break;
> + case 'm':
> + migrdelay = strtol(optarg, NULL, 10);
> + opt_m = true;
>
This is missing a 'break'.
> case 's':
> opt_s = true;
> break;
> @@ -522,7 +527,7 @@ int main_sched_credit(int argc, char **argv)
> fprintf(stderr, "Must specify a domain.\n");
> return EXIT_FAILURE;
> }
> - if (!opt_s && (opt_t || opt_r)) {
> + if (!opt_s && (opt_t || opt_r || opt_w)) {
>
And this is 'opt_m'.
I'll send a v2. :-)
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-23 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 16:54 [PATCH 0/5] xen/tools: sched: Credit1: improve handling of vCPU migration delay Dario Faggioli
2018-02-22 16:55 ` [PATCH 1/5] xen: sched/credit: convert scheduling parameter to s_time_t when set Dario Faggioli
2018-02-22 16:55 ` [PATCH 2/5] xen: sched/credit1: make vcpu_migration_delay per-cpupool Dario Faggioli
2018-02-22 16:55 ` [PATCH 3/5] tools: libxl/xl: allow to get/set Credit1's vcpu_migration_delay Dario Faggioli
2018-02-22 17:52 ` Wei Liu
2018-02-23 14:26 ` Dario Faggioli [this message]
2018-02-22 16:55 ` [PATCH 4/5] tools: xenpm: continue to support {set, get}-vcpu-migration-delay Dario Faggioli
2018-02-22 17:52 ` Wei Liu
2018-02-22 16:55 ` [PATCH 5/5] xen/libxc: suppress direct access to Credit1's migration delay Dario Faggioli
2018-02-22 17:30 ` Wei Liu
2018-02-22 17:33 ` Wei Liu
2018-02-22 17:39 ` Dario Faggioli
2018-02-22 17:52 ` Wei Liu
2018-02-23 9:11 ` Jan Beulich
2018-02-23 9:25 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519396002.5547.121.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.