diff for duplicates of <1519665265.31245.6.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 7544722..393a3cd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,16 +1,16 @@ -On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote: +On Mon, 2018-02-26@18:53 +0200, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 5:14 PM, Evgeniy Didin > <Evgeniy.Didin@synopsys.com> wrote: -> > On Mon, 2018-02-26 at 16:39 +0200, Andy Shevchenko wrote: +> > On Mon, 2018-02-26@16:39 +0200, Andy Shevchenko wrote: > > > On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin > > > <Evgeniy.Didin@synopsys.com> wrote: > > > > In commit 4c2357f57dd5 ("mmc: dw_mmc: Fix the CTO timeout calculation") > > > > have been made changes which can cause multiply overflow for 32-bit systems. > > > > The value of cto_ms is lower the drto_ms, but nevertheless overflow can occur. > > > > Lets cast this multiply to u64 type which prevents overflow. -> > > > - cto_ms = DIV_ROUND_UP(MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz); +> > > > -???????cto_ms = DIV_ROUND_UP(MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz); > > > > + -> > > > + cto_ms = DIV_ROUND_UP((u64)MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz); +> > > > +???????cto_ms = DIV_ROUND_UP((u64)MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz); > > > > > > IIRC, someone commented on this or similar, i.e. > > > @@ -21,7 +21,7 @@ On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote: > > with sum overflow. > > Did you try to compile your code for 32-bit target? -Yes, we have compiled code for 32-bit system. +Yes, we have compiled code for 32-bit system.? I am wondering why are you asking that? -- diff --git a/a/content_digest b/N1/content_digest index 630ba5f..f22c808 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,35 +3,25 @@ "ref\0CAHp75Vct=jMohCFnn3aoZCAw-Q8=8OOF-nPXh9dfwrWHVPXSfA@mail.gmail.com\0" "ref\01519658060.31245.4.camel@synopsys.com\0" "ref\0CAHp75VeJhHWhxc4DBiqiu4n6raXbNQ0+W5YX_jthQd2OFF9F=w@mail.gmail.com\0" - "From\0Evgeniy Didin <Evgeniy.Didin@synopsys.com>\0" - "Subject\0Re: [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems\0" + "From\0Evgeniy.Didin@synopsys.com (Evgeniy Didin)\0" + "Subject\0[PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO overflow calculation for 32-bit systems\0" "Date\0Mon, 26 Feb 2018 17:14:26 +0000\0" - "To\0andy.shevchenko@gmail.com <andy.shevchenko@gmail.com>" - " Evgeniy.Didin@synopsys.com <Evgeniy.Didin@synopsys.com>\0" - "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" - Alexey.Brodkin@synopsys.com <Alexey.Brodkin@synopsys.com> - linux-mmc@vger.kernel.org <linux-mmc@vger.kernel.org> - dianders@chromium.org <dianders@chromium.org> - Vineet.Gupta1@synopsys.com <Vineet.Gupta1@synopsys.com> - Eugeniy.Paltsev@synopsys.com <Eugeniy.Paltsev@synopsys.com> - linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> - stable@vger.kernel.org <stable@vger.kernel.org> - " ulf.hansson@linaro.org <ulf.hansson@linaro.org>\0" + "To\0linux-snps-arc@lists.infradead.org\0" "\00:1\0" "b\0" - "On Mon, 2018-02-26 at 18:53 +0200, Andy Shevchenko wrote:\n" + "On Mon, 2018-02-26@18:53 +0200, Andy Shevchenko wrote:\n" "> On Mon, Feb 26, 2018 at 5:14 PM, Evgeniy Didin\n" "> <Evgeniy.Didin@synopsys.com> wrote:\n" - "> > On Mon, 2018-02-26 at 16:39 +0200, Andy Shevchenko wrote:\n" + "> > On Mon, 2018-02-26@16:39 +0200, Andy Shevchenko wrote:\n" "> > > On Mon, Feb 26, 2018 at 4:34 PM, Evgeniy Didin\n" "> > > <Evgeniy.Didin@synopsys.com> wrote:\n" "> > > > In commit 4c2357f57dd5 (\"mmc: dw_mmc: Fix the CTO timeout calculation\")\n" "> > > > have been made changes which can cause multiply overflow for 32-bit systems.\n" "> > > > The value of cto_ms is lower the drto_ms, but nevertheless overflow can occur.\n" "> > > > Lets cast this multiply to u64 type which prevents overflow.\n" - "> > > > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240cto_ms = DIV_ROUND_UP(MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz);\n" + "> > > > -???????cto_ms = DIV_ROUND_UP(MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz);\n" "> > > > +\n" - "> > > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240cto_ms = DIV_ROUND_UP((u64)MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz);\n" + "> > > > +???????cto_ms = DIV_ROUND_UP((u64)MSEC_PER_SEC * cto_clks * cto_div, host->bus_hz);\n" "> > > \n" "> > > IIRC, someone commented on this or similar, i.e.\n" "> > > \n" @@ -42,11 +32,11 @@ "> > with sum overflow.\n" "> \n" "> Did you try to compile your code for 32-bit target?\n" - "Yes, we have compiled code for 32-bit system.\302\240\n" + "Yes, we have compiled code for 32-bit system.?\n" "I am wondering why are you asking that?\n" "\n" "--\n" "Best regards,\n" Evgeniy Didin -11a4dbd7bbfc4b87a4284dc834674fb57c4b2ce796dea0d47ef3789c2a20a733 +abc671c75713305530ae77ae2055292ab20c369d52bb072b31cbad20ca1bd2fa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.