From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:33322 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbeBZThx (ORCPT ); Mon, 26 Feb 2018 14:37:53 -0500 Subject: Patch "binder: add missing binder_unlock()" has been added to the 4.9-stable tree To: ebiggers3@gmail.com, ebiggers@google.com, gregkh@linuxfoundation.org, linux@roeck-us.net, tkjos@android.com Cc: , From: Date: Mon, 26 Feb 2018 20:37:53 +0100 In-Reply-To: <20180226185645.241652-1-ebiggers3@gmail.com> Message-ID: <151967387378151@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled binder: add missing binder_unlock() to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: binder-add-missing-binder_unlock.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From ebiggers3@gmail.com Mon Feb 26 20:36:21 2018 From: Eric Biggers Date: Mon, 26 Feb 2018 10:56:45 -0800 Subject: binder: add missing binder_unlock() To: stable@vger.kernel.org, Greg Kroah-Hartman Cc: Guenter Roeck , Todd Kjos , Eric Biggers Message-ID: <20180226185645.241652-1-ebiggers3@gmail.com> From: Eric Biggers When commit 4be5a2810489 ("binder: check for binder_thread allocation failure in binder_poll()") was applied to 4.4-stable and 4.9-stable it was forgotten to release the global binder lock in the new error path. The global binder lock wasn't removed until v4.14, by commit a60b890f607d ("binder: remove global binder lock"). Fix the new error path to release the lock. Reported-by: Guenter Roeck Signed-off-by: Eric Biggers Signed-off-by: Greg Kroah-Hartman --- drivers/android/binder.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -2628,8 +2628,10 @@ static unsigned int binder_poll(struct f binder_lock(__func__); thread = binder_get_thread(proc); - if (!thread) + if (!thread) { + binder_unlock(__func__); return POLLERR; + } wait_for_proc_work = thread->transaction_stack == NULL && list_empty(&thread->todo) && thread->return_error == BR_OK; Patches currently in stable-queue which might be from ebiggers3@gmail.com are queue-4.9/binder-add-missing-binder_unlock.patch