From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] test_bpf: add a schedule point
Date: Mon, 26 Feb 2018 16:12:05 -0800 [thread overview]
Message-ID: <1519690325.3258.12.camel@gmail.com> (raw)
In-Reply-To: <dbbce67f-e39c-3d26-36e7-82868f0f98a1@iogearbox.net>
On Mon, 2018-02-26 at 21:11 +0100, Daniel Borkmann wrote:
> On 02/26/2018 07:52 PM, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@google.com>
> >
> > test_bpf() is taking 1.6 seconds nowadays, it is time
> > to add a schedule point in it.
> >
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>
> Applied to bpf tree, thanks Eric!
Thanks Daniel
Note that some BPF programs are quite expensive
[ 173.447471] test_bpf: #264 BPF_MAXINSNS: Call heavy transformations jited:1 19248 18548 PASS
jited:1 12519 PASS
[ 173.509228] test_bpf: #269 BPF_MAXINSNS: ld_abs+get_processor_id jited:1 20896 PASS
So we can still consume ~200 ms per test, without cond_resched()
Maybe reducing MAX_TESTRUNS from 10000 to 1000 would be the next step ?
next prev parent reply other threads:[~2018-02-27 0:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 18:52 [PATCH] test_bpf: add a schedule point Eric Dumazet
2018-02-26 20:11 ` Daniel Borkmann
2018-02-27 0:12 ` Eric Dumazet [this message]
2018-02-27 8:51 ` Daniel Borkmann
2018-02-28 16:39 ` [PATCH net] test_bpf: reduce MAX_TESTRUNS Eric Dumazet
2018-02-28 16:51 ` Daniel Borkmann
2018-02-28 16:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519690325.3258.12.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.