From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: inconsistent lock state with usbnet/asix usb ethernet and xhci Date: Tue, 27 Feb 2018 07:13:20 -0800 Message-ID: <1519744400.7296.10.camel@gmail.com> References: <1519740421.7296.6.camel@gmail.com> <1519744167.7296.8.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1519744167.7296.8.camel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski , netdev@vger.kernel.org, Linux USB Mailing List , LKML , 'Linux Samsung SOC' Cc: Dean Jenkins , Oliver Neukum List-Id: linux-samsung-soc@vger.kernel.org On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote: > > Note that for this one, it seems we also could perform stats updates in > BH context, since skb is queued via defer_bh() > > But simplicity wins I guess. Thinking more about this, I am not sure we have any guarantee that TX and RX can not run on multiple cpus. Using an unique syncp is not going to be safe, even if we make lockdep happy enough with the local_irq save/restore. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: inconsistent lock state with usbnet/asix usb ethernet and xhci From: Eric Dumazet Message-Id: <1519744400.7296.10.camel@gmail.com> Date: Tue, 27 Feb 2018 07:13:20 -0800 To: Marek Szyprowski , netdev@vger.kernel.org, Linux USB Mailing List , LKML , 'Linux Samsung SOC' Cc: Dean Jenkins , Oliver Neukum List-ID: T24gVHVlLCAyMDE4LTAyLTI3IGF0IDA3OjA5IC0wODAwLCBFcmljIER1bWF6ZXQgd3JvdGU6Cj4g Cj4gTm90ZSB0aGF0IGZvciB0aGlzIG9uZSwgaXQgc2VlbXMgd2UgYWxzbyBjb3VsZCBwZXJmb3Jt IHN0YXRzIHVwZGF0ZXMgaW4KPiBCSCBjb250ZXh0LCBzaW5jZSBza2IgaXMgcXVldWVkIHZpYSBk ZWZlcl9iaCgpCj4gCj4gQnV0IHNpbXBsaWNpdHkgd2lucyBJIGd1ZXNzLgoKVGhpbmtpbmcgbW9y ZSBhYm91dCB0aGlzLCBJIGFtIG5vdCBzdXJlIHdlIGhhdmUgYW55IGd1YXJhbnRlZSB0aGF0IFRY CmFuZCBSWCBjYW4gbm90IHJ1biBvbiBtdWx0aXBsZSBjcHVzLgoKVXNpbmcgYW4gdW5pcXVlIHN5 bmNwIGlzIG5vdCBnb2luZyB0byBiZSBzYWZlLCBldmVuIGlmIHdlIG1ha2UgbG9ja2RlcApoYXBw eSBlbm91Z2ggd2l0aCB0aGUgbG9jYWxfaXJxIHNhdmUvcmVzdG9yZS4KLS0tClRvIHVuc3Vic2Ny aWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2Ii IGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1v cmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWlu Zm8uaHRtbAo=