From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lyude Paul <lyude@redhat.com>
Subject: Re: [PATCH] drm/i915: Check for
 I915_MODE_FLAG_INHERITED before drm_atomic_helper_check_modeset
Date: Thu, 01 Mar 2018 21:03:00 -0500
Message-ID: <1519956180.9205.11.camel@redhat.com>
References: <20180221092808.30060-1-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com
 [209.85.220.193])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 925CC6ECC9
 for <intel-gfx@lists.freedesktop.org>; Fri,  2 Mar 2018 02:03:04 +0000 (UTC)
Received: by mail-qk0-f193.google.com with SMTP id l206so10251680qke.1
 for <intel-gfx@lists.freedesktop.org>; Thu, 01 Mar 2018 18:03:04 -0800 (PST)
In-Reply-To: <20180221092808.30060-1-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: intel-gfx@lists.freedesktop.org

UHVzaGVkIHdpdGggc29tZSBzbWFsbCB3aGl0ZXNwYWNlIGNoYW5nZXMgdG8gbWFrZSBzcGFyc2Ug
aGFwcHksIHRoYW5rcyEKCk9uIFdlZCwgMjAxOC0wMi0yMSBhdCAxMDoyOCArMDEwMCwgTWFhcnRl
biBMYW5raG9yc3Qgd3JvdGU6Cj4gTW92aW5nIHRoZSBjaGVjayB1cHdhcmRzIHdpbGwgbWVhbiB3
ZSB3ZSBubyBsb25nZXIgaGF2ZSB0byBhZGQgcGxhbmVzCj4gYW5kIGNvbm5lY3RvcnMgbWFudWFs
bHksIGJlY2F1c2UgZXZlcnl0aGluZyBpcyBoYW5kbGVkIGNvcnJlY3RseSBieQo+IGRybV9hdG9t
aWNfaGVscGVyX2NoZWNrX21vZGVzZXQoKSBhcyBpbnRlbmRlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5
OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+
IENjOiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxk
YW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5p
ZWwudmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
aXNwbGF5LmMgfCAyMCArKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBp
bnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9kaXNwbGF5LmMKPiBpbmRleCA2NWJlN2FmN2Y2NDcuLmM1Y2M5MDIyZDU0NSAxMDA2NDQKPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTE5MjcsNiArMTE5MjcsMTEgQEAg
c3RhdGljIGludCBpbnRlbF9hdG9taWNfY2hlY2soc3RydWN0IGRybV9kZXZpY2UKPiAqZGV2LAo+
ICAJaW50IHJldCwgaTsKPiAgCWJvb2wgYW55X21zID0gZmFsc2U7Cj4gIAo+ICsJLyogQ2F0Y2gg
STkxNV9NT0RFX0ZMQUdfSU5IRVJJVEVEICovCj4gKwlmb3JfZWFjaF9vbGRuZXdfY3J0Y19pbl9z
dGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsCj4gY3J0Y19zdGF0ZSwgaSkKPiArCQlp
ZiAoY3J0Y19zdGF0ZS0+bW9kZS5wcml2YXRlX2ZsYWdzICE9IG9sZF9jcnRjX3N0YXRlLQo+ID5t
b2RlLnByaXZhdGVfZmxhZ3MpCj4gKwkJCWNydGNfc3RhdGUtPm1vZGVfY2hhbmdlZCA9IHRydWU7
Cj4gKwo+ICAJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfY2hlY2tfbW9kZXNldChkZXYsIHN0YXRl
KTsKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiBAQCAtMTE5MzUsMTAgKzExOTQwLDYg
QEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY2hlY2soc3RydWN0IGRybV9kZXZpY2UKPiAqZGV2
LAo+ICAJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZyA9Cj4gIAkJCXRvX2lu
dGVsX2NydGNfc3RhdGUoY3J0Y19zdGF0ZSk7Cj4gIAo+IC0JCS8qIENhdGNoIEk5MTVfTU9ERV9G
TEFHX0lOSEVSSVRFRCAqLwo+IC0JCWlmIChjcnRjX3N0YXRlLT5tb2RlLnByaXZhdGVfZmxhZ3Mg
IT0gb2xkX2NydGNfc3RhdGUtCj4gPm1vZGUucHJpdmF0ZV9mbGFncykKPiAtCQkJY3J0Y19zdGF0
ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsKPiAtCj4gIAkJaWYgKCFuZWVkc19tb2Rlc2V0KGNydGNf
c3RhdGUpKQo+ICAJCQljb250aW51ZTsKPiAgCj4gQEAgLTExOTQ3LDEzICsxMTk0OCw2IEBAIHN0
YXRpYyBpbnQgaW50ZWxfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fZGV2aWNlCj4gKmRldiwKPiAg
CQkJY29udGludWU7Cj4gIAkJfQo+ICAKPiAtCQkvKiBGSVhNRTogRm9yIG9ubHkgYWN0aXZlX2No
YW5nZWQgd2Ugc2hvdWxkbid0IG5lZWQgdG8gZG8KPiBhbnkKPiAtCQkgKiBzdGF0ZSByZWNvbXB1
dGF0aW9uIGF0IGFsbC4gKi8KPiAtCj4gLQkJcmV0ID0gZHJtX2F0b21pY19hZGRfYWZmZWN0ZWRf
Y29ubmVjdG9ycyhzdGF0ZSwgY3J0Yyk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcmV0dXJuIHJldDsK
PiAtCj4gIAkJcmV0ID0gaW50ZWxfbW9kZXNldF9waXBlX2NvbmZpZyhjcnRjLCBwaXBlX2NvbmZp
Zyk7Cj4gIAkJaWYgKHJldCkgewo+ICAJCQlpbnRlbF9kdW1wX3BpcGVfY29uZmlnKHRvX2ludGVs
X2NydGMoY3J0YyksCj4gQEAgLTExOTcyLDEwICsxMTk2Niw2IEBAIHN0YXRpYyBpbnQgaW50ZWxf
YXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fZGV2aWNlCj4gKmRldiwKPiAgCQlpZiAobmVlZHNfbW9k
ZXNldChjcnRjX3N0YXRlKSkKPiAgCQkJYW55X21zID0gdHJ1ZTsKPiAgCj4gLQkJcmV0ID0gZHJt
X2F0b21pY19hZGRfYWZmZWN0ZWRfcGxhbmVzKHN0YXRlLCBjcnRjKTsKPiAtCQlpZiAocmV0KQo+
IC0JCQlyZXR1cm4gcmV0Owo+IC0KPiAgCQlpbnRlbF9kdW1wX3BpcGVfY29uZmlnKHRvX2ludGVs
X2NydGMoY3J0YyksIHBpcGVfY29uZmlnLAo+ICAJCQkJICAgICAgIG5lZWRzX21vZGVzZXQoY3J0
Y19zdGF0ZSkgPwo+ICAJCQkJICAgICAgICJbbW9kZXNldF0iIDogIltmYXN0c2V0XSIpOwotLSAK
Q2hlZXJzLAoJTHl1ZGUgUGF1bApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz
a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p
bnRlbC1nZngK