From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>,
Eric Dumazet <edumazet@google.com>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [Patch nf-next] netfilter: make xt_rateest hash table per net
Date: Thu, 01 Mar 2018 20:21:52 -0800 [thread overview]
Message-ID: <1519964512.11375.8.camel@gmail.com> (raw)
In-Reply-To: <20180302025838.904-1-xiyou.wangcong@gmail.com>
On Thu, 2018-03-01 at 18:58 -0800, Cong Wang wrote:
> As suggested by Eric, we need to make the xt_rateest
> hash table and its lock per netns to reduce lock
> contentions.
>
> Cc: Florian Westphal <fw@strlen.de>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
> include/net/netfilter/xt_rateest.h | 4 +-
> net/netfilter/xt_RATEEST.c | 91 +++++++++++++++++++++++++++-----------
> net/netfilter/xt_rateest.c | 10 ++---
> 3 files changed, 72 insertions(+), 33 deletions(-)
Very nice, thanks !
Reviewed-by: Eric Dumazet <edumazet@google.com>
Although the main reason was to avoid name collisions between different
netns.
Hash table is small enough that it can be allocated for each netns.
next prev parent reply other threads:[~2018-03-02 4:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 2:58 [Patch nf-next] netfilter: make xt_rateest hash table per net Cong Wang
2018-03-02 4:21 ` Eric Dumazet [this message]
2018-03-05 22:13 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519964512.11375.8.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.