Re: [PATCH] rte_memory.h: include stdio.h for FILE

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

Hi Huawei,

2014-06-17 03:48, Xie, Huawei:
> At least rte_tailq.h, rte_mbuf.h should also include stdio.h.

It has been fixed in this commit:
	http://dpdk.org/browse/dpdk/commit/?id=86d5de5c46fc0
But rte_memory.h was forgotten.
rte_mbuf.h has no problem because it includes rte_mempool.h which includes 
stdio.h.

-- 
Thomas


> -----Original Message-----
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Hiroshi Shimamoto
> Sent: Thursday, June 12, 2014 4:11 PM
> To: dev-VfR2kkLFssw@public.gmane.org
> Cc: Hayato Momma
> Subject: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE
> 
> From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> 
> The below commit requires stdio FILE structure.
> 
> commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188
> Author: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
> Date:   Fri May 2 16:42:56 2014 -0700
> 
>     add FILE argument to debug functions
> 
> Application which includes rte_memory.h without stdio.h will be hit
> compilation failure.
> 
> /path/to/include/rte_memory.h:146:30: error: unknown type name 'FILE'
>  void rte_dump_physmem_layout(FILE *f);
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
> Reviewed-by: Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
> ---
>  lib/librte_eal/common/include/rte_memory.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_memory.h
> b/lib/librte_eal/common/include/rte_memory.h index 7f21244..4cf8ea9 100644
> --- a/lib/librte_eal/common/include/rte_memory.h
> +++ b/lib/librte_eal/common/include/rte_memory.h
> @@ -42,6 +42,7 @@
> 
>  #include <stdint.h>
>  #include <stddef.h>
> +#include <stdio.h>
> 
>  #ifdef RTE_EXEC_ENV_LINUXAPP
>  #include <exec-env/rte_dom0_common.h>
> --
> 1.9.1