From mboxrd@z Thu Jan 1 00:00:00 1970 From: yannick fertre Subject: [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log Date: Fri, 2 Mar 2018 16:44:03 +0100 Message-ID: <1520005451-23217-3-git-send-email-yannick.fertre@st.com> References: <1520005451-23217-1-git-send-email-yannick.fertre@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F6BA6E17F for ; Fri, 2 Mar 2018 15:45:36 +0000 (UTC) In-Reply-To: <1520005451-23217-1-git-send-email-yannick.fertre@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vikas Manocha , Benjamin Gaignard , Yannick Fertre , Philippe Cornu , Patrice Chotard , Patrick DELAUNAY , Christophe KERELLO , Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Brian Norris , Bhumika Goyal , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Albert Aribaud , Simon Glass , Anatolij Gustschin , Thierry Reding Cc: u-boot@lists.denx.de, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org UmVwbGFjZSAgbWFjcm8gZGVidWcgYnkgcHJfZXJyb3IsIHByX3dhcm4gb3IgcHJfaW5mby4KClNp Z25lZC1vZmYtYnk6IHlhbm5pY2sgZmVydHJlIDx5YW5uaWNrLmZlcnRyZUBzdC5jb20+Ci0tLQog ZHJpdmVycy92aWRlby9zdG0zMi9zdG0zMl9sdGRjLmMgfCA2MiArKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygrKSwg MzEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy92aWRlby9zdG0zMi9zdG0zMl9s dGRjLmMgYi9kcml2ZXJzL3ZpZGVvL3N0bTMyL3N0bTMyX2x0ZGMuYwppbmRleCBiZDljMGRlLi5l OTVmMzVjIDEwMDY0NAotLS0gYS9kcml2ZXJzL3ZpZGVvL3N0bTMyL3N0bTMyX2x0ZGMuYworKysg Yi9kcml2ZXJzL3ZpZGVvL3N0bTMyL3N0bTMyX2x0ZGMuYwpAQCAtMTc2LDEzICsxNzYsMTMgQEAg c3RhdGljIHUzMiBzdG0zMl9sdGRjX2dldF9waXhlbF9mb3JtYXQoZW51bSB2aWRlb19sb2cyX2Jw cCBsMmJwcCkKIAljYXNlIFZJREVPX0JQUDI6CiAJY2FzZSBWSURFT19CUFA0OgogCWRlZmF1bHQ6 Ci0JCWRlYnVnKCIlczogd2FybmluZyAlZGJwcCBub3Qgc3VwcG9ydGVkIHlldCwgJWRicHAgaW5z dGVhZFxuIiwKLQkJICAgICAgX19mdW5jX18sIFZOQklUUyhsMmJwcCksIFZOQklUUyhWSURFT19C UFAxNikpOworCQlwcl93YXJuKCIlczogd2FybmluZyAlZGJwcCBub3Qgc3VwcG9ydGVkIHlldCwg JWRicHAgaW5zdGVhZFxuIiwKKwkJCV9fZnVuY19fLCBWTkJJVFMobDJicHApLCBWTkJJVFMoVklE RU9fQlBQMTYpKTsKIAkJcGYgPSBQRl9SR0I1NjU7CiAJCWJyZWFrOwogCX0KIAotCWRlYnVnKCIl czogJWQgYnBwIC0+IGx0ZGMgcGYgJWRcbiIsIF9fZnVuY19fLCBWTkJJVFMobDJicHApLCBwZik7 CisJcHJfaW5mbygiJXM6ICVkIGJwcCAtPiBsdGRjIHBmICVkXG4iLCBfX2Z1bmNfXywgVk5CSVRT KGwyYnBwKSwgcGYpOwogCiAJcmV0dXJuICh1MzIpcGY7CiB9CkBAIC0yNDksNyArMjQ5LDcgQEAg c3RhdGljIHZvaWQgc3RtMzJfbHRkY19zZXRfbW9kZShzdHJ1Y3Qgc3RtMzJfbHRkY19wcml2ICpw cml2LAogCiAJLyogU2lnbmFsIHBvbGFyaXRpZXMgKi8KIAl2YWwgPSAwOwotCWRlYnVnKCIlczog dGltaW5nLT5mbGFncyAweCUwOHhcbiIsIF9fZnVuY19fLCB0aW1pbmdzLT5mbGFncyk7CisJcHJf aW5mbygiJXM6IHRpbWluZy0+ZmxhZ3MgMHglMDh4XG4iLCBfX2Z1bmNfXywgdGltaW5ncy0+Zmxh Z3MpOwogCWlmICh0aW1pbmdzLT5mbGFncyAmIERJU1BMQVlfRkxBR1NfSFNZTkNfSElHSCkKIAkJ dmFsIHw9IEdDUl9IU1BPTDsKIAlpZiAodGltaW5ncy0+ZmxhZ3MgJiBESVNQTEFZX0ZMQUdTX1ZT WU5DX0hJR0gpCkBAIC0zNDMsMjYgKzM0MywyNiBAQCBzdGF0aWMgaW50IHN0bTMyX2x0ZGNfcHJv YmUoc3RydWN0IHVkZXZpY2UgKmRldikKIAogCXByaXYtPnJlZ3MgPSAodm9pZCAqKWRldl9yZWFk X2FkZHIoZGV2KTsKIAlpZiAoKGZkdF9hZGRyX3QpcHJpdi0+cmVncyA9PSBGRFRfQUREUl9UX05P TkUpIHsKLQkJZGVidWcoIiVzOiBsdGRjIGR0IHJlZ2lzdGVyIGFkZHJlc3MgZXJyb3JcbiIsIF9f ZnVuY19fKTsKKwkJcHJfZXJyKCIlczogbHRkYyBkdCByZWdpc3RlciBhZGRyZXNzIGVycm9yXG4i LCBfX2Z1bmNfXyk7CiAJCXJldHVybiAtRUlOVkFMOwogCX0KIAogCXJldCA9IGNsa19nZXRfYnlf aW5kZXgoZGV2LCAwLCAmcGNsayk7CiAJaWYgKHJldCkgewotCQlkZWJ1ZygiJXM6IHBlcmlwaGVy YWwgY2xvY2sgZ2V0IGVycm9yICVkXG4iLCBfX2Z1bmNfXywgcmV0KTsKKwkJcHJfZXJyKCIlczog cGVyaXBoZXJhbCBjbG9jayBnZXQgZXJyb3IgJWRcbiIsIF9fZnVuY19fLCByZXQpOwogCQlyZXR1 cm4gcmV0OwogCX0KIAogCXJldCA9IGNsa19lbmFibGUoJnBjbGspOwogCWlmIChyZXQpIHsKLQkJ ZGVidWcoIiVzOiBwZXJpcGhlcmFsIGNsb2NrIGVuYWJsZSBlcnJvciAlZFxuIiwKLQkJICAgICAg X19mdW5jX18sIHJldCk7CisJCXByX2VycigiJXM6IHBlcmlwaGVyYWwgY2xvY2sgZW5hYmxlIGVy cm9yICVkXG4iLAorCQkgICAgICAgX19mdW5jX18sIHJldCk7CiAJCXJldHVybiByZXQ7CiAJfQog CiAJcmV0ID0gcmVzZXRfZ2V0X2J5X2luZGV4KGRldiwgMCwgJnJzdCk7CiAJaWYgKHJldCkgewot CQlkZWJ1ZygiJXM6IG1pc3NpbmcgbHRkYyBoYXJkd2FyZSByZXNldFxuIiwgX19mdW5jX18pOwor CQlwcl9lcnIoIiVzOiBtaXNzaW5nIGx0ZGMgaGFyZHdhcmUgcmVzZXRcbiIsIF9fZnVuY19fKTsK IAkJcmV0dXJuIC1FTk9ERVY7CiAJfQogCkBAIC0zNzIsNDEgKzM3Miw0MCBAQCBzdGF0aWMgaW50 IHN0bTMyX2x0ZGNfcHJvYmUoc3RydWN0IHVkZXZpY2UgKmRldikKICNpZmRlZiBDT05GSUdfVklE RU9fQlJJREdFCiAJcmV0ID0gdWNsYXNzX2dldF9kZXZpY2UoVUNMQVNTX1ZJREVPX0JSSURHRSwg MCwgJmJyaWRnZSk7CiAJaWYgKHJldCkgewotCQlkZWJ1ZygiJXM6IE5vIHZpZGVvIGJyaWRnZSwg b3Igbm8gYmFja2xpZ2h0IG9uIGJyaWRnZVxuIiwKLQkJICAgICAgX19mdW5jX18pOworCQlwcl9p bmZvKCIlczogTm8gdmlkZW8gYnJpZGdlLCBvciBubyBiYWNrbGlnaHQgb24gYnJpZGdlXG4iLAor CQkJX19mdW5jX18pOwogCX0KIAogCWlmIChicmlkZ2UpIHsKIAkJcmV0ID0gdmlkZW9fYnJpZGdl X2F0dGFjaChicmlkZ2UpOwogCQlpZiAocmV0KSB7Ci0JCQlkZWJ1ZygiJXM6IGZhaWwgdG8gYXR0 YWNoIGJyaWRnZVxuIiwgX19mdW5jX18pOworCQkJcHJfZXJyKCIlczogZmFpbCB0byBhdHRhY2gg YnJpZGdlXG4iLCBfX2Z1bmNfXyk7CiAJCQlyZXR1cm4gcmV0OwogCQl9CiAJfQogI2VuZGlmCiAJ cmV0ID0gdWNsYXNzX2ZpcnN0X2RldmljZShVQ0xBU1NfUEFORUwsICZwYW5lbCk7CiAJaWYgKHJl dCkgewotCQlkZWJ1ZygiJXM6IHBhbmVsIGRldmljZSBlcnJvciAlZFxuIiwgX19mdW5jX18sIHJl dCk7CisJCXByX2VycigiJXM6IHBhbmVsIGRldmljZSBlcnJvciAlZFxuIiwgX19mdW5jX18sIHJl dCk7CiAJCXJldHVybiByZXQ7CiAJfQogCiAJcmV0ID0gZmR0ZGVjX2RlY29kZV9kaXNwbGF5X3Rp bWluZyhnZC0+ZmR0X2Jsb2IsIGRldl9vZl9vZmZzZXQocGFuZWwpLAogCQkJCQkgICAwLCAmdGlt aW5ncyk7CiAJaWYgKHJldCkgewotCQlkZWJ1ZygiJXM6IGRlY29kZSBkaXNwbGF5IHRpbWluZyBl cnJvciAlZFxuIiwKLQkJICAgICAgX19mdW5jX18sIHJldCk7CisJCXByX2VycigiJXM6IGRlY29k ZSBkaXNwbGF5IHRpbWluZyBlcnJvciAlZFxuIiwgX19mdW5jX18sIHJldCk7CiAJCXJldHVybiBy ZXQ7CiAJfQogCiAJcmF0ZSA9IGNsa19zZXRfcmF0ZSgmcGNsaywgdGltaW5ncy5waXhlbGNsb2Nr LnR5cCk7CiAJaWYgKHJhdGUgPCAwKSB7Ci0JCWRlYnVnKCIlczogZmFpbCB0byBzZXQgcGl4ZWwg Y2xvY2sgJWQgaHogJWQgaHpcbiIsCi0JCSAgICAgIF9fZnVuY19fLCB0aW1pbmdzLnBpeGVsY2xv Y2sudHlwLCByYXRlKTsKKwkJcHJfZXJyKCIlczogZmFpbCB0byBzZXQgcGl4ZWwgY2xvY2sgJWQg aHogJWQgaHpcbiIsCisJCSAgICAgICBfX2Z1bmNfXywgdGltaW5ncy5waXhlbGNsb2NrLnR5cCwg cmF0ZSk7CiAJCXJldHVybiByYXRlOwogCX0KIAotCWRlYnVnKCIlczogU2V0IHBpeGVsIGNsb2Nr IHJlcSAlZCBoeiBnZXQgJWQgaHpcbiIsIF9fZnVuY19fLAotCSAgICAgIHRpbWluZ3MucGl4ZWxj bG9jay50eXAsIHJhdGUpOworCXByX2luZm8oIiVzOiBTZXQgcGl4ZWwgY2xvY2sgcmVxICVkIGh6 IGdldCAlZCBoelxuIiwgX19mdW5jX18sCisJCXRpbWluZ3MucGl4ZWxjbG9jay50eXAsIHJhdGUp OwogCiAJLyogVE9ETyBCZWxvdyBwYXJhbWV0ZXJzIGFyZSBoYXJkLWNvZGVkIGZvciB0aGUgbW9t ZW50Li4uICovCiAJcHJpdi0+bDJicHAgPSBWSURFT19CUFAxNjsKQEAgLTQxNywxMiArNDE2LDEy IEBAIHN0YXRpYyBpbnQgc3RtMzJfbHRkY19wcm9iZShzdHJ1Y3QgdWRldmljZSAqZGV2KQogCXBy aXYtPmNyb3BfaCA9IHRpbWluZ3MudmFjdGl2ZS50eXA7CiAJcHJpdi0+YWxwaGEgPSAweEZGOwog Ci0JZGVidWcoIiVzOiAlZHglZCAlZGJwcCBmcmFtZSBidWZmZXIgYXQgMHglbHhcbiIsIF9fZnVu Y19fLAotCSAgICAgIHRpbWluZ3MuaGFjdGl2ZS50eXAsIHRpbWluZ3MudmFjdGl2ZS50eXAsCi0J ICAgICAgVk5CSVRTKHByaXYtPmwyYnBwKSwgdWNfcGxhdC0+YmFzZSk7Ci0JZGVidWcoIiVzOiBj cm9wICVkLCVkICVkeCVkIGJnIDB4JTA4eCBhbHBoYSAlZFxuIiwgX19mdW5jX18sCi0JICAgICAg cHJpdi0+Y3JvcF94LCBwcml2LT5jcm9wX3ksIHByaXYtPmNyb3BfdywgcHJpdi0+Y3JvcF9oLAot CSAgICAgIHByaXYtPmJnX2NvbF9hcmdiLCBwcml2LT5hbHBoYSk7CisJcHJfaW5mbygiJXM6ICVk eCVkICVkYnBwIGZyYW1lIGJ1ZmZlciBhdCAweCVseFxuIiwgX19mdW5jX18sCisJCXRpbWluZ3Mu aGFjdGl2ZS50eXAsIHRpbWluZ3MudmFjdGl2ZS50eXAsCisJCVZOQklUUyhwcml2LT5sMmJwcCks IHVjX3BsYXQtPmJhc2UpOworCXByX2luZm8oIiVzOiBjcm9wICVkLCVkICVkeCVkIGJnIDB4JTA4 eCBhbHBoYSAlZFxuIiwgX19mdW5jX18sCisJCXByaXYtPmNyb3BfeCwgcHJpdi0+Y3JvcF95LCBw cml2LT5jcm9wX3csIHByaXYtPmNyb3BfaCwKKwkJcHJpdi0+YmdfY29sX2FyZ2IsIHByaXYtPmFs cGhhKTsKIAogCS8qIENvbmZpZ3VyZSAmIHN0YXJ0IExUREMgKi8KIAlzdG0zMl9sdGRjX3NldF9t b2RlKHByaXYsICZ0aW1pbmdzKTsKQEAgLTQzNywyMiArNDM2LDIyIEBAIHN0YXRpYyBpbnQgc3Rt MzJfbHRkY19wcm9iZShzdHJ1Y3QgdWRldmljZSAqZGV2KQogCWlmIChicmlkZ2UpIHsKIAkJcmV0 ID0gdmlkZW9fYnJpZGdlX3NldF9iYWNrbGlnaHQoYnJpZGdlLCA4MCk7CiAJCWlmIChyZXQpIHsK LQkJCWRlYnVnKCIlczogZmFpbCB0byBzZXQgYmFja2xpZ2h0XG4iLCBfX2Z1bmNfXyk7CisJCQlw cl9lcnIoIiVzOiBmYWlsIHRvIHNldCBiYWNrbGlnaHRcbiIsIF9fZnVuY19fKTsKIAkJCXJldHVy biByZXQ7CiAJCX0KIAl9IGVsc2UgewogCQlyZXQgPSBwYW5lbF9lbmFibGVfYmFja2xpZ2h0KHBh bmVsKTsKIAkJaWYgKHJldCkgewotCQkJZGVidWcoIiVzOiBwYW5lbCAlcyBlbmFibGUgYmFja2xp Z2h0IGVycm9yICVkXG4iLAotCQkJICAgICAgX19mdW5jX18sIHBhbmVsLT5uYW1lLCByZXQpOwor CQkJcHJfZXJyKCIlczogcGFuZWwgJXMgZW5hYmxlIGJhY2tsaWdodCBlcnJvciAlZFxuIiwKKwkJ CSAgICAgICBfX2Z1bmNfXywgcGFuZWwtPm5hbWUsIHJldCk7CiAJCQlyZXR1cm4gcmV0OwogCQl9 CiAJfQogI2Vsc2UKIAlyZXQgPSBwYW5lbF9lbmFibGVfYmFja2xpZ2h0KHBhbmVsKTsKIAlpZiAo cmV0KSB7Ci0JCWRlYnVnKCIlczogcGFuZWwgJXMgZW5hYmxlIGJhY2tsaWdodCBlcnJvciAlZFxu IiwKLQkJICAgICAgX19mdW5jX18sIHBhbmVsLT5uYW1lLCByZXQpOworCQlwcl9lcnIoIiVzOiBw YW5lbCAlcyBlbmFibGUgYmFja2xpZ2h0IGVycm9yICVkXG4iLAorCQkgICAgICAgX19mdW5jX18s IHBhbmVsLT5uYW1lLCByZXQpOwogCQlyZXR1cm4gcmV0OwogCX0KICNlbmRpZgpAQCAtNDY4LDcg KzQ2Nyw4IEBAIHN0YXRpYyBpbnQgc3RtMzJfbHRkY19iaW5kKHN0cnVjdCB1ZGV2aWNlICpkZXYp CiAJdWNfcGxhdC0+c2l6ZSA9IENPTkZJR19WSURFT19TVE0zMl9NQVhfWFJFUyAqCiAJCQlDT05G SUdfVklERU9fU1RNMzJfTUFYX1lSRVMgKgogCQkJKENPTkZJR19WSURFT19TVE0zMl9NQVhfQlBQ ID4+IDMpOwotCWRlYnVnKCIlczogZnJhbWUgYnVmZmVyIG1heCBzaXplICVkIGJ5dGVzXG4iLCBf X2Z1bmNfXywgdWNfcGxhdC0+c2l6ZSk7CisJcHJfaW5mbygiJXM6IGZyYW1lIGJ1ZmZlciBtYXgg c2l6ZSAlZCBieXRlc1xuIiwgX19mdW5jX18sCisJCXVjX3BsYXQtPnNpemUpOwogCiAJcmV0dXJu IDA7CiB9Ci0tIAoxLjkuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946251AbeCBPpq (ORCPT ); Fri, 2 Mar 2018 10:45:46 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:33879 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1424353AbeCBPpm (ORCPT ); Fri, 2 Mar 2018 10:45:42 -0500 From: yannick fertre To: Vikas Manocha , Benjamin Gaignard , Yannick Fertre , Philippe Cornu , Patrice Chotard , Patrick DELAUNAY , Christophe KERELLO , Archit Taneja , Andrzej Hajda , "Laurent Pinchart" , David Airlie , Brian Norris , Bhumika Goyal , Gustavo Padovan , "Maarten Lankhorst" , Sean Paul , Albert Aribaud , "Simon Glass" , Anatolij Gustschin , Thierry Reding CC: , , Subject: [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log Date: Fri, 2 Mar 2018 16:44:03 +0100 Message-ID: <1520005451-23217-3-git-send-email-yannick.fertre@st.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1520005451-23217-1-git-send-email-yannick.fertre@st.com> References: <1520005451-23217-1-git-send-email-yannick.fertre@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.201.23.68] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-02_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace macro debug by pr_error, pr_warn or pr_info. Signed-off-by: yannick fertre --- drivers/video/stm32/stm32_ltdc.c | 62 ++++++++++++++++++++-------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/video/stm32/stm32_ltdc.c b/drivers/video/stm32/stm32_ltdc.c index bd9c0de..e95f35c 100644 --- a/drivers/video/stm32/stm32_ltdc.c +++ b/drivers/video/stm32/stm32_ltdc.c @@ -176,13 +176,13 @@ static u32 stm32_ltdc_get_pixel_format(enum video_log2_bpp l2bpp) case VIDEO_BPP2: case VIDEO_BPP4: default: - debug("%s: warning %dbpp not supported yet, %dbpp instead\n", - __func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16)); + pr_warn("%s: warning %dbpp not supported yet, %dbpp instead\n", + __func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16)); pf = PF_RGB565; break; } - debug("%s: %d bpp -> ltdc pf %d\n", __func__, VNBITS(l2bpp), pf); + pr_info("%s: %d bpp -> ltdc pf %d\n", __func__, VNBITS(l2bpp), pf); return (u32)pf; } @@ -249,7 +249,7 @@ static void stm32_ltdc_set_mode(struct stm32_ltdc_priv *priv, /* Signal polarities */ val = 0; - debug("%s: timing->flags 0x%08x\n", __func__, timings->flags); + pr_info("%s: timing->flags 0x%08x\n", __func__, timings->flags); if (timings->flags & DISPLAY_FLAGS_HSYNC_HIGH) val |= GCR_HSPOL; if (timings->flags & DISPLAY_FLAGS_VSYNC_HIGH) @@ -343,26 +343,26 @@ static int stm32_ltdc_probe(struct udevice *dev) priv->regs = (void *)dev_read_addr(dev); if ((fdt_addr_t)priv->regs == FDT_ADDR_T_NONE) { - debug("%s: ltdc dt register address error\n", __func__); + pr_err("%s: ltdc dt register address error\n", __func__); return -EINVAL; } ret = clk_get_by_index(dev, 0, &pclk); if (ret) { - debug("%s: peripheral clock get error %d\n", __func__, ret); + pr_err("%s: peripheral clock get error %d\n", __func__, ret); return ret; } ret = clk_enable(&pclk); if (ret) { - debug("%s: peripheral clock enable error %d\n", - __func__, ret); + pr_err("%s: peripheral clock enable error %d\n", + __func__, ret); return ret; } ret = reset_get_by_index(dev, 0, &rst); if (ret) { - debug("%s: missing ltdc hardware reset\n", __func__); + pr_err("%s: missing ltdc hardware reset\n", __func__); return -ENODEV; } @@ -372,41 +372,40 @@ static int stm32_ltdc_probe(struct udevice *dev) #ifdef CONFIG_VIDEO_BRIDGE ret = uclass_get_device(UCLASS_VIDEO_BRIDGE, 0, &bridge); if (ret) { - debug("%s: No video bridge, or no backlight on bridge\n", - __func__); + pr_info("%s: No video bridge, or no backlight on bridge\n", + __func__); } if (bridge) { ret = video_bridge_attach(bridge); if (ret) { - debug("%s: fail to attach bridge\n", __func__); + pr_err("%s: fail to attach bridge\n", __func__); return ret; } } #endif ret = uclass_first_device(UCLASS_PANEL, &panel); if (ret) { - debug("%s: panel device error %d\n", __func__, ret); + pr_err("%s: panel device error %d\n", __func__, ret); return ret; } ret = fdtdec_decode_display_timing(gd->fdt_blob, dev_of_offset(panel), 0, &timings); if (ret) { - debug("%s: decode display timing error %d\n", - __func__, ret); + pr_err("%s: decode display timing error %d\n", __func__, ret); return ret; } rate = clk_set_rate(&pclk, timings.pixelclock.typ); if (rate < 0) { - debug("%s: fail to set pixel clock %d hz %d hz\n", - __func__, timings.pixelclock.typ, rate); + pr_err("%s: fail to set pixel clock %d hz %d hz\n", + __func__, timings.pixelclock.typ, rate); return rate; } - debug("%s: Set pixel clock req %d hz get %d hz\n", __func__, - timings.pixelclock.typ, rate); + pr_info("%s: Set pixel clock req %d hz get %d hz\n", __func__, + timings.pixelclock.typ, rate); /* TODO Below parameters are hard-coded for the moment... */ priv->l2bpp = VIDEO_BPP16; @@ -417,12 +416,12 @@ static int stm32_ltdc_probe(struct udevice *dev) priv->crop_h = timings.vactive.typ; priv->alpha = 0xFF; - debug("%s: %dx%d %dbpp frame buffer at 0x%lx\n", __func__, - timings.hactive.typ, timings.vactive.typ, - VNBITS(priv->l2bpp), uc_plat->base); - debug("%s: crop %d,%d %dx%d bg 0x%08x alpha %d\n", __func__, - priv->crop_x, priv->crop_y, priv->crop_w, priv->crop_h, - priv->bg_col_argb, priv->alpha); + pr_info("%s: %dx%d %dbpp frame buffer at 0x%lx\n", __func__, + timings.hactive.typ, timings.vactive.typ, + VNBITS(priv->l2bpp), uc_plat->base); + pr_info("%s: crop %d,%d %dx%d bg 0x%08x alpha %d\n", __func__, + priv->crop_x, priv->crop_y, priv->crop_w, priv->crop_h, + priv->bg_col_argb, priv->alpha); /* Configure & start LTDC */ stm32_ltdc_set_mode(priv, &timings); @@ -437,22 +436,22 @@ static int stm32_ltdc_probe(struct udevice *dev) if (bridge) { ret = video_bridge_set_backlight(bridge, 80); if (ret) { - debug("%s: fail to set backlight\n", __func__); + pr_err("%s: fail to set backlight\n", __func__); return ret; } } else { ret = panel_enable_backlight(panel); if (ret) { - debug("%s: panel %s enable backlight error %d\n", - __func__, panel->name, ret); + pr_err("%s: panel %s enable backlight error %d\n", + __func__, panel->name, ret); return ret; } } #else ret = panel_enable_backlight(panel); if (ret) { - debug("%s: panel %s enable backlight error %d\n", - __func__, panel->name, ret); + pr_err("%s: panel %s enable backlight error %d\n", + __func__, panel->name, ret); return ret; } #endif @@ -468,7 +467,8 @@ static int stm32_ltdc_bind(struct udevice *dev) uc_plat->size = CONFIG_VIDEO_STM32_MAX_XRES * CONFIG_VIDEO_STM32_MAX_YRES * (CONFIG_VIDEO_STM32_MAX_BPP >> 3); - debug("%s: frame buffer max size %d bytes\n", __func__, uc_plat->size); + pr_info("%s: frame buffer max size %d bytes\n", __func__, + uc_plat->size); return 0; } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: yannick fertre Date: Fri, 2 Mar 2018 16:44:03 +0100 Subject: [U-Boot] [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log In-Reply-To: <1520005451-23217-1-git-send-email-yannick.fertre@st.com> References: <1520005451-23217-1-git-send-email-yannick.fertre@st.com> Message-ID: <1520005451-23217-3-git-send-email-yannick.fertre@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Replace macro debug by pr_error, pr_warn or pr_info. Signed-off-by: yannick fertre --- drivers/video/stm32/stm32_ltdc.c | 62 ++++++++++++++++++++-------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/video/stm32/stm32_ltdc.c b/drivers/video/stm32/stm32_ltdc.c index bd9c0de..e95f35c 100644 --- a/drivers/video/stm32/stm32_ltdc.c +++ b/drivers/video/stm32/stm32_ltdc.c @@ -176,13 +176,13 @@ static u32 stm32_ltdc_get_pixel_format(enum video_log2_bpp l2bpp) case VIDEO_BPP2: case VIDEO_BPP4: default: - debug("%s: warning %dbpp not supported yet, %dbpp instead\n", - __func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16)); + pr_warn("%s: warning %dbpp not supported yet, %dbpp instead\n", + __func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16)); pf = PF_RGB565; break; } - debug("%s: %d bpp -> ltdc pf %d\n", __func__, VNBITS(l2bpp), pf); + pr_info("%s: %d bpp -> ltdc pf %d\n", __func__, VNBITS(l2bpp), pf); return (u32)pf; } @@ -249,7 +249,7 @@ static void stm32_ltdc_set_mode(struct stm32_ltdc_priv *priv, /* Signal polarities */ val = 0; - debug("%s: timing->flags 0x%08x\n", __func__, timings->flags); + pr_info("%s: timing->flags 0x%08x\n", __func__, timings->flags); if (timings->flags & DISPLAY_FLAGS_HSYNC_HIGH) val |= GCR_HSPOL; if (timings->flags & DISPLAY_FLAGS_VSYNC_HIGH) @@ -343,26 +343,26 @@ static int stm32_ltdc_probe(struct udevice *dev) priv->regs = (void *)dev_read_addr(dev); if ((fdt_addr_t)priv->regs == FDT_ADDR_T_NONE) { - debug("%s: ltdc dt register address error\n", __func__); + pr_err("%s: ltdc dt register address error\n", __func__); return -EINVAL; } ret = clk_get_by_index(dev, 0, &pclk); if (ret) { - debug("%s: peripheral clock get error %d\n", __func__, ret); + pr_err("%s: peripheral clock get error %d\n", __func__, ret); return ret; } ret = clk_enable(&pclk); if (ret) { - debug("%s: peripheral clock enable error %d\n", - __func__, ret); + pr_err("%s: peripheral clock enable error %d\n", + __func__, ret); return ret; } ret = reset_get_by_index(dev, 0, &rst); if (ret) { - debug("%s: missing ltdc hardware reset\n", __func__); + pr_err("%s: missing ltdc hardware reset\n", __func__); return -ENODEV; } @@ -372,41 +372,40 @@ static int stm32_ltdc_probe(struct udevice *dev) #ifdef CONFIG_VIDEO_BRIDGE ret = uclass_get_device(UCLASS_VIDEO_BRIDGE, 0, &bridge); if (ret) { - debug("%s: No video bridge, or no backlight on bridge\n", - __func__); + pr_info("%s: No video bridge, or no backlight on bridge\n", + __func__); } if (bridge) { ret = video_bridge_attach(bridge); if (ret) { - debug("%s: fail to attach bridge\n", __func__); + pr_err("%s: fail to attach bridge\n", __func__); return ret; } } #endif ret = uclass_first_device(UCLASS_PANEL, &panel); if (ret) { - debug("%s: panel device error %d\n", __func__, ret); + pr_err("%s: panel device error %d\n", __func__, ret); return ret; } ret = fdtdec_decode_display_timing(gd->fdt_blob, dev_of_offset(panel), 0, &timings); if (ret) { - debug("%s: decode display timing error %d\n", - __func__, ret); + pr_err("%s: decode display timing error %d\n", __func__, ret); return ret; } rate = clk_set_rate(&pclk, timings.pixelclock.typ); if (rate < 0) { - debug("%s: fail to set pixel clock %d hz %d hz\n", - __func__, timings.pixelclock.typ, rate); + pr_err("%s: fail to set pixel clock %d hz %d hz\n", + __func__, timings.pixelclock.typ, rate); return rate; } - debug("%s: Set pixel clock req %d hz get %d hz\n", __func__, - timings.pixelclock.typ, rate); + pr_info("%s: Set pixel clock req %d hz get %d hz\n", __func__, + timings.pixelclock.typ, rate); /* TODO Below parameters are hard-coded for the moment... */ priv->l2bpp = VIDEO_BPP16; @@ -417,12 +416,12 @@ static int stm32_ltdc_probe(struct udevice *dev) priv->crop_h = timings.vactive.typ; priv->alpha = 0xFF; - debug("%s: %dx%d %dbpp frame buffer at 0x%lx\n", __func__, - timings.hactive.typ, timings.vactive.typ, - VNBITS(priv->l2bpp), uc_plat->base); - debug("%s: crop %d,%d %dx%d bg 0x%08x alpha %d\n", __func__, - priv->crop_x, priv->crop_y, priv->crop_w, priv->crop_h, - priv->bg_col_argb, priv->alpha); + pr_info("%s: %dx%d %dbpp frame buffer at 0x%lx\n", __func__, + timings.hactive.typ, timings.vactive.typ, + VNBITS(priv->l2bpp), uc_plat->base); + pr_info("%s: crop %d,%d %dx%d bg 0x%08x alpha %d\n", __func__, + priv->crop_x, priv->crop_y, priv->crop_w, priv->crop_h, + priv->bg_col_argb, priv->alpha); /* Configure & start LTDC */ stm32_ltdc_set_mode(priv, &timings); @@ -437,22 +436,22 @@ static int stm32_ltdc_probe(struct udevice *dev) if (bridge) { ret = video_bridge_set_backlight(bridge, 80); if (ret) { - debug("%s: fail to set backlight\n", __func__); + pr_err("%s: fail to set backlight\n", __func__); return ret; } } else { ret = panel_enable_backlight(panel); if (ret) { - debug("%s: panel %s enable backlight error %d\n", - __func__, panel->name, ret); + pr_err("%s: panel %s enable backlight error %d\n", + __func__, panel->name, ret); return ret; } } #else ret = panel_enable_backlight(panel); if (ret) { - debug("%s: panel %s enable backlight error %d\n", - __func__, panel->name, ret); + pr_err("%s: panel %s enable backlight error %d\n", + __func__, panel->name, ret); return ret; } #endif @@ -468,7 +467,8 @@ static int stm32_ltdc_bind(struct udevice *dev) uc_plat->size = CONFIG_VIDEO_STM32_MAX_XRES * CONFIG_VIDEO_STM32_MAX_YRES * (CONFIG_VIDEO_STM32_MAX_BPP >> 3); - debug("%s: frame buffer max size %d bytes\n", __func__, uc_plat->size); + pr_info("%s: frame buffer max size %d bytes\n", __func__, + uc_plat->size); return 0; } -- 1.9.1