From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: inconsistent lock state with usbnet/asix usb ethernet and xhci Date: Mon, 05 Mar 2018 12:46:07 +0100 Message-ID: <1520250367.3990.9.camel@suse.com> References: <1519740421.7296.6.camel@gmail.com> <1519744167.7296.8.camel@gmail.com> <1519744400.7296.10.camel@gmail.com> <1519747675.2649.3.camel@suse.com> <02679502-cf6e-8714-e879-50a922c5d976@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <02679502-cf6e-8714-e879-50a922c5d976@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski Cc: Eric Dumazet , LKML , 'Linux Samsung SOC' , Linux USB Mailing List , netdev@vger.kernel.org, Dean Jenkins List-Id: linux-samsung-soc@vger.kernel.org On Mon, 2018-03-05 at 08:45 +0100, Marek Szyprowski wrote: > Hi Oliver, > > On 2018-02-27 17:07, Oliver Neukum wrote: > > Am Dienstag, den 27.02.2018, 07:13 -0800 schrieb Eric Dumazet: > >> On Tue, 2018-02-27 at 07:09 -0800, Eric Dumazet wrote: > >>> > >>> Note that for this one, it seems we also could perform stats updates in > >>> BH context, since skb is queued via defer_bh() > >>> > >>> But simplicity wins I guess. > >> Thinking more about this, I am not sure we have any guarantee that TX > >> and RX can not run on multiple cpus. > >> > >> Using an unique syncp is not going to be safe, even if we make lockdep > >> happy enough with the local_irq save/restore. > > Unfortunately you are right. It is not guaranteed for some hardware. > > Does it mean that the fix proposed by Eric is not the proper solution? For asix it should work, but asix is unlikely to be the only driver with that issue. 32 bit recieves less testing nowadays. Regards Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: inconsistent lock state with usbnet/asix usb ethernet and xhci From: Oliver Neukum Message-Id: <1520250367.3990.9.camel@suse.com> Date: Mon, 05 Mar 2018 12:46:07 +0100 To: Marek Szyprowski Cc: Eric Dumazet , LKML , 'Linux Samsung SOC' , Linux USB Mailing List , netdev@vger.kernel.org, Dean Jenkins List-ID: T24gTW9uLCAyMDE4LTAzLTA1IGF0IDA4OjQ1ICswMTAwLCBNYXJlayBTenlwcm93c2tpIHdyb3Rl Ogo+IEhpIE9saXZlciwKPiAKPiBPbiAyMDE4LTAyLTI3IDE3OjA3LCBPbGl2ZXIgTmV1a3VtIHdy b3RlOgo+ID4gQW0gRGllbnN0YWcsIGRlbiAyNy4wMi4yMDE4LCAwNzoxMyAtMDgwMCBzY2hyaWVi IEVyaWMgRHVtYXpldDoKPiA+PiBPbiBUdWUsIDIwMTgtMDItMjcgYXQgMDc6MDkgLTA4MDAsIEVy aWMgRHVtYXpldCB3cm90ZToKPiA+Pj4KPiA+Pj4gTm90ZSB0aGF0IGZvciB0aGlzIG9uZSwgaXQg c2VlbXMgd2UgYWxzbyBjb3VsZCBwZXJmb3JtIHN0YXRzIHVwZGF0ZXMgaW4KPiA+Pj4gQkggY29u dGV4dCwgc2luY2Ugc2tiIGlzIHF1ZXVlZCB2aWEgZGVmZXJfYmgoKQo+ID4+Pgo+ID4+PiBCdXQg c2ltcGxpY2l0eSB3aW5zIEkgZ3Vlc3MuCj4gPj4gVGhpbmtpbmcgbW9yZSBhYm91dCB0aGlzLCBJ IGFtIG5vdCBzdXJlIHdlIGhhdmUgYW55IGd1YXJhbnRlZSB0aGF0IFRYCj4gPj4gYW5kIFJYIGNh biBub3QgcnVuIG9uIG11bHRpcGxlIGNwdXMuCj4gPj4KPiA+PiBVc2luZyBhbiB1bmlxdWUgc3lu Y3AgaXMgbm90IGdvaW5nIHRvIGJlIHNhZmUsIGV2ZW4gaWYgd2UgbWFrZSBsb2NrZGVwCj4gPj4g aGFwcHkgZW5vdWdoIHdpdGggdGhlIGxvY2FsX2lycSBzYXZlL3Jlc3RvcmUuCj4gPiBVbmZvcnR1 bmF0ZWx5IHlvdSBhcmUgcmlnaHQuIEl0IGlzIG5vdCBndWFyYW50ZWVkIGZvciBzb21lIGhhcmR3 YXJlLgo+IAo+IERvZXMgaXQgbWVhbiB0aGF0IHRoZSBmaXggcHJvcG9zZWQgYnkgRXJpYyBpcyBu b3QgdGhlIHByb3BlciBzb2x1dGlvbj8KCkZvciBhc2l4IGl0IHNob3VsZCB3b3JrLCBidXQgYXNp eCBpcyB1bmxpa2VseSB0byBiZSB0aGUgb25seSBkcml2ZXIKd2l0aCB0aGF0IGlzc3VlLiAzMiBi aXQgcmVjaWV2ZXMgbGVzcyB0ZXN0aW5nIG5vd2FkYXlzLgoKCVJlZ2FyZHMKCQlPbGl2ZXIKLS0t ClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmli ZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5r ZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcv bWFqb3Jkb21vLWluZm8uaHRtbAo=