From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/2] dmaengine: Introduce DW AXI DMAC driver From: Eugeniy Paltsev Message-Id: <1520265396.3152.27.camel@synopsys.com> Date: Mon, 5 Mar 2018 15:56:37 +0000 To: "andy.shevchenko@gmail.com" Cc: "vinod.koul@intel.com" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "Alexey.Brodkin@synopsys.com" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "wan.ahmad.zainie.wan.mohamad@intel.com" List-ID: VDI0Z1RXOXVMQ0F5TURFNExUQXlMVEkySUdGMElERTRPalF5SUNzd01qQXdMQ0JCYm1SNUlGTm9a WFpqYUdWdWEyOGdkM0p2ZEdVNgpEUW8rSUU5dUlFMXZiaXdnUm1WaUlESTJMQ0F5TURFNElHRjBJ RFE2TlRZZ1VFMHNJRVYxWjJWdWFYa2dVR0ZzZEhObGRnMEtQaUE4ClJYVm5aVzVwZVM1UVlXeDBj MlYyUUhONWJtOXdjM2x6TG1OdmJUNGdkM0p2ZEdVNkRRbytJQTBLUGlBK0lDc2dJQ0FnSUNBZ1ky aHAKY0MwK1kyOXlaVjlqYkdzZ1BTQmtaWFp0WDJOc2ExOW5aWFFvWTJocGNDMCtaR1YyTENBaVky OXlaUzFqYkdzaUtUc05DajRnRFFvKwpJRVJ2WlhNZ2RHaGxJRzVoYldVZ1kyOXRaU0JtY205dElH UmhkR0Z6YUdWbGREOE5DajRnRFFvK0lENGdLeUFnSUNBZ0lDQmphR2x3CkxUNWpabWR5WDJOc2F5 QTlJR1JsZG0xZlkyeHJYMmRsZENoamFHbHdMVDVrWlhZc0lDSmpabWR5TFdOc2F5SXBPdzBLUGlB TkNqNGcKUkdsMGRHOC9EUW9OQ2xsbGN5d2dkR2hsYzJVZ2JtRnRaWE1nWTJGdFpTQm1jbTl0SUdS aGRHRnphR1ZsZEM0TkNnMEtQaUErSUNzZwpJQ0FnSUNBZ2ZRMEtQaUErSUNzZ0lDQWdJQ0FnTHlv Z1JXNWhZbXhsSUdOc2F5QmlaV1p2Y21VZ1lXTmpaWE56YVc1bklIUnZJSEpsCloybHpkR1Z5Y3lB cUx3MEtQaUErSUNzZ0lDQWdJQ0FnWTJ4clgzQnlaWEJoY21WZlpXNWhZbXhsS0dOb2FYQXRQbU5t WjNKZlkyeHIKS1RzTkNqNGdQaUFySUNBZ0lDQWdJR05zYTE5d2NtVndZWEpsWDJWdVlXSnNaU2hq YUdsd0xUNWpiM0psWDJOc2F5azdEUW8rSUEwSwpQaUJGWVdOb0lHOW1JSFJvWlcwZ2JXRjVJR1po YVd3dUlFbHpJR2wwSUc5cllYay9EUW9OQ2tGeklHbDBJR2x6SUdSeWFYWmxjaUJ5ClpXMXZkbVVn WTJGc2JHSmhZMnNnU1NCbmRXVnpjeUJwZENCcGN5QnZhMkY1TGcwS0RRbytJRDRnSzNOMFlYUnBZ eUJqYjI1emRDQnoKZEhKMVkzUWdaR1YyWDNCdFgyOXdjeUJrZDE5aGVHbGZaRzFoWDNCdFgyOXdj eUE5SUhzTkNqNGdQaUFySUNBZ0lDQWdJRk5GVkY5UwpWVTVVU1UxRlgxQk5YMDlRVXloaGVHbGZa RzFoWDNKMWJuUnBiV1ZmYzNWemNHVnVaQ3dnWVhocFgyUnRZVjl5ZFc1MGFXMWxYM0psCmMzVnRa U3dnVGxWTVRDa05DajRnUGlBcmZUc05DajRnRFFvK0lFNXZJSE41YzNSbGJTQnpkWE53Wlc1a1B3 MEtEUXBCY21VZ2VXOTEKSUhSaGJHdHBibWNnWVdKdmRYUWdVMFZVWDFOWlUxUkZUVjlUVEVWRlVG OVFUVjlQVUZNL0RRcEpJR1J2YmlkMElHbHRjR3hsYldWdQpkQ0IwYUdWelpTQlBVRk1nWVhNZ2Qy VWdaRzl1SjNRZ2FHRjJaU0JoYm5rZ2NHeGhkR1p2Y20wZ2QyaHBZMmdnYUdGeklFUlhJRUZZClNT QkVUVUZERFFwaGJtUWdjM1Z3Y0c5eWRITWdjMnhsWlhCcGJtY2dMU0J6YnlCSklHTmhiaWQwSUhS bGMzUWdkR2hsYlM0TkNnMEsKTFMwZ0RRb2dSWFZuWlc1cGVTQlFZV3gwYzJWMgotLS0KVG8gdW5z dWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGRtYWVu Z2luZSIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5v cmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRv bW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev) Date: Mon, 5 Mar 2018 15:56:37 +0000 Subject: [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver In-Reply-To: References: <20180226145628.11892-1-Eugeniy.Paltsev@synopsys.com> <20180226145628.11892-2-Eugeniy.Paltsev@synopsys.com> List-ID: Message-ID: <1520265396.3152.27.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org On Mon, 2018-02-26@18:42 +0200, Andy Shevchenko wrote: > On Mon, Feb 26, 2018 at 4:56 PM, Eugeniy Paltsev > wrote: > > > + chip->core_clk = devm_clk_get(chip->dev, "core-clk"); > > Does the name come from datasheet? > > > + chip->cfgr_clk = devm_clk_get(chip->dev, "cfgr-clk"); > > Ditto? Yes, these names came from datasheet. > > + } > > + /* Enable clk before accessing to registers */ > > + clk_prepare_enable(chip->cfgr_clk); > > + clk_prepare_enable(chip->core_clk); > > Each of them may fail. Is it okay? As it is driver remove callback I guess it is okay. > > +static const struct dev_pm_ops dw_axi_dma_pm_ops = { > > + SET_RUNTIME_PM_OPS(axi_dma_runtime_suspend, axi_dma_runtime_resume, NULL) > > +}; > > No system suspend? Are you talking about SET_SYSTEM_SLEEP_PM_OPS? I don't implement these OPS as we don't have any platform which has DW AXI DMAC and supports sleeping - so I can't test them. -- Eugeniy Paltsev From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeniy Paltsev Subject: Re: [PATCH v2 1/2] dmaengine: Introduce DW AXI DMAC driver Date: Mon, 5 Mar 2018 15:56:37 +0000 Message-ID: <1520265396.3152.27.camel@synopsys.com> References: <20180226145628.11892-1-Eugeniy.Paltsev@synopsys.com> <20180226145628.11892-2-Eugeniy.Paltsev@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: "andy.shevchenko@gmail.com" Cc: "vinod.koul@intel.com" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "Alexey.Brodkin@synopsys.com" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" , "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "wan.ahmad.zainie.wan.mohamad@intel.com" List-Id: devicetree@vger.kernel.org T24gTW9uLCAyMDE4LTAyLTI2IGF0IDE4OjQyICswMjAwLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6 DQo+IE9uIE1vbiwgRmViIDI2LCAyMDE4IGF0IDQ6NTYgUE0sIEV1Z2VuaXkgUGFsdHNldg0KPiA8 RXVnZW5peS5QYWx0c2V2QHN5bm9wc3lzLmNvbT4gd3JvdGU6DQo+IA0KPiA+ICsgICAgICAgY2hp cC0+Y29yZV9jbGsgPSBkZXZtX2Nsa19nZXQoY2hpcC0+ZGV2LCAiY29yZS1jbGsiKTsNCj4gDQo+ IERvZXMgdGhlIG5hbWUgY29tZSBmcm9tIGRhdGFzaGVldD8NCj4gDQo+ID4gKyAgICAgICBjaGlw LT5jZmdyX2NsayA9IGRldm1fY2xrX2dldChjaGlwLT5kZXYsICJjZmdyLWNsayIpOw0KPiANCj4g RGl0dG8/DQoNClllcywgdGhlc2UgbmFtZXMgY2FtZSBmcm9tIGRhdGFzaGVldC4NCg0KPiA+ICsg ICAgICAgfQ0KPiA+ICsgICAgICAgLyogRW5hYmxlIGNsayBiZWZvcmUgYWNjZXNzaW5nIHRvIHJl Z2lzdGVycyAqLw0KPiA+ICsgICAgICAgY2xrX3ByZXBhcmVfZW5hYmxlKGNoaXAtPmNmZ3JfY2xr KTsNCj4gPiArICAgICAgIGNsa19wcmVwYXJlX2VuYWJsZShjaGlwLT5jb3JlX2Nsayk7DQo+IA0K PiBFYWNoIG9mIHRoZW0gbWF5IGZhaWwuIElzIGl0IG9rYXk/DQoNCkFzIGl0IGlzIGRyaXZlciBy ZW1vdmUgY2FsbGJhY2sgSSBndWVzcyBpdCBpcyBva2F5Lg0KDQo+ID4gK3N0YXRpYyBjb25zdCBz dHJ1Y3QgZGV2X3BtX29wcyBkd19heGlfZG1hX3BtX29wcyA9IHsNCj4gPiArICAgICAgIFNFVF9S VU5USU1FX1BNX09QUyhheGlfZG1hX3J1bnRpbWVfc3VzcGVuZCwgYXhpX2RtYV9ydW50aW1lX3Jl c3VtZSwgTlVMTCkNCj4gPiArfTsNCj4gDQo+IE5vIHN5c3RlbSBzdXNwZW5kPw0KDQpBcmUgeW91 IHRhbGtpbmcgYWJvdXQgU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFM/DQpJIGRvbid0IGltcGxlbWVu dCB0aGVzZSBPUFMgYXMgd2UgZG9uJ3QgaGF2ZSBhbnkgcGxhdGZvcm0gd2hpY2ggaGFzIERXIEFY SSBETUFDDQphbmQgc3VwcG9ydHMgc2xlZXBpbmcgLSBzbyBJIGNhbid0IHRlc3QgdGhlbS4NCg0K LS0gDQogRXVnZW5peSBQYWx0c2V2