From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH 5/6] libmultipath: Fix sgio_get_vpd() Date: Mon, 05 Mar 2018 18:09:18 +0100 Message-ID: <1520269758.7660.29.camel@suse.com> References: <20180301192935.14643-1-bart.vanassche@wdc.com> <20180301192935.14643-6-bart.vanassche@wdc.com> <1520268808.7660.23.camel@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1520268808.7660.23.camel@suse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Bart Van Assche , Christophe Varoqui Cc: dm-devel@redhat.com List-Id: dm-devel.ids T24gTW9uLCAyMDE4LTAzLTA1IGF0IDE3OjUzICswMTAwLCBNYXJ0aW4gV2lsY2sgd3JvdGU6Cj4g T24gVGh1LCAyMDE4LTAzLTAxIGF0IDExOjI5IC0wODAwLCBCYXJ0IFZhbiBBc3NjaGUgd3JvdGU6 Cj4gPiBQYXNzIHRoZSBWUEQgcGFnZSBudW1iZXIgdG8gc2dpb19nZXRfdnBkKCkgc3VjaCB0aGF0 IHRoZSBwYWdlCj4gPiBuZWVkZWQKPiA+IGJ5IHRoZSBjYWxsZXIgaXMgcXVlcmllZCBpbnN0ZWFk IG9mIHBhZ2UgMHg4My4gRml4IHRoZSBzdGF0ZW1lbnQKPiA+IHRoYXQKPiA+IGNvbXB1dGVzIHRo ZSBsZW5ndGggb2YgdGhlIHBhZ2UgcmV0dXJuZWQgYnkgZG9faW5xKCkuIEZpeCB0aGUKPiA+IHJl dHVybgo+ID4gY29kZSBjaGVjayBpbiB0aGUgY2FsbGVyIG9mIHNnaW9fZ2V0X3ZwZCgpLgo+ID4g Cj4gPiBTaWduZWQtb2ZmLWJ5OiBCYXJ0IFZhbiBBc3NjaGUgPGJhcnQudmFuYXNzY2hlQHdkYy5j b20+Cj4gPiAtLS0KPiAKPiBCYXJ0LCB0aGFua3MgZm9yIHRoZSBwYXRjaC4gUGxlYXNlIGNvbnNp ZGVyIHJlYmFzaW5nIHlvdXIgd29yayBvbiBteQo+IHByZXZpb3VzbHkgc3VibWl0dGVkIHBhdGNo ZXMgd2hpY2ggaGF2ZSBhbHJlYWR5IGJlZW4gcG9zaXRpdmVseQo+IHJldmlld2VkIChbMV0sIFsy XSk6Cj4gCj4gIGxpYm11bHRpcGF0aDogZ2V0X3ZwZF9zZ2lvOiBzdXBwb3J0IFZQRCAweGM5Cj4g IGxpYm11bHRpcGF0aDogc2dpb19nZXRfdnBkOiBhZGQgcGFnZSBhcmd1bWVudAo+ICBsaWJtdWx0 aXBhdGg6IGZpeCByZXR1cm4gY29kZSBvZiBzZ2lvX2dldF92cGQoKQo+IAo+IE90aGVyd2lzZSwg QUNLLgoKU29ycnksIEkgZm91bmQgYSBnbGl0Y2guCgpXaXRoIHRoZSBjaGFuZ2Ugb2YgdGhlICJs ZW4iIGNhbGN1bGF0aW9uIGFuZCB0aGUgcmV0dXJuIHZhbHVlIGNoZWNrLCB3ZQogIG5lZWQgdG8g bWFrZSBzdXJlIHN1ZmZpY2llbnQgZGF0YSBoYXMgYmVlbiByZWFkOgoKQEAgLTExMDAsMTMgKzEx MDEsMTkgQEAgZ2V0X3ZwZF9zZ2lvIChpbnQgZmQsIGludCBwZywgY2hhciAqIHN0ciwgaW50IG1h eGxlbikKIAl1bnNpZ25lZCBjaGFyIGJ1ZmZbNDA5Nl07CiAKIAltZW1zZXQoYnVmZiwgMHgwLCA0 MDk2KTsKLQlpZiAoc2dpb19nZXRfdnBkKGJ1ZmYsIDQwOTYsIGZkLCBwZykgPD0gMCkgeworCWJ1 ZmZfbGVuID0gc2dpb19nZXRfdnBkKGJ1ZmYsIDQwOTYsIGZkLCBwZyk7CisJaWYgKGJ1ZmZfbGVu IDwgMCkgewogCQljb25kbG9nKDMsICJmYWlsZWQgdG8gaXNzdWUgdnBkIGlucXVpcnkgZm9yIHBn JTAyeCIsCiAJCQlwZyk7Ci0JCXJldHVybiAtZXJybm87CisJCXJldHVybiBlcnJubyAhPSAwID8g LWVycm5vIDogLTE7CiAJfQogCi0JaWYgKGJ1ZmZbMV0gIT0gcGcpIHsKKwlpZiAoYnVmZl9sZW4g PCA0KSB7CisJCWNvbmRsb2coMywgInZwZCBwZyUwMnggZXJyb3IsIHNob3J0IHJlYWQiLCBwZyk7 CisJCXJldHVybiAtRU5PREFUQTsKKwl9CisKKwlpZiAoIGJ1ZmZbMV0gIT0gcGcpIHsKIAkJY29u ZGxvZygzLCAidnBkIHBnJTAyeCBlcnJvciwgaW52YWxpZCB2cGQgcGFnZSAlMDJ4IiwKIAkJCXBn LCBidWZmWzFdKTsKIAkJcmV0dXJuIC1FTk9EQVRBOwoKQXMgeW91IGNhbiBzZWUgSSBhZGRlZCBh bHNvIGEgc21hbGwgaHVuayB0aGF0IG1ha2VzIGl0IGV4cGxjaWNpdCB0aGF0CndlIGRvbid0IHJl dHVybiAwIG9uIGZhaWx1cmUgYnkgYWNjaWRlbnQuCgpSZWdhcmRzLApNYXJ0aW4KCi0tIApEci4g TWFydGluIFdpbGNrIDxtd2lsY2tAc3VzZS5jb20+LCBUZWwuICs0OSAoMCk5MTEgNzQwNTMgMjEw NwpTVVNFIExpbnV4IEdtYkgsIEdGOiBGZWxpeCBJbWVuZMO2cmZmZXIsIEphbmUgU21pdGhhcmQs IEdyYWhhbSBOb3J0b24KSFJCIDIxMjg0IChBRyBOw7xybmJlcmcpCgotLQpkbS1kZXZlbCBtYWls aW5nIGxpc3QKZG0tZGV2ZWxAcmVkaGF0LmNvbQpodHRwczovL3d3dy5yZWRoYXQuY29tL21haWxt YW4vbGlzdGluZm8vZG0tZGV2ZWw=