From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, davem@davemloft.net
Cc: Pierre-Yves Kerbrat <pkerbrat@kalray.eu>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Marius Gligor <mgligor@kalray.eu>
Subject: Re: [net-next 4/4] e1000e: allocate ring descriptors with dma_zalloc_coherent
Date: Mon, 05 Mar 2018 11:09:29 -0800 [thread overview]
Message-ID: <1520276969.5010.2.camel@intel.com> (raw)
In-Reply-To: <1520274223.109662.8.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Mon, 2018-03-05 at 10:23 -0800, Eric Dumazet wrote:
> On Mon, 2018-03-05 at 10:16 -0800, Jeff Kirsher wrote:
> > From: Pierre-Yves Kerbrat <pkerbrat@kalray.eu>
> >
> > Descriptor rings were not initialized at zero when allocated
> > When area contained garbage data, it caused skb_over_panic in
> > e1000_clean_rx_irq (if data had E1000_RXD_STAT_DD bit set)
> >
> > This patch makes use of dma_zalloc_coherent to make sure the
> > ring is memset at 0 to prevent the area from containing garbage.
> >
>
> This looks like a net candidate, fixing a bug, with 0 chance adding a
> regression IMO.
I am fine with that. Dave, let me know if you want me to re-submit
this change for net/stable.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-05 19:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 18:16 [net-next 0/4][pull request] 1GbE Intel Wired LAN Driver Updates 2018-03-05 Jeff Kirsher
2018-03-05 18:16 ` [net-next 1/4] igb: add VF trust infrastructure Jeff Kirsher
2018-03-05 18:16 ` [net-next 2/4] igb: Do not call netif_device_detach() when PCIe link goes missing Jeff Kirsher
2018-03-05 18:16 ` [net-next 3/4] igb: Fix a test with HWTSTAMP_TX_ON Jeff Kirsher
2018-03-05 18:16 ` [net-next 4/4] e1000e: allocate ring descriptors with dma_zalloc_coherent Jeff Kirsher
2018-03-05 18:23 ` Eric Dumazet
2018-03-05 19:09 ` Jeff Kirsher [this message]
2018-03-05 21:20 ` David Miller
2018-03-05 21:42 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520276969.5010.2.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jogreene@redhat.com \
--cc=mgligor@kalray.eu \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=pkerbrat@kalray.eu \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.