diff for duplicates of <1520290344.10396.357.camel@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 3c359ea..fdb1be5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,10 +6,10 @@ On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote: > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> -With this patch, the Pi doesn't find the TPM. I'm seeing the +With this patch, the Pi doesn't find the TPM. I'm seeing the following line in dmesg. -[ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 +[ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 Mimi @@ -41,7 +41,7 @@ Mimi > + if (rc) > return rc; > - -> - if (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS) +> - if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS) > + tpm_buf_append_u32(&buf, TPM2_CAP_TPM_PROPERTIES); > + tpm_buf_append_u32(&buf, TPM_PT_TOTAL_COMMANDS); > + tpm_buf_append_u32(&buf, 1); @@ -49,7 +49,7 @@ Mimi > + if (rc < 0) > + goto out; > + out = (struct tpm_output_header *)buf.data; -> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > chip->flags |= TPM_CHIP_FLAG_TPM2; > - > - return 0; diff --git a/a/content_digest b/N1/content_digest index f64392f..a487a22 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\020180305165614.5469-4-jarkko.sakkinen@linux.intel.com\0" "From\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" "Subject\0Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 05 Mar 2018 22:52:24 +0000\0" + "Date\0Mon, 05 Mar 2018 17:52:24 -0500\0" "To\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>" " linux-integrity@vger.kernel.org\0" "Cc\0linux-security-module@vger.kernel.org" @@ -22,10 +22,10 @@ "> \n" "> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" "\n" - "With this patch, the Pi doesn't find the TPM. \302\240I'm seeing the\n" + "With this patch, the Pi doesn't find the TPM. I'm seeing the\n" "following line in dmesg.\n" "\n" - "[\302\240\302\240\302\240\302\2401.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" + "[ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" "\n" "Mimi\n" "\n" @@ -57,7 +57,7 @@ "> +\tif (rc)\n" "> \t\treturn rc;\n" "> -\n" - "> -\tif (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS)\n" + "> -\tif (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)\n" "> +\ttpm_buf_append_u32(&buf, TPM2_CAP_TPM_PROPERTIES);\n" "> +\ttpm_buf_append_u32(&buf, TPM_PT_TOTAL_COMMANDS);\n" "> +\ttpm_buf_append_u32(&buf, 1);\n" @@ -65,7 +65,7 @@ "> +\tif (rc < 0)\n" "> +\t\tgoto out;\n" "> +\tout = (struct tpm_output_header *)buf.data;\n" - "> +\tif (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> +\tif (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> \t\tchip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> -\n" "> -\treturn 0;\n" @@ -76,4 +76,4 @@ "> EXPORT_SYMBOL_GPL(tpm2_probe);\n" > -e3db0062f926fb4596ca0228c132ed23cc92f29bbad75dbcc8359e3bcf84927f +65d1ad1fc4560a2f301eff6ceec4c216ba7d51a9b73ec1589ae67a55d60cbcee
diff --git a/a/1.txt b/N2/1.txt index 3c359ea..3501667 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -6,10 +6,10 @@ On Mon, 2018-03-05 at 18:56 +0200, Jarkko Sakkinen wrote: > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> -With this patch, the Pi doesn't find the TPM. I'm seeing the +With this patch, the Pi doesn't find the TPM. ?I'm seeing the following line in dmesg. -[ 1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 +[????1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256 Mimi @@ -41,7 +41,7 @@ Mimi > + if (rc) > return rc; > - -> - if (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS) +> - if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS) > + tpm_buf_append_u32(&buf, TPM2_CAP_TPM_PROPERTIES); > + tpm_buf_append_u32(&buf, TPM_PT_TOTAL_COMMANDS); > + tpm_buf_append_u32(&buf, 1); @@ -49,7 +49,7 @@ Mimi > + if (rc < 0) > + goto out; > + out = (struct tpm_output_header *)buf.data; -> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > chip->flags |= TPM_CHIP_FLAG_TPM2; > - > - return 0; @@ -58,4 +58,9 @@ Mimi > + return rc; > } > EXPORT_SYMBOL_GPL(tpm2_probe); -> +> + +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index f64392f..b73be9b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,17 +1,9 @@ "ref\020180305165614.5469-1-jarkko.sakkinen@linux.intel.com\0" "ref\020180305165614.5469-4-jarkko.sakkinen@linux.intel.com\0" - "From\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" - "Subject\0Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 05 Mar 2018 22:52:24 +0000\0" - "To\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>" - " linux-integrity@vger.kernel.org\0" - "Cc\0linux-security-module@vger.kernel.org" - keyrings@vger.kernel.org - Peter Huewe <peterhuewe@gmx.de> - Jason Gunthorpe <jgg@ziepe.ca> - Arnd Bergmann <arnd@arndb.de> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - " open list <linux-kernel@vger.kernel.org>\0" + "From\0zohar@linux.vnet.ibm.com (Mimi Zohar)\0" + "Subject\0[PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" + "Date\0Mon, 05 Mar 2018 17:52:24 -0500\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "Hi Jarrko,\n" @@ -22,10 +14,10 @@ "> \n" "> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\n" "\n" - "With this patch, the Pi doesn't find the TPM. \302\240I'm seeing the\n" + "With this patch, the Pi doesn't find the TPM. ?I'm seeing the\n" "following line in dmesg.\n" "\n" - "[\302\240\302\240\302\240\302\2401.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" + "[????1.087414] tpm_tis_spi: probe of spi0.0 failed with error 256\n" "\n" "Mimi\n" "\n" @@ -57,7 +49,7 @@ "> +\tif (rc)\n" "> \t\treturn rc;\n" "> -\n" - "> -\tif (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS)\n" + "> -\tif (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)\n" "> +\ttpm_buf_append_u32(&buf, TPM2_CAP_TPM_PROPERTIES);\n" "> +\ttpm_buf_append_u32(&buf, TPM_PT_TOTAL_COMMANDS);\n" "> +\ttpm_buf_append_u32(&buf, 1);\n" @@ -65,7 +57,7 @@ "> +\tif (rc < 0)\n" "> +\t\tgoto out;\n" "> +\tout = (struct tpm_output_header *)buf.data;\n" - "> +\tif (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> +\tif (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> \t\tchip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> -\n" "> -\treturn 0;\n" @@ -74,6 +66,11 @@ "> +\treturn rc;\n" "> }\n" "> EXPORT_SYMBOL_GPL(tpm2_probe);\n" - > + "> \n" + "\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -e3db0062f926fb4596ca0228c132ed23cc92f29bbad75dbcc8359e3bcf84927f +275c997e0adb7febb5b354ed75510c5498d612d956ae0b125f49cf4468efef61
diff --git a/a/1.txt b/N3/1.txt index 3c359ea..b1a457e 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -41,7 +41,7 @@ Mimi > + if (rc) > return rc; > - -> - if (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS) +> - if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS) > + tpm_buf_append_u32(&buf, TPM2_CAP_TPM_PROPERTIES); > + tpm_buf_append_u32(&buf, TPM_PT_TOTAL_COMMANDS); > + tpm_buf_append_u32(&buf, 1); @@ -49,7 +49,7 @@ Mimi > + if (rc < 0) > + goto out; > + out = (struct tpm_output_header *)buf.data; -> + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > chip->flags |= TPM_CHIP_FLAG_TPM2; > - > - return 0; diff --git a/a/content_digest b/N3/content_digest index f64392f..976aad3 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,7 +2,7 @@ "ref\020180305165614.5469-4-jarkko.sakkinen@linux.intel.com\0" "From\0Mimi Zohar <zohar@linux.vnet.ibm.com>\0" "Subject\0Re: [PATCH v3 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 05 Mar 2018 22:52:24 +0000\0" + "Date\0Mon, 05 Mar 2018 17:52:24 -0500\0" "To\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>" " linux-integrity@vger.kernel.org\0" "Cc\0linux-security-module@vger.kernel.org" @@ -57,7 +57,7 @@ "> +\tif (rc)\n" "> \t\treturn rc;\n" "> -\n" - "> -\tif (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS)\n" + "> -\tif (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)\n" "> +\ttpm_buf_append_u32(&buf, TPM2_CAP_TPM_PROPERTIES);\n" "> +\ttpm_buf_append_u32(&buf, TPM_PT_TOTAL_COMMANDS);\n" "> +\ttpm_buf_append_u32(&buf, 1);\n" @@ -65,7 +65,7 @@ "> +\tif (rc < 0)\n" "> +\t\tgoto out;\n" "> +\tout = (struct tpm_output_header *)buf.data;\n" - "> +\tif (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> +\tif (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> \t\tchip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> -\n" "> -\treturn 0;\n" @@ -76,4 +76,4 @@ "> EXPORT_SYMBOL_GPL(tpm2_probe);\n" > -e3db0062f926fb4596ca0228c132ed23cc92f29bbad75dbcc8359e3bcf84927f +1ea51c55997364b8f8aea7442eb04644d8620d756c432cbd0e162ac420beccf7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.