From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sahil Rihan <srihan@fb.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Subject: Re: [Regression] TPM char device not created if TPM 1.2 is disabled, but visible
Date: Tue, 06 Mar 2018 13:13:51 +0200 [thread overview]
Message-ID: <1520334831.7549.5.camel@linux.intel.com> (raw)
In-Reply-To: <7A0881B1-6581-4D0B-A4A9-B014F995B338@fb.com>
On Mon, 2018-03-05 at 19:28 +0000, Sahil Rihan wrote:
> Agree on keeping the warning.
>
> I'm guessing you want to return -ENODEV from tpm_bios_log_setup. Doing it from
> tpm_read_log_acpi will just fall through to calling tpm_read_log_of, which I
> think will end up returning -EIO again.
>
> In terms of semantics I'm not sure if -ENODEV is the right return code if the
> BIOS event log is absent. I guess you can claim it's some sort of "device". I
> don’t have a strong opinion here.
>
> Sahil
You are absolutely right. Printing warning and returning zero would be
the right measure to take.
One more cosmetic detail. Should the log level be info or warn? I mean
as far as I'm concerned everything is in a legit state.
/Jarkko
next prev parent reply other threads:[~2018-03-06 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 21:27 [Regression] TPM char device not created if TPM 1.2 is disabled, but visible Sahil Rihan
2018-03-05 12:14 ` Jarkko Sakkinen
2018-03-05 19:28 ` Sahil Rihan
2018-03-06 11:13 ` Jarkko Sakkinen [this message]
2018-03-07 22:34 ` Sahil Rihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520334831.7549.5.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ast@fb.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srihan@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.